From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::142; helo=mail-it1-x142.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1A2C52118A5AD for ; Mon, 12 Nov 2018 02:24:41 -0800 (PST) Received: by mail-it1-x142.google.com with SMTP id m34-v6so11827917iti.1 for ; Mon, 12 Nov 2018 02:24:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wHpnwjEEYDsmcZiN9heSajp8diygqnj4pi6ex8bRmtU=; b=Uh/AA9weLdU2LYWHAVGPU0qELwpzk98ci9x+3p5mtwZq4Adzx+C2jG6eCSBbZICV5b kFYahzR9cjljrFZBLQgD9lNaw6ZyH3cr0oQoKhZuc2cde1K97II8Tyz/BncLtKOBeMGM UlUH5iYBpdwQy10NWad2rrUV2OJ8kGFKJA1e8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wHpnwjEEYDsmcZiN9heSajp8diygqnj4pi6ex8bRmtU=; b=j3CakenmyYb5QOMj6FQMunrIV5nrSoYyCVwdApqITZrJclYiEt3QkuFnV7rhVw1jtS alGb9Az8apfgKNo9a434Gplu8mxL6ov9WrSafG4fCT/nK90jDqRyHLkNZHczzZX/BwOm w/PsWzmzpDOZOgYj/qHY+uUZPMADcWXiVdXOaEF0f6DjgMho4Zi1zCEt7AOiaKfPYmHa khptfqjDST9wRU++NFZqoqbAAygH7AS5gyDNvsEivNpCKtH7A/iABXubRnijX3rhrGfQ Kw4HgNwCJQvfGR2b+ojaxxb0VxOTjHldj2l+OgQsuuH2G3X8KKvxSXm3Y0/JYhFJueA7 ItKg== X-Gm-Message-State: AGRZ1gJhelZG1O1e0nkP7oY4CcOYNouo55O5fB8M5wHrMW40+x0ky15l XKPdfdRyA+Li1okhL2iC1P7JkSxLz9lPbkYDNlnSbQ== X-Google-Smtp-Source: AJdET5dgLhFROTEwXJGBVMFngSMCKtIxS8CnSE0xwnaqEf3Xnc1jQSb6G1sh9t/cjMIphODIgaKn4iaHa4I59IAd+UA= X-Received: by 2002:a02:9f85:: with SMTP id a5-v6mr279167jam.2.1542018280285; Mon, 12 Nov 2018 02:24:40 -0800 (PST) MIME-Version: 1.0 References: <1541804508-27499-1-git-send-email-mw@semihalf.com> <1541804508-27499-2-git-send-email-mw@semihalf.com> In-Reply-To: <1541804508-27499-2-git-send-email-mw@semihalf.com> From: Ard Biesheuvel Date: Mon, 12 Nov 2018 11:24:28 +0100 Message-ID: To: Marcin Wojtas Cc: "edk2-devel@lists.01.org" , Leif Lindholm , "Wu, Hao A" , Nadav Haklai , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Grzegorz Jaszczyk , Kostya Porotchkin , Tomasz Michalec Subject: Re: [platforms: PATCH v4 1/7] Silicon/SynQuacer/PlatformDxe: adjust to updated SdMmcOverride X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Nov 2018 10:24:41 -0000 Content-Type: text/plain; charset="UTF-8" On Sat, 10 Nov 2018 at 00:02, Marcin Wojtas wrote: > > The newest changes in the SdMmcOverride protocol added additional > arguments to the NotifyPhase and Capability routines. Update > according places in the Synquacer Emmc driver. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel > --- > Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c > index e0987c9..47f5ccc 100644 > --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c > +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c > @@ -72,6 +72,8 @@ STATIC VOID *mEventRegistration; > @param[in] ControllerHandle The EFI_HANDLE of the controller. > @param[in] Slot The 0 based slot index. > @param[in,out] SdMmcHcSlotCapability The SDHCI capability structure. > + @param[in,out] BaseClkFreq The base clock frequency value that > + optionally can be updated. > > @retval EFI_SUCCESS The override function completed successfully. > @retval EFI_NOT_FOUND The specified controller or slot does not exist. > @@ -84,7 +86,8 @@ EFIAPI > SynQuacerSdMmcCapability ( > IN EFI_HANDLE ControllerHandle, > IN UINT8 Slot, > - IN OUT VOID *SdMmcHcSlotCapability > + IN OUT VOID *SdMmcHcSlotCapability, > + IN OUT UINT32 *BaseClkFreq > ) > { > UINT64 Capability; > @@ -117,6 +120,7 @@ SynQuacerSdMmcCapability ( > @param[in] PhaseType The type of operation and whether the > hook is invoked right before (pre) or > right after (post) > + @param[in,out] PhaseData The pointer to a phase-specific data. > > @retval EFI_SUCCESS The override function completed successfully. > @retval EFI_NOT_FOUND The specified controller or slot does not exist. > @@ -129,7 +133,8 @@ EFIAPI > SynQuacerSdMmcNotifyPhase ( > IN EFI_HANDLE ControllerHandle, > IN UINT8 Slot, > - IN EDKII_SD_MMC_PHASE_TYPE PhaseType > + IN EDKII_SD_MMC_PHASE_TYPE PhaseType, > + IN OUT VOID *PhaseData > ) > { > if (ControllerHandle != mSdMmcControllerHandle) { > -- > 2.7.4 >