public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Gao, Liming" <liming.gao@intel.com>,
	"Zhu, Yonghong" <yonghong.zhu@intel.com>
Subject: Re: [PATCH] BaseTools/tools_def: use separate PP definition for DTC
Date: Tue, 27 Feb 2018 18:36:08 +0000	[thread overview]
Message-ID: <CAKv+Gu_F+x=8hkmW0cMh4ieZACu9LZZht-7EOSKbitRuoeGQKg@mail.gmail.com> (raw)
In-Reply-To: <20180227183327.lg6juoabvbc3jute@bivouac.eciton.net>

On 27 February 2018 at 18:33, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Tue, Feb 27, 2018 at 05:51:32PM +0000, Ard Biesheuvel wrote:
>> Clang's preprocessor behaves differently from GCC's, and produces
>> intermediate device tree source that still contains #pragma pack()
>> and other directives that the device tree compiler chokes on.
>>
>> For assembling device tree sources, it matters very little which
>> preprocessor is being used, so let's just use GNU CPP explicitly.
>
> Ah, right, same fundamental issue as
> 5b8766bb92debfa7b2f45a4a6d683b4227360d66.
>

Yes, and I fail to see why changing just those two files makes a
meaningful difference.

> However, this time triggered by autogen seemingly forcing inclusion of
> lots of central header files that are not even used, like
> MdePkg/Include/IndustryStandard/Bluetooth.h
> MdePkg/Include/IndustryStandard/Acpi10.h
> and so on.
>
> Is there any way to suppress these implicit includes from .dts
> processing?
>

There is 'Trim', which can filter #include'd content, but using that
also robs us of the ability to #include .dtsi files, which was kind of
the point of using the preprocessor in the first place.


  reply	other threads:[~2018-02-27 18:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-27 17:51 [PATCH] BaseTools/tools_def: use separate PP definition for DTC Ard Biesheuvel
2018-02-27 18:33 ` Leif Lindholm
2018-02-27 18:36   ` Ard Biesheuvel [this message]
2018-02-27 18:58     ` Leif Lindholm
2018-02-27 19:02       ` Ard Biesheuvel
2018-02-27 20:01         ` Leif Lindholm
2018-02-28  2:41           ` Gao, Liming
2018-02-28  8:13             ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu_F+x=8hkmW0cMh4ieZACu9LZZht-7EOSKbitRuoeGQKg@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox