From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::243; helo=mail-it0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CF4D722352286 for ; Tue, 27 Feb 2018 10:30:03 -0800 (PST) Received: by mail-it0-x243.google.com with SMTP id w63so351449ita.3 for ; Tue, 27 Feb 2018 10:36:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=uiZ9oLf90bxsFDhYKJIse0vwKwr1mJpg0tf3brYX0rk=; b=IQz3DVc4qrNWon1+9Z5VdYaSztzINNj1h0tu6O4eP2FUaEh/NsuhJXYuiPaBYoD7lr RtTZstB2BIpqTj+sbxaH+rTZFpIL1nRLfQYjgAUKgGrmm5y2HJby0DcVKlf4PUPlZIIZ Z7oCb2n7ynuwU2OstZOB2U9nOQiSPmV5d8Chg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=uiZ9oLf90bxsFDhYKJIse0vwKwr1mJpg0tf3brYX0rk=; b=deLWR7JZ40MdiM/OVc1sSIRAqvg14BBuZPBMUedhVbtvU8EOm1xvxU+40mzTY0xznS FQ5Q+omY0HBq6dkTuqpVupout/lX5yOkN9EbqdQ3og+ENjSTqtYECVu8PVQhN4bJk/xv isyzm5Yx5h+zUNHxgAemFHOHWNFYtphHMeku7dmEaVDHZLxpWwlOt2CpfgbEa2ZN38zq xUSfVFr5P98Uk2qceKOCwumeFH9PM0Bx7uDJ11kJCDtBlGbwPCQTcv1RZ9wLXA/pnq86 itwgv0ZZUnlYbw3qH83apvbJtVRwk0O/uXBMXTfVWMPMAB8sDs0EH5DLe7MWD3HzIHJI LYKg== X-Gm-Message-State: APf1xPArjW1WOShgDiF7awMLnyqf0cONm5xVs7Q+79/WDSchnEnR2Qmw nAc5TEvfslvOVWxDSGFVbDPCsGv8fKvCypLbJ2sbwA== X-Google-Smtp-Source: AG47ELvrOQhBNY9TmkKW5BzFQtKjW/mjT+AzVFd0Y5MBBct6kSdGRc/LpQlwnNPCJZqSuNb5KKqyAmF2d++g1iDlEuk= X-Received: by 10.36.60.216 with SMTP id m207mr9996538ita.68.1519756569392; Tue, 27 Feb 2018 10:36:09 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.138.209 with HTTP; Tue, 27 Feb 2018 10:36:08 -0800 (PST) In-Reply-To: <20180227183327.lg6juoabvbc3jute@bivouac.eciton.net> References: <20180227175132.1607-1-ard.biesheuvel@linaro.org> <20180227183327.lg6juoabvbc3jute@bivouac.eciton.net> From: Ard Biesheuvel Date: Tue, 27 Feb 2018 18:36:08 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , "Gao, Liming" , "Zhu, Yonghong" Subject: Re: [PATCH] BaseTools/tools_def: use separate PP definition for DTC X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2018 18:30:04 -0000 Content-Type: text/plain; charset="UTF-8" On 27 February 2018 at 18:33, Leif Lindholm wrote: > On Tue, Feb 27, 2018 at 05:51:32PM +0000, Ard Biesheuvel wrote: >> Clang's preprocessor behaves differently from GCC's, and produces >> intermediate device tree source that still contains #pragma pack() >> and other directives that the device tree compiler chokes on. >> >> For assembling device tree sources, it matters very little which >> preprocessor is being used, so let's just use GNU CPP explicitly. > > Ah, right, same fundamental issue as > 5b8766bb92debfa7b2f45a4a6d683b4227360d66. > Yes, and I fail to see why changing just those two files makes a meaningful difference. > However, this time triggered by autogen seemingly forcing inclusion of > lots of central header files that are not even used, like > MdePkg/Include/IndustryStandard/Bluetooth.h > MdePkg/Include/IndustryStandard/Acpi10.h > and so on. > > Is there any way to suppress these implicit includes from .dts > processing? > There is 'Trim', which can filter #include'd content, but using that also robs us of the ability to #include .dtsi files, which was kind of the point of using the preprocessor in the first place.