Re: [edk2-devel] [PATCH] OvmfPkg/X86QemuLoadImageLib: fix "unused variable" error in X64 DXE builds

["Ard Biesheuvel" <ard.biesheuvel@linaro.org>]

On Sat, 7 Mar 2020 at 02:00, Laszlo Ersek <lersek@redhat.com> wrote:
>
> On 03/07/20 01:01, Philippe Mathieu-Daudé wrote:
> > On 3/7/20 12:04 AM, Laszlo Ersek wrote:
> >> When the MDE_CPU_IA32 macro is not defined, there is no access to the
> >> "KernelImageHandle" local variable in QemuStartKernelImage(). This breaks
> >> the OvmfPkgIa32X64 and OvmfPkgX64 platform builds, at least with gcc-8.
> >>
> >> Move the local variable to the inner scope, where declaration and usage
> >> are inseparable.
> >>
> >> (Note that such inner-scope declarations are frowned upon in the wider
> >> edk2 codebase, but we use them liberally in ArmVirtPkg and OvmfPkg
> >> anyway,
> >> because they help us reason about variable lifetime and visibility.)
> >>
> >> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >> Cc: Jordan Justen <jordan.l.justen@intel.com>
> >> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> >> Fixes: 7c47d89003a6f8f7f6f0ce8ca7d3e87c630d14cc
> >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2572
> >> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> >
> > Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> > Tested-by: Philippe Mathieu-Daude <philmd@redhat.com>
>
> Thank you, Phil, this really helps -- I want to push the patch as
> quickly as possible, due to it averting a build break.
>
> So I've submitted <https://github.com/tianocore/edk2/pull/428> with your
> tags applied... but mergify is apparently not picking up the "push"
> label again... I have no idea what's going on.
>

I queued it here as well:
https://github.com/tianocore/edk2/pull/427