* [PATCH] Silicon/SynQuacer: remove bogus PL011 _HID from DSDT ACPI table
@ 2018-11-19 16:03 Ard Biesheuvel
2018-11-19 17:48 ` Leif Lindholm
2018-11-20 7:38 ` Mark Kettenis
0 siblings, 2 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2018-11-19 16:03 UTC (permalink / raw)
To: edk2-devel
PL011 is not a valid ACPI identifier so don't expose it as a _CID.
Since _CID (Comptable ID) is optional, let's just drop it.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl | 1 -
1 file changed, 1 deletion(-)
diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
index 3f73c191d4d6..7c7677f1fea0 100644
--- a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
+++ b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
@@ -135,7 +135,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "SNI", "SYNQUACR",
// UART PL011
Device (COM0) {
Name (_HID, "ARMH0011")
- Name (_CID, "PL011")
Name (_UID, Zero)
Name (_CRS, ResourceTemplate () {
Memory32Fixed (ReadWrite, FixedPcdGet32 (PcdSerialRegisterBase), 0x1000)
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Silicon/SynQuacer: remove bogus PL011 _HID from DSDT ACPI table
2018-11-19 16:03 [PATCH] Silicon/SynQuacer: remove bogus PL011 _HID from DSDT ACPI table Ard Biesheuvel
@ 2018-11-19 17:48 ` Leif Lindholm
2018-11-19 18:23 ` Ard Biesheuvel
2018-11-20 7:38 ` Mark Kettenis
1 sibling, 1 reply; 4+ messages in thread
From: Leif Lindholm @ 2018-11-19 17:48 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel
On Mon, Nov 19, 2018 at 08:03:38AM -0800, Ard Biesheuvel wrote:
> PL011 is not a valid ACPI identifier so don't expose it as a _CID.
> Since _CID (Comptable ID) is optional, let's just drop it.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
> index 3f73c191d4d6..7c7677f1fea0 100644
> --- a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
> +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
> @@ -135,7 +135,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "SNI", "SYNQUACR",
> // UART PL011
> Device (COM0) {
> Name (_HID, "ARMH0011")
> - Name (_CID, "PL011")
> Name (_UID, Zero)
> Name (_CRS, ResourceTemplate () {
> Memory32Fixed (ReadWrite, FixedPcdGet32 (PcdSerialRegisterBase), 0x1000)
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Silicon/SynQuacer: remove bogus PL011 _HID from DSDT ACPI table
2018-11-19 17:48 ` Leif Lindholm
@ 2018-11-19 18:23 ` Ard Biesheuvel
0 siblings, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2018-11-19 18:23 UTC (permalink / raw)
To: Leif Lindholm; +Cc: edk2-devel@lists.01.org
On Mon, 19 Nov 2018 at 09:48, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Mon, Nov 19, 2018 at 08:03:38AM -0800, Ard Biesheuvel wrote:
> > PL011 is not a valid ACPI identifier so don't expose it as a _CID.
> > Since _CID (Comptable ID) is optional, let's just drop it.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
Thanks. Pushed as 46d3a977b931156a7155a879cdd2b0c95bb1aae0
> > ---
> > Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
> > index 3f73c191d4d6..7c7677f1fea0 100644
> > --- a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
> > +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
> > @@ -135,7 +135,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "SNI", "SYNQUACR",
> > // UART PL011
> > Device (COM0) {
> > Name (_HID, "ARMH0011")
> > - Name (_CID, "PL011")
> > Name (_UID, Zero)
> > Name (_CRS, ResourceTemplate () {
> > Memory32Fixed (ReadWrite, FixedPcdGet32 (PcdSerialRegisterBase), 0x1000)
> > --
> > 2.17.1
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Silicon/SynQuacer: remove bogus PL011 _HID from DSDT ACPI table
2018-11-19 16:03 [PATCH] Silicon/SynQuacer: remove bogus PL011 _HID from DSDT ACPI table Ard Biesheuvel
2018-11-19 17:48 ` Leif Lindholm
@ 2018-11-20 7:38 ` Mark Kettenis
1 sibling, 0 replies; 4+ messages in thread
From: Mark Kettenis @ 2018-11-20 7:38 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel
> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Date: Mon, 19 Nov 2018 08:03:38 -0800
>
> PL011 is not a valid ACPI identifier so don't expose it as a _CID.
> Since _CID (Comptable ID) is optional, let's just drop it.
Heh, I Noticed that one when adding ACPI support for OpenBSD/arm64.
Reviewed-by: Mark Kettenis <kettenis@openbsd.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
> index 3f73c191d4d6..7c7677f1fea0 100644
> --- a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
> +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
> @@ -135,7 +135,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "SNI", "SYNQUACR",
> // UART PL011
> Device (COM0) {
> Name (_HID, "ARMH0011")
> - Name (_CID, "PL011")
> Name (_UID, Zero)
> Name (_CRS, ResourceTemplate () {
> Memory32Fixed (ReadWrite, FixedPcdGet32 (PcdSerialRegisterBase), 0x1000)
> --
> 2.17.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-20 8:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-19 16:03 [PATCH] Silicon/SynQuacer: remove bogus PL011 _HID from DSDT ACPI table Ard Biesheuvel
2018-11-19 17:48 ` Leif Lindholm
2018-11-19 18:23 ` Ard Biesheuvel
2018-11-20 7:38 ` Mark Kettenis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox