From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::243; helo=mail-io0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x243.google.com (mail-io0-x243.google.com [IPv6:2607:f8b0:4001:c06::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DE079202E5CC4 for ; Sat, 28 Oct 2017 06:44:30 -0700 (PDT) Received: by mail-io0-x243.google.com with SMTP id m16so18248623iod.1 for ; Sat, 28 Oct 2017 06:48:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=dbdQ3NQYeFOTgTR+OLKdNTdVZ3jfMokO7UzkGSe6Zvw=; b=VzTIQs8jCquB/fLNTe/kVjWon1C0nSma2pbAdMJUhWc4vpXEAteu/rLP91GENO+O6J IZOxION6hSEUltn5I9thu2MJoZKnrrEj0O8ZRy8qLBAAAYWYnehqS6ZkLjuEmINwvHup 04ZLTGDVOW/mYsS6atpM2QcUYb0HIt5WWtQ18= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=dbdQ3NQYeFOTgTR+OLKdNTdVZ3jfMokO7UzkGSe6Zvw=; b=krbKHCwhBUJTCaEMo4UjU/fptel0kpRh2eE0GRGZCqANbLG5zwwVQff1QPKyTWLfv+ cYzj4R/w9oGSaVyLhqmiNR1PAzfRzJ9xVLWfM24D0LGweKhV8oL3Dqf43R2bPdUoXzF7 G0vqxJqNyjz4jM5snfx1P8groMVLVK0Z8ndZW9xuzOe43ET05N4YgLuaINjE0kkTIfMI TXaz4ricfuHSqITosWj2hImBQPf0TgqLjaAKENtcDUW0G7mbYn0cStkcM/lcxL2ehN3d fCuYanRXOlkn9DImcQqxmM1DjXFdtwodvHoM0ke0BvAk7/PYdJseZSOI+WyZHK2xtBsh VPQw== X-Gm-Message-State: AMCzsaWVUrZwMnXUQjxRdPPHnY42FgP2tRUrC3bv3dNY2PV2rDfwLKYr Au8B7fA9/YjyvXoEchcl7p2L6zdM7VrzfgNJWboagkKF X-Google-Smtp-Source: ABhQp+Tu0cq+955jDQvKxR6+zEfq/qBnEMtQG9rphp9cgWFr+I5+abgzzkkUq7DlDO+86DH/6EkDugvQfLGUC5pN9d8= X-Received: by 10.36.210.198 with SMTP id z189mr4656460itf.65.1509198498455; Sat, 28 Oct 2017 06:48:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.131.167 with HTTP; Sat, 28 Oct 2017 06:48:18 -0700 (PDT) In-Reply-To: <20171026213327.6wunclsgnk63ax7v@bivouac.eciton.net> References: <20171025175947.22798-1-ard.biesheuvel@linaro.org> <20171025175947.22798-20-ard.biesheuvel@linaro.org> <20171026213327.6wunclsgnk63ax7v@bivouac.eciton.net> From: Ard Biesheuvel Date: Sat, 28 Oct 2017 14:48:18 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Daniel Thompson , Masami Hiramatsu Subject: Re: [PATCH edk2-platforms v2 19/23] Platform/SynQuacerEvalBoard: add signed capsule update support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Oct 2017 13:44:31 -0000 Content-Type: text/plain; charset="UTF-8" On 26 October 2017 at 22:33, Leif Lindholm wrote: > On Wed, Oct 25, 2017 at 06:59:43PM +0100, Ard Biesheuvel wrote: >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel >> --- >> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 20 +++++ >> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf | 92 +++++++++++++++++++- >> Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc | 80 +++++++++++++++++ >> Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf | 46 ++++++++++ >> Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptorPei.c | 68 +++++++++++++++ >> Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareUpdateConfig/SystemFirmwareUpdateConfig.ini | 25 ++++++ >> 6 files changed, 328 insertions(+), 3 deletions(-) >> >> diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc >> index cb6922a5940e..78c92cbca5a2 100644 >> --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc >> +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc >> @@ -120,6 +120,10 @@ [LibraryClasses.common] >> NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf >> NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf >> >> + BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf >> + OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf >> + IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf >> + >> [LibraryClasses.common.SEC] >> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >> BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf >> @@ -154,7 +158,15 @@ [LibraryClasses.common.DXE_CORE] >> [LibraryClasses.common.DXE_DRIVER] >> SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf >> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf >> + >> + # >> + # Firmware update >> + # >> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf >> + EdkiiSystemCapsuleLib|SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf >> + FmpAuthenticationLib|SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.inf >> + PlatformFlashAccessLib|Silicon/Socionext/SynQuacer/Library/SynQuacerPlatformFlashAccessLib/SynQuacerPlatformFlashAccessLib.inf >> + IniParsingLib|SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.inf >> >> # >> # PCI >> @@ -580,3 +592,11 @@ [Components.common] >> >> DtPlatformDtbLoaderLib|EmbeddedPkg/Library/DxeDtPlatformDtbLoaderLibDefault/DxeDtPlatformDtbLoaderLibDefault.inf >> } >> + >> + # >> + # Firmware update >> + # >> + Platform/Socionext/SynQuacerEvalBoard/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf >> + MdeModulePkg/Universal/EsrtDxe/EsrtDxe.inf >> + SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf >> + SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.inf >> diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf >> index 1e3258821a8c..337486d361fc 100644 >> --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf >> +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf >> @@ -27,12 +27,12 @@ >> >> [FD.BL33_AP_UEFI] >> BaseAddress = 0x08200000|gArmTokenSpaceGuid.PcdFdBaseAddress # The base address of the Firmware in NOR Flash. >> -Size = 0x001B0000|gArmTokenSpaceGuid.PcdFdSize # The size in bytes of the FLASH Device >> +Size = 0x001A0000|gArmTokenSpaceGuid.PcdFdSize # The size in bytes of the FLASH Device >> ErasePolarity = 1 >> >> # This one is tricky, it must be: BlockSize * NumBlocks = Size >> BlockSize = 0x00010000 >> -NumBlocks = 0x1B >> +NumBlocks = 0x1A >> >> ################################################################################ >> # >> @@ -50,7 +50,7 @@ [FD.BL33_AP_UEFI] >> # >> ################################################################################ >> >> -0x00000000|0x001B0000 >> +0x00000000|0x001A0000 > > There are a few "could you sort please" things I could comment about > below, but this is the only thing that really looks out of place to > me. Why is this being shrunk as part of this patch? If intentional and > related, this really needs a comment in the commit message. > No, not really. I will remove it.