From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Sami Mujawar <sami.mujawar@arm.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
Alexei Fedorov <Alexei.Fedorov@arm.com>,
Leif Lindholm <leif@nuviainc.com>,
Matteo Carlini <Matteo.Carlini@arm.com>,
Laura Moretta <Laura.Moretta@arm.com>, nd <nd@arm.com>
Subject: Re: [PATCH v2 1/2] DynamicTablesPkg: SRAT: Fix entry points
Date: Tue, 31 Mar 2020 09:49:13 +0200 [thread overview]
Message-ID: <CAKv+Gu_GrJ764VuC27SGePwLe0wvDyXLWuqHeS5TUMA0TzA=-g@mail.gmail.com> (raw)
In-Reply-To: <20200331072611.28896-1-sami.mujawar@arm.com>
On Tue, 31 Mar 2020 at 09:26, Sami Mujawar <sami.mujawar@arm.com> wrote:
>
> VS2017 reports 'warning C4028: formal parameter 2 different
> from declaration' for the library constructor and destructor
> interfaces for the SRAT Generator modules.
>
> Remove the CONST qualifier for the ImageHandle and the
> SystemTable pointer in the library constructor and destructor
> to make it compatible with the formal declaration.
>
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/702_srat_vs2017_compile_warning_v2
>
> Notes:
> V2:
> - Update commit message to reflect the update to the CONST [SAMI]
> qualifier at 2 places in the constructor & destructor.
>
> DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c
> index 5d56af66608d862e6eca81da812d719f110867d2..74cb7d92a5d8cddd3df8334f3ab55e6fa3e7267a 100644
> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c
> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c
> @@ -800,8 +800,8 @@ ACPI_TABLE_GENERATOR SratGenerator = {
> EFI_STATUS
> EFIAPI
> AcpiSratLibConstructor (
> - IN CONST EFI_HANDLE ImageHandle,
> - IN EFI_SYSTEM_TABLE * CONST SystemTable
> + IN EFI_HANDLE ImageHandle,
> + IN EFI_SYSTEM_TABLE * SystemTable
> )
> {
> EFI_STATUS Status;
> @@ -823,8 +823,8 @@ AcpiSratLibConstructor (
> EFI_STATUS
> EFIAPI
> AcpiSratLibDestructor (
> - IN CONST EFI_HANDLE ImageHandle,
> - IN EFI_SYSTEM_TABLE * CONST SystemTable
> + IN EFI_HANDLE ImageHandle,
> + IN EFI_SYSTEM_TABLE * SystemTable
> )
> {
> EFI_STATUS Status;
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>
prev parent reply other threads:[~2020-03-31 7:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 7:26 [PATCH v2 1/2] DynamicTablesPkg: SRAT: Fix entry points Sami Mujawar
2020-03-31 7:49 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu_GrJ764VuC27SGePwLe0wvDyXLWuqHeS5TUMA0TzA=-g@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox