From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65])
 by mx.groups.io with SMTP id smtpd.web11.4485.1585640965744364866
 for <devel@edk2.groups.io>;
 Tue, 31 Mar 2020 00:49:26 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=X0yGgwHv;
 spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: ard.biesheuvel@linaro.org)
Received: by mail-wr1-f65.google.com with SMTP id j17so24550711wru.13
        for <devel@edk2.groups.io>; Tue, 31 Mar 2020 00:49:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=HehIZmQSIZUrw816kQ0YyhUau08afZz03jjBZ6JuQMQ=;
        b=X0yGgwHvJEq9N5ggiaeHiQJuRxf+jEeLB31ADJEER2nFVc6x+GJJtDtLZYrGTahk8l
         i1SQicrByfbp1GZXr/SLm/6eMD684WHWAPlCszVaaTb0rUhAP68ilCDGS/fG7APm74or
         XxYfoh5O/ERW+SLQ/UfR0djMJlLDKIKaSCzTgdBGJNTa+l1UgiAanqoRMtAq5vWC1c3H
         3nEQTSHg7DfVRDo3GxW4uZLK8gNszZi2US1EQhdiqOovWbozLe45FHYhuFp5fY52fKHQ
         AeoCJUeNKzK0V6Yb079tnvhS4BLPn1FippDynGiapbVmZ0sq+TccAOoygKh3IbKUiwed
         O1sQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=HehIZmQSIZUrw816kQ0YyhUau08afZz03jjBZ6JuQMQ=;
        b=NPhSue+1+Jus/dV+XgNzuwafmBlhvgD4pXhzx9OubUM3L8E9C3mu66dw3ncwfUc4Wd
         KZo53nw0NbYOF5x3eS0T8PmJ0gxjfu29b/oeba8Rl6RB7fu5LC173RQYVawqExD0N27i
         x2/9E0JmO2HvVKsipGGrVciHpdQ/NCr7PjHzdrkoDVWSmT3Bn2SGCJrVJbjDHPM3ziy7
         1oNLdx9CKgmxuecDj+EQQg0RQUkteIBXlPufuH/Dqw7/imIEl87/N1qHIz01dZxpIdH7
         77D55nDSeBlm7gQK9NxT9pRdNMcLLqajJ1wEAN3eppxdrEI5erPxnJCkzWkc8h7EOZDL
         XQfA==
X-Gm-Message-State: ANhLgQ0zWEtuXjyjBJe5CZnsts67tVXl5ZszpaLHg0hftXE2s3+L5W2O
	DaTzCD4wqWkT0imjmaR5A77ukDaosw4jMwL+UF/Seg==
X-Google-Smtp-Source: ADFU+vvzXDKTPhNwSXVdpQIxzgzG5JzLmzKzxAuAcisOrjedLnraodC2ICSPvGhTbgHnTiwlkuDWievNL4fUZRw18Ik=
X-Received: by 2002:a5d:604a:: with SMTP id j10mr18605900wrt.126.1585640964278;
 Tue, 31 Mar 2020 00:49:24 -0700 (PDT)
MIME-Version: 1.0
References: <20200331072611.28896-1-sami.mujawar@arm.com>
In-Reply-To: <20200331072611.28896-1-sami.mujawar@arm.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Tue, 31 Mar 2020 09:49:13 +0200
Message-ID: <CAKv+Gu_GrJ764VuC27SGePwLe0wvDyXLWuqHeS5TUMA0TzA=-g@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] DynamicTablesPkg: SRAT: Fix entry points
To: Sami Mujawar <sami.mujawar@arm.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Alexei Fedorov <Alexei.Fedorov@arm.com>, 
	Leif Lindholm <leif@nuviainc.com>, Matteo Carlini <Matteo.Carlini@arm.com>, 
	Laura Moretta <Laura.Moretta@arm.com>, nd <nd@arm.com>
Content-Type: text/plain; charset="UTF-8"

On Tue, 31 Mar 2020 at 09:26, Sami Mujawar <sami.mujawar@arm.com> wrote:
>
> VS2017 reports 'warning C4028: formal parameter 2 different
> from declaration' for the library constructor and destructor
> interfaces for the SRAT Generator modules.
>
> Remove the CONST qualifier for the ImageHandle and the
> SystemTable pointer in the library constructor and destructor
> to make it compatible with the formal declaration.
>
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/702_srat_vs2017_compile_warning_v2
>
> Notes:
>     V2:
>     - Update commit message to reflect the update to the CONST      [SAMI]
>       qualifier at 2 places in the constructor & destructor.
>
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c
> index 5d56af66608d862e6eca81da812d719f110867d2..74cb7d92a5d8cddd3df8334f3ab55e6fa3e7267a 100644
> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c
> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c
> @@ -800,8 +800,8 @@ ACPI_TABLE_GENERATOR SratGenerator = {
>  EFI_STATUS
>  EFIAPI
>  AcpiSratLibConstructor (
> -  IN CONST EFI_HANDLE                ImageHandle,
> -  IN       EFI_SYSTEM_TABLE  * CONST SystemTable
> +  IN  EFI_HANDLE           ImageHandle,
> +  IN  EFI_SYSTEM_TABLE  *  SystemTable
>    )
>  {
>    EFI_STATUS  Status;
> @@ -823,8 +823,8 @@ AcpiSratLibConstructor (
>  EFI_STATUS
>  EFIAPI
>  AcpiSratLibDestructor (
> -  IN CONST EFI_HANDLE                ImageHandle,
> -  IN       EFI_SYSTEM_TABLE  * CONST SystemTable
> +  IN  EFI_HANDLE           ImageHandle,
> +  IN  EFI_SYSTEM_TABLE  *  SystemTable
>    )
>  {
>    EFI_STATUS  Status;
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>