From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::244; helo=mail-io0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x244.google.com (mail-io0-x244.google.com [IPv6:2607:f8b0:4001:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3AD7021E0BA02 for ; Thu, 1 Feb 2018 03:05:44 -0800 (PST) Received: by mail-io0-x244.google.com with SMTP id t22so18763100ioa.7 for ; Thu, 01 Feb 2018 03:11:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=d+VdE5Q1G3HDAeSnrfBDjuk4A4bnRoaDO+4T6PhVr+Y=; b=WuRUuVEN55WnOsJLKkCWOtPTPFcAMbYygo7J4UNR5+LOUrwMjBHV0xpDX/zAq405gd qoAjznsbuM657Qcc4G73fz31XFsqMrptSO4oRGgxh+4i9Gzv9xih1ayxoQz2qYyl6xtN LoamuWZdENHsGxwwUYUxzr9LB2/RR8vQmLEsY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=d+VdE5Q1G3HDAeSnrfBDjuk4A4bnRoaDO+4T6PhVr+Y=; b=tkt55E7kxW6bpV1SlFKONqAOiFczzRvlu+It9xSbBxZqMJVMo2u6vTsjcvcI9jPJNM fAOBwhnhnLGAXzrtS6VNBSDSAQvX8Ls39fkNYONBDSSUScQTfEE/rRVJVBpzGfeeQHWe ztSFFE3kTUv1PMqf1kSldaeCoT9WkWbzxdKz6/roMHiVNaCdXTkFhBzRbivQZpK8CZXJ oaTUREJTftAzhvXC9CWadAlcXWJqemUuNHUVZ6X4DnsPb9weQdkR6SNephQNQ5rgYMj+ guiXwF9625kKUjV7xHWTVf8x/oAMOK11GMjJJpMLp6tkFvcR5hcsDAJ1p9SrnEpxnMKE vdfg== X-Gm-Message-State: AKwxytdhScIXezok35+u/AXo0pOCVp19VfiQIQT7o0p9ggTj/FmnhzL6 GCMvhzMY+7A3ssF/ZmYxADkg7IridBkg0phx6TYNFA== X-Google-Smtp-Source: AH8x224JO1Y3k3HAtuRKY+2Kmh8PqdpqVoIEyWROLs5Ao2iqaGx2q7NAK8Dy6DzfVDwZ3ZHY5kHuKZ60UCj81lFOANo= X-Received: by 10.107.20.194 with SMTP id 185mr36528541iou.127.1517483481428; Thu, 01 Feb 2018 03:11:21 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.112.13 with HTTP; Thu, 1 Feb 2018 03:11:20 -0800 (PST) In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1BA539@SHSMSX104.ccr.corp.intel.com> References: <20180131214909.1103-1-ard.biesheuvel@linaro.org> <4A89E2EF3DFEDB4C8BFDE51014F606A14E1BA539@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Thu, 1 Feb 2018 11:11:20 +0000 Message-ID: To: "Gao, Liming" Cc: "edk2-devel@lists.01.org" , "Zhu, Yonghong" , "lersek@redhat.com" Subject: Re: [PATCH] BaseTools/build_rule: pass contents of DTC_FLAGS device tree compiler X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2018 11:05:45 -0000 Content-Type: text/plain; charset="UTF-8" On 1 February 2018 at 01:32, Gao, Liming wrote: > Ard: > Do you consider to add DTC_FLAGS in tools_def.template file? Its value can be empty. So, user bases on tools_def.txt to know which option can be set. > You are right, I forgot about the second part >>-----Original Message----- >>From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >>Sent: Thursday, February 01, 2018 5:49 AM >>To: edk2-devel@lists.01.org >>Cc: Gao, Liming ; Zhu, Yonghong >>; lersek@redhat.com; Ard Biesheuvel >> >>Subject: [PATCH] BaseTools/build_rule: pass contents of DTC_FLAGS device >>tree compiler >> >>To allow device tree compilation to be customized at the platform or >>module level, pass the contents of the DTC_FLAGS variable on the >>dtc command line. >> >>Contributed-under: TianoCore Contribution Agreement 1.1 >>Signed-off-by: Ard Biesheuvel >>--- >> BaseTools/Conf/build_rule.template | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >>diff --git a/BaseTools/Conf/build_rule.template >>b/BaseTools/Conf/build_rule.template >>index 3e6aa8ff0f34..a5e471eb3c10 100755 >>--- a/BaseTools/Conf/build_rule.template >>+++ b/BaseTools/Conf/build_rule.template >>@@ -250,7 +250,7 @@ >> >> >> "$(PP)" $(DTCPP_FLAGS) $(INC) ${src} > ${d_path}(+)${s_base}.i >>- "$(DTC)" -I dts -O dtb -o ${dst} ${d_path}(+)${s_base}.i >>+ "$(DTC)" $(DTC_FLAGS) -I dts -O dtb -o ${dst} ${d_path}(+)${s_base}.i >> >> [Visual-Form-Representation-File] >> >>-- >>2.11.0 >