public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Guo Heyi <heyi.guo@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	Laszlo Ersek <lersek@redhat.com>,
	Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers
Date: Tue, 27 Feb 2018 09:23:04 +0000	[thread overview]
Message-ID: <CAKv+Gu_HKE=UcX7P_OJ5o0mmZwLxmJRoj63xv5CAGot9=V4hHA@mail.gmail.com> (raw)
In-Reply-To: <20180227015036.GC2261@SZX1000114654>

On 27 February 2018 at 01:50, Guo Heyi <heyi.guo@linaro.org> wrote:
> Hi Ard,
>
> Sorry for the late of seeing this patch. I have one question: why don't we
> implement a runtime serial port lib, which will switch UART base address in
> virtual address map change? I think this will be useful when we want to debug
> runtime driver in OS stage. And if we have a runtime version of SerialPortLib,
> then we don't need a runtime version of DebugLib which just disable touching
> serial port.
>

Well, only if the serial port is not exposed to the OS as well. The
Linux PL011 driver is especially easy to confuse, and having both the
firmware and the OS control it at the same time is likely to cause
problems.

However, I do agree that having the ability to assign a UART to DEBUG
at runtime is useful, and so I do intend to create a runtime version
of the PL011 library, in which case DxeRuntimeDebugLibSerialPort can
be replaced with BaseDebugLibSerialPort for DXE_RUNTIME_DRIVER
modules.


  reply	other threads:[~2018-02-27  9:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-24 14:25 [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers Ard Biesheuvel
2018-02-24 14:25 ` [PATCH edk2-platforms 2/2] Silicon/SynQuacerI2cDxe: remove special runtime treatment of DEBUG()s Ard Biesheuvel
2018-02-26 14:50 ` [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers Laszlo Ersek
2018-02-27  1:50 ` Guo Heyi
2018-02-27  9:23   ` Ard Biesheuvel [this message]
2018-02-27 10:43     ` Laszlo Ersek
2018-02-27 11:30       ` Guo Heyi
2018-02-27 15:59         ` Laszlo Ersek
2018-02-27 14:21       ` Ard Biesheuvel
2018-02-27 16:09         ` Laszlo Ersek
2018-02-27 16:10           ` Ard Biesheuvel
2018-02-27 17:33             ` Ard Biesheuvel
2018-02-27 17:47               ` Laszlo Ersek
2018-02-27 17:55                 ` Ard Biesheuvel
2018-02-27 10:39 ` Leif Lindholm
2018-02-27 10:45   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu_HKE=UcX7P_OJ5o0mmZwLxmJRoj63xv5CAGot9=V4hHA@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox