From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::22b; helo=mail-io0-x22b.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x22b.google.com (mail-io0-x22b.google.com [IPv6:2607:f8b0:4001:c06::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BBE8B2034EE0C for ; Sun, 5 Nov 2017 08:17:48 -0800 (PST) Received: by mail-io0-x22b.google.com with SMTP id i38so13312927iod.2 for ; Sun, 05 Nov 2017 08:21:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+3zWgm/FnGGkrge9NEn/DHbmPM/hiuuH74YZOHjsTSo=; b=degqAWlVvXipECdYH0OJ653pGylyDX4UAFa9uMduwF+ZCrcF/6NbfhCJK+9odKYKbO DuN4lRFCPk8XFIPKpuuizUrFs/wf1v3PIFliMJC1Ky+THsz14zfD6puPSTOYJSR80CHX SRobVyyXeX/0hOjnrOJpbtnMzjUNXF2tgHP3I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+3zWgm/FnGGkrge9NEn/DHbmPM/hiuuH74YZOHjsTSo=; b=F0E1EfIXp1lDwY5bxFbiskNbWs6z2f8J2Y2fdlld0lQ0qInu+XdsRRns9bHm36l/uL YNRrld0+EJYeQSW6c/W6SFqbf7lTJ1rjZUTBQlIOFcggCzgURQlJWFVbqFucYzBo2XSh XDav7sNkWcmjI8Z5fWIA/W/sDM8KkEv9Wq/DWulsPzGTzFdov2OiAR7RsdgHwWg0O9oe rJJwOJyQpnUPBS2DWh30ZBQTmue9tnKgeMY7hXvCDRyf/hbw4QKwkxtTUZmYBRXaqxle qo51aN27UhXW3noY6nDw5xzfTzI58bZkmhhOHcy5bOfAqC0KvthPi8trTEXKYFZV8gtY 8mjQ== X-Gm-Message-State: AJaThX62hw1LXvefE3sYrqxuPKYKcaCnGQ49tfrvuZmPI0O8FVUZHWqS RE9xiMwwTRCPbEkuwoG2bsHKzjKkUA24LNpFntQ8rA== X-Google-Smtp-Source: ABhQp+SbQ7hrTzIofUqPNA5nzl2dVxW7IN34lsIus+zzfdYD5dCxIYN3X995iFuW8SWZgdB4tOYQVN0CBlwa2kEs8RY= X-Received: by 10.107.174.206 with SMTP id n75mr4494092ioo.43.1509898905436; Sun, 05 Nov 2017 08:21:45 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.131.167 with HTTP; Sun, 5 Nov 2017 08:21:44 -0800 (PST) In-Reply-To: References: <20171101131145.16459-1-ard.biesheuvel@linaro.org> <20171101131145.16459-2-ard.biesheuvel@linaro.org> <20171105053852.ppzfshzqrtwsts4a@bivouac.eciton.net> From: Ard Biesheuvel Date: Sun, 5 Nov 2017 16:21:44 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Daniel Thompson Subject: Re: [PATCH 1/2] EmbeddedPkg: introduce GPIO PPI X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Nov 2017 16:17:48 -0000 Content-Type: text/plain; charset="UTF-8" On 5 November 2017 at 10:05, Ard Biesheuvel wrote: > On 5 November 2017 at 05:38, Leif Lindholm wrote: >> On Wed, Nov 01, 2017 at 01:11:44PM +0000, Ard Biesheuvel wrote: >>> Introduce a PPI counterpart of the existing 'embedded GPIO' protocol, >>> so we can manipulate GPIOs from PEI modules. This allows things like >>> setting the boot mode based on a DIP switch setting. >>> >>> Note that the naming is slightly awkward, as there is nothing 'embedded' >>> about a GPIO, but given that the DXE protocol already resides here and >>> has the 'embedded' prefix, it makes sense to retain uniformity. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Ard Biesheuvel >> >> I have no objection to this, so: >> Reviewed-by: Leif Lindholm >> >> ...but I do have a question: >> Do we strictly need to duplicate this include file? It feels like a >> bit of a maintenance hazard/burden. >> > > Yeah, I wondered about that as well, but given that it's only two enum > typedefs and a couple of macros that we can really share, I didn't > bother. Pushed as b1832e16ddce EmbeddedPkg: introduce GPIO PPI 3909c4a19344 ArmPlatformPkg/PlatformPeim: allow PlatformPeiLib to set the boot mode Thanks.