From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d35; helo=mail-io1-xd35.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B18B521962301 for ; Tue, 11 Dec 2018 05:49:05 -0800 (PST) Received: by mail-io1-xd35.google.com with SMTP id r200so11779077iod.11 for ; Tue, 11 Dec 2018 05:49:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Iv3m93v4uD6UGlZ0frI4/M31nLWDTfx8VK8IAPmhdz0=; b=Fc0YVV6OsPCts3C+DbaGTYne6xjvhLUMnmOxUdoyG5v7dUnGZ3KwwOTpC+su6vWI5x d0z7iH8KPbGu4kS16x2eJfrvCBj5+bQlqdZIo2DQUzqx0WEoWsPeRYal2V2WQ5W9Swoj uJIl5j3GNV7FV9tCKM8HtXHgbBzFNjUZGtKk4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Iv3m93v4uD6UGlZ0frI4/M31nLWDTfx8VK8IAPmhdz0=; b=O7xm+RPEavU9j6JiKkk+U/NQ/HAKXH1gdXuQCKfgxj1bGo/2vah18GYktPKFgEjzn8 +D+8hne3wmkS/QUUHtkkRAkAKVtaU2LBdotgkPxJyHMi6GBrEQfOkVMgio6enX4kVHAL RWPdoYcuMXt8buaEvqPubvAlUaCIWUCRXeVtmkBUoQL1QMuW9U5uemlwPdT1UWVP/eYr m5ivuO5e/0BD088wnBzmhpvIeoKTPPxFgbwAdTf5kva/OhROPbp7wjfs31D3Xg6fDePX zQc1xLViOQytew7pk0UhwKNaCpmLJso4B9uJynz1ACGld92ryoTMdfn1c3D2eR0iB2kA jS/Q== X-Gm-Message-State: AA+aEWY5IO9No87eH9y0kvaf964a3Rxb8Ppqey/4GCaqHf+0cXj4/pgb jpjYIjHL+3QXWesF7amCPfUk4WOWbiGnUfq7WrxJhyalZlg= X-Google-Smtp-Source: AFSGD/VRNemRiS2Il7KuVaF8wCaa5esxIeZUtetIhAS1wAxhKDjQPv3aFaCYpBqfDYv3LC63JXNYZfDZS7AXstB724o= X-Received: by 2002:a5d:8415:: with SMTP id i21mr13169969ion.173.1544536144962; Tue, 11 Dec 2018 05:49:04 -0800 (PST) MIME-Version: 1.0 References: <20181205201049.10590-1-ard.biesheuvel@linaro.org> <20181210221441.2xwqqzgafxpvqguu@bivouac.eciton.net> <20181210233355.4v5guv5nwmbun5w3@bivouac.eciton.net> <4A89E2EF3DFEDB4C8BFDE51014F606A14E389AA3@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E38A1F4@SHSMSX104.ccr.corp.intel.com> <08650203BA1BD64D8AD9B6D5D74A85D16002B02A@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <08650203BA1BD64D8AD9B6D5D74A85D16002B02A@SHSMSX101.ccr.corp.intel.com> From: Ard Biesheuvel Date: Tue, 11 Dec 2018 14:48:53 +0100 Message-ID: To: "Feng, Bob C" Cc: "Gao, Liming" , Andrew Fish , Leif Lindholm , "edk2-devel@lists.01.org" Subject: Re: [PATCH edk2-platforms] Platform/AMD/OverdriveBoard: fix byte order of default MAC addresses X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Dec 2018 13:49:06 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 11 Dec 2018 at 14:38, Feng, Bob C wrote: > > Hi Ard, > > Would you please try this format? While I'll check this issue anyway. > > [PcdsDynamic] > gAmdStyxTokenSpaceGuid.PcdEthMacA|{CODE({0})}|UINT8[6]|0x000d0001 > gAmdStyxTokenSpaceGuid.PcdEthMacB|{CODE({0})}|UINT8[6]|0x000d0002 > > and this in my .dsc file > > [PcdsDynamicDefault.common] > gAmdStyxTokenSpaceGuid.PcdEthMacA|{CODE({0x2,0xA1,0xA2,0xA3,0xA4,0xA5}= )} > gAmdStyxTokenSpaceGuid.PcdEthMacB|{CODE({0x2,0xB1,0xB2,0xB3,0xB4,0xB5}= )} > Processing meta-data ....... build.py... : error F015: From DEC Default Value {CODE({0})}:28:9: error: expected expression before =E2=80=98{=E2=80=99 token >>From DEC Default Value {CODE({0})}:87:9: error: expected expression before =E2=80=98{=E2=80=99 token > > Thanks, > Bob > -----Original Message----- > From: Gao, Liming > Sent: Tuesday, December 11, 2018 9:15 PM > To: Ard Biesheuvel ; Feng, Bob C > Cc: Andrew Fish ; Leif Lindholm ; edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH edk2-platforms] Platform/AMD/OverdriveBoard: f= ix byte order of default MAC addresses > > > BZ https://bugzilla.tianocore.org/show_bug.cgi?id=3D1390 is submit for it= . Bob will fix it. > > > > -----Original Message----- > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > Sent: Tuesday, December 11, 2018 3:54 PM > > To: Gao, Liming > > Cc: Andrew Fish ; Leif Lindholm ; edk2-devel@lists.01.org > > Subject: Re: [edk2] [PATCH edk2-platforms] Platform/AMD/OverdriveBoard:= fix byte order of default MAC addresses > > > > On Tue, 11 Dec 2018 at 01:53, Gao, Liming wrote: > > > > > > If PCD is related to one structure in DEC/DSC, it can be refer as str= ucture pointer in C source code. Here is wiki for its usage: > > https://github.com/lgao4/edk2/wiki/StrucutrePcd-Usage > > > > > > > OK so I now have this in my .dec file > > > > [PcdsDynamic] > > gAmdStyxTokenSpaceGuid.PcdEthMacA|{0}|UINT8[6]|0x000d0001 > > gAmdStyxTokenSpaceGuid.PcdEthMacB|{0}|UINT8[6]|0x000d0002 > > > > and this in my .dsc file > > > > [PcdsDynamicDefault.common] > > gAmdStyxTokenSpaceGuid.PcdEthMacA|{0x2,0xA1,0xA2,0xA3,0xA4,0xA5} > > gAmdStyxTokenSpaceGuid.PcdEthMacB|{0x2,0xB1,0xB2,0xB3,0xB4,0xB5} > > > > and the build errors out immediately with: > > > > Processing meta-data ....... > > > > build.py... > > : error F015: /home/ard/build/edk2-workspace/Build/Overdrive/RELEASE_G= CC5/PcdValueInit/PcdValueInit.c:15:20: > > error: =E2=80=98gAmdStyxTokenSpaceGuid_PcdEthMacB_DEFAULT_STANDARD_Valu= e=E2=80=99 > > undeclared (first use in this function) > > /home/ard/build/edk2-workspace/Build/Overdrive/RELEASE_GCC5/PcdValueIni= t/PcdValueInit.c:41:16: > > error: =E2=80=98gAmdStyxTokenSpaceGuid_PcdEthMacB_DEFAULT_STANDARD_Valu= e=E2=80=99 > > undeclared (first use in this function) > > /home/ard/build/edk2-workspace/Build/Overdrive/RELEASE_GCC5/PcdValueIni= t/PcdValueInit.c:74:20: > > error: =E2=80=98gAmdStyxTokenSpaceGuid_PcdEthMacA_DEFAULT_STANDARD_Valu= e=E2=80=99 > > undeclared (first use in this function) > > /home/ard/build/edk2-workspace/Build/Overdrive/RELEASE_GCC5/PcdValueIni= t/PcdValueInit.c:100:16: > > error: =E2=80=98gAmdStyxTokenSpaceGuid_PcdEthMacA_DEFAULT_STANDARD_Valu= e=E2=80=99 > > undeclared (first use in this function)