Re: [platforms PATCH 3/4] Marvell/Armada7k8k: Introduce capsule FW update implementation

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 1 June 2018 at 18:02, Marcin Wojtas <mw@semihalf.com> wrote:
> Hi Ard,
>
> 2018-06-01 17:32 GMT+02:00 Ard Biesheuvel <ard.biesheuvel@linaro.org>:
>>  On 1 June 2018 at 16:32, Marcin Wojtas <mw@semihalf.com> wrote:
>>> From: David Sniatkiwicz <davidsn@marvell.com>
>>>
>>> This patch adds necessary code that allows to update
>>> firmware on Armada7k8k platforms, using generic gRT->UpdateCapsule,
>>> i.e.
>>>   * PlatformFlashAccessLib implementation to write data to SPI flash
>>>   * SystemFirmwareDescriptor for FMP protocol
>>>   * SystemFirmwareUpdateConfig to specify binary description
>>>     within SystemFirmwareFile
>>>
>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>> Signed-off-by: David Sniatkiwicz <davidsn@marvell.com>
>>> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
>>
>> Please take the [very recent] changes made in
>> 550de36633fec97d4f7467c02a33b3217f440ae9 into account here.
>> Unfortunately, there is no loop in your code from which you can report
>> progress, but you should at least implement the new entry point.
>>
>
> Actually there is a loop and current % of progress printed when
> updating data in the SPI.
> It is implemented in the SPI flash protocol callback.
>
> https://github.com/tianocore/edk2-platforms/blob/master/Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.c#L382
>
> What would you recommend me to do in such case?
>

You could find a way to pass the callback argument into your SPI flash
protocol method, perhaps by adding a new member to it?