From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 36706207DF2BF for ; Fri, 1 Jun 2018 09:08:58 -0700 (PDT) Received: by mail-it0-x244.google.com with SMTP id 76-v6so2429463itx.4 for ; Fri, 01 Jun 2018 09:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=YkS9BoNOU1f5WzZIDtj5CQvFXh6+f8sSfYs5g5NU4BQ=; b=krQ55KyF5xm/moCa6kHJL4IxGppqI/bOrPtEBS0FJINYGcc3Unp8jv67LBpFcMYjxs 6+MJX0RZJpWWdRgY03VT6dgIxebchk+UVFFHsPE5toXsVObx7NWJP4mcNNcMNXjMzl5V ekBVPBc9hZt86bree4yFWXCxc5A41EMcYWqSE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=YkS9BoNOU1f5WzZIDtj5CQvFXh6+f8sSfYs5g5NU4BQ=; b=Wy3tYNztCQhUeuotN/em104Y8HuZEPu2SVDQVyhNZxXbSFAfH2eBG6NpmMhkZXvofC IJw8JQQdSKuhnPpgGDNp90Kz2WGKu/0cbyFOHX0x4ibZLy61iZtwDqUl0pYKzRUbIJkW KSQMijqo9da2xtwDxdpGxl2vUgjemblJF92V3HyfZ88+NnPPM08p1k/2cJTfZas6K+zr 6PAX0AoYXqI9gMv7H6roYTS0h3ud93YZrC1VBycaWFuD0NUlbBCwl2mLZ6B0zn3Lazmi 8EJ/V0rnFHZWzA82lv999lLSQNsfh2NrxZDFR8awiVRw4/DwfKw8gSaqk9m5iGh0ZWlj xViw== X-Gm-Message-State: APt69E2slfR2Q/Pa/WhTPNhN1HsGKUD3QrkWYcWpjORSvOGenq8H3nr3 m7AdnGNegGy51TkIlSDWTwtKyCMvYh7Kg6I94zB3MA== X-Google-Smtp-Source: ADUXVKJRKoZ9VmHCx0/2Mgf5q5p4HZ4QcNM095rcSAnX7CZdchF9FWH9L53d/1v+gR3BvwDPFUHK1hXl0SCT41WrseE= X-Received: by 2002:a24:f04e:: with SMTP id p14-v6mr4957282iti.106.1527869337531; Fri, 01 Jun 2018 09:08:57 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bb86:0:0:0:0:0 with HTTP; Fri, 1 Jun 2018 09:08:56 -0700 (PDT) In-Reply-To: References: <1527863526-5494-1-git-send-email-mw@semihalf.com> <1527863526-5494-4-git-send-email-mw@semihalf.com> From: Ard Biesheuvel Date: Fri, 1 Jun 2018 18:08:56 +0200 Message-ID: To: Marcin Wojtas Cc: "edk2-devel@lists.01.org" , Leif Lindholm , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Hua Jing , Grzegorz Jaszczyk , David Sniatkiwicz Subject: Re: [platforms PATCH 3/4] Marvell/Armada7k8k: Introduce capsule FW update implementation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2018 16:08:58 -0000 Content-Type: text/plain; charset="UTF-8" On 1 June 2018 at 18:02, Marcin Wojtas wrote: > Hi Ard, > > 2018-06-01 17:32 GMT+02:00 Ard Biesheuvel : >> On 1 June 2018 at 16:32, Marcin Wojtas wrote: >>> From: David Sniatkiwicz >>> >>> This patch adds necessary code that allows to update >>> firmware on Armada7k8k platforms, using generic gRT->UpdateCapsule, >>> i.e. >>> * PlatformFlashAccessLib implementation to write data to SPI flash >>> * SystemFirmwareDescriptor for FMP protocol >>> * SystemFirmwareUpdateConfig to specify binary description >>> within SystemFirmwareFile >>> >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: David Sniatkiwicz >>> Signed-off-by: Marcin Wojtas >> >> Please take the [very recent] changes made in >> 550de36633fec97d4f7467c02a33b3217f440ae9 into account here. >> Unfortunately, there is no loop in your code from which you can report >> progress, but you should at least implement the new entry point. >> > > Actually there is a loop and current % of progress printed when > updating data in the SPI. > It is implemented in the SPI flash protocol callback. > > https://github.com/tianocore/edk2-platforms/blob/master/Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.c#L382 > > What would you recommend me to do in such case? > You could find a way to pass the callback argument into your SPI flash protocol method, perhaps by adding a new member to it?