From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x234.google.com (mail-io0-x234.google.com [IPv6:2607:f8b0:4001:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3C5911A1DFC for ; Fri, 5 Aug 2016 07:33:48 -0700 (PDT) Received: by mail-io0-x234.google.com with SMTP id b62so301360433iod.3 for ; Fri, 05 Aug 2016 07:33:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=sIusV+sRvMdneeAd2vRAaxpwN1mhl7RZe9riNn4Cccc=; b=K5J+o2xbf4EGSVmMZsNOIYSV1VaHw4raQKUUt2If653U07AQa+zQ8JA0qSS0OMUYPh w2onMyXQquciTBWqbdLfvTGtOyzCF+mWCtNfGI6aJFjnLhDFSmyiOQYphy1LSqY+yL7z i74Aa8B2LHm2/5kILoLjU7661z5FD5rKtC1Gw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=sIusV+sRvMdneeAd2vRAaxpwN1mhl7RZe9riNn4Cccc=; b=anWbYn/IfQ5gbF4jCAnQclbh+QzT+ZzaHXS11IkO0oMvDy3dkE1ib7yjLFK+H3B4/C 9JJqB1yfPjBme2yqJaWkCv5rSLyquDU5Enq/UT5FCmUhhA8cQHnGRq14nmsywW0VMPgA lhFo3u61XehSClIXBg0x94qfTQCNAVmxtcq5369eVhEwV0KgIOfLEJFkXhpTwQOnKJmT K/dxLw3nwRovW9S/n7GVRK8RTUTDJBlvHJ5YkwWFYnmZQulsU1UAJP9f5tsm3lSKZfGo Ynbf9wM/61FPpGy01Su+NxBkcF7iiU6/uOG9W8erl1TLmM7BRYPJQC6ZoBCggAHy3Swl 1ohg== X-Gm-Message-State: AEkoouvLmfNExqg2pBCRdfiiUHPT7dA4juvN4v3xdKYvmixV1hlQOgA8cabFxhd0mPm78eX4DSxbiYYezruvFgNR X-Received: by 10.107.41.67 with SMTP id p64mr77295218iop.130.1470407627613; Fri, 05 Aug 2016 07:33:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Fri, 5 Aug 2016 07:33:47 -0700 (PDT) In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A1155E5BE2@shsmsx102.ccr.corp.intel.com> References: <1470321767-26921-1-git-send-email-ard.biesheuvel@linaro.org> <1470321767-26921-4-git-send-email-ard.biesheuvel@linaro.org> <4A89E2EF3DFEDB4C8BFDE51014F606A1155E5BE2@shsmsx102.ccr.corp.intel.com> From: Ard Biesheuvel Date: Fri, 5 Aug 2016 16:33:47 +0200 Message-ID: To: "Gao, Liming" Cc: "Zhu, Yonghong" , "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" , "eugene@hp.com" Subject: Re: [PATCH 3/3] BaseTools GCC/ARM: add -fno-builtin to CC flags X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Aug 2016 14:33:48 -0000 Content-Type: text/plain; charset=UTF-8 On 5 August 2016 at 16:26, Gao, Liming wrote: > Reviewed-by: Liming Gao > Thanks all Pushed as 59ceaa0a871d ArmPkg/ArmSoftFloatLib: disable LTO build for GCC f8c51389c6db ArmPkg/CompilerIntrinsicsLib: make the default memset() weak 0667e985270b BaseTools GCC/ARM: add -fno-builtin to CC flags > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: Thursday, August 4, 2016 10:43 PM > To: Zhu, Yonghong ; Gao, Liming ; edk2-devel@lists.01.org > Cc: leif.lindholm@linaro.org; eugene@hp.com; Ard Biesheuvel > Subject: [PATCH 3/3] BaseTools GCC/ARM: add -fno-builtin to CC flags > > Avoid build errors when including OpensslLib, which may throw > undefined reference errors for builtin functions if -fno-builtin > is not specified (and it is already set for IA32, X64 and AARCH64) > So set it for ARM as well. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > BaseTools/Conf/tools_def.template | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template > index 88af82a683d9..4f1dd4be378e 100644 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -4334,7 +4334,7 @@ DEFINE GCC_ALL_CC_FLAGS = -g -Os -fshort-wchar -fno-strict-aliasing - > DEFINE GCC_IA32_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -m32 -malign-double -freorder-blocks -freorder-blocks-and-partition -O2 -mno-stack-arg-probe > DEFINE GCC_X64_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -mno-red-zone -Wno-address -mno-stack-arg-probe > DEFINE GCC_IPF_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -minline-int-divide-min-latency > -DEFINE GCC_ARM_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -mlittle-endian -mabi=aapcs -fno-short-enums -funsigned-char -ffunction-sections -fdata-sections -fomit-frame-pointer -Wno-address -mthumb -mfloat-abi=soft > +DEFINE GCC_ARM_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -mlittle-endian -mabi=aapcs -fno-short-enums -funsigned-char -ffunction-sections -fdata-sections -fomit-frame-pointer -fno-builtin -Wno-address -mthumb -mfloat-abi=soft > DEFINE GCC_AARCH64_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -mlittle-endian -fno-short-enums -fverbose-asm -funsigned-char -ffunction-sections -fdata-sections -fomit-frame-pointer -fno-builtin -Wno-address -fno-asynchronous-unwind-tables > DEFINE GCC_AARCH64_CC_XIPFLAGS = -mstrict-align > DEFINE GCC_DLINK_FLAGS_COMMON = -nostdlib --pie > -- > 2.7.4 >