From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 09EC221DFA7B1 for ; Fri, 24 Mar 2017 15:43:34 -0700 (PDT) Received: by mail-it0-x22c.google.com with SMTP id w124so23143730itb.1 for ; Fri, 24 Mar 2017 15:43:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=YHbEfvsVVxc+gYgH/mCx2oiOfwYR2cp4fd3+upr+ZWE=; b=InaxNqyoPxHOQmwh0dD77bzdkExdj+KpVaSnIDv5fu0bz8oq6RRhrGTeJLom6VAuEn oVMDc4uIuCiBvAD4IgzYS0GbZ993VA2OcfO7LMHqzj12yBWc64K8O1kYhOXacRlN+Nv3 T8GkQyaLs3m5sxen03Zx92mNpnBwgxfSnycl0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=YHbEfvsVVxc+gYgH/mCx2oiOfwYR2cp4fd3+upr+ZWE=; b=IOtUY1XzY3pNlVADS6DT5C3dQmTv2YecrbP3K9SlX5Ts/bkjkDwjh7GU+QG0oTOuDz wys3qXZDxUqVBHylv1hlwILWGIuef8M9U3oPMthnTD0fd/G/W9zwIw4Lln4EZxMB0s9v Y6ti9XlTn0SUOccguB5+s38Afl9ZZ98RptH5vc9wainJTjIw1PdMVqhwDltLVaGJc+Tq x4SftMK0aTqDGBVQUl1L9yKS7P9zhwoR+LPlScKfU9HZJMf9/smyR/J4pWOZ8avoRe9f bs8jTnXQIoLiIHwlC1WU3f4INeHixptwD00iGwGBgHLhGEeax6UHa5Cd9fcBSR7ATXC/ 3uCA== X-Gm-Message-State: AFeK/H3KP+5G9xzR+VgmtQhs9MHIfZ02CQ5TES/pN4tSR6D2plZVT1S+D/BSvqx7SOxASFJZJ2XhxOImwteoDFUP X-Received: by 10.107.141.134 with SMTP id p128mr9868261iod.83.1490395413400; Fri, 24 Mar 2017 15:43:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.10.27 with HTTP; Fri, 24 Mar 2017 15:43:33 -0700 (PDT) In-Reply-To: <20170324223819.11377-10-lersek@redhat.com> References: <20170324223819.11377-1-lersek@redhat.com> <20170324223819.11377-10-lersek@redhat.com> From: Ard Biesheuvel Date: Fri, 24 Mar 2017 22:43:33 +0000 Message-ID: To: Laszlo Ersek Cc: edk2-devel-01 , Leif Lindholm Subject: Re: [PATCH v3 09/12] ArmVirtPkg: enable AcpiTableDxe and EFI_ACPI_TABLE_PROTOCOL dynamically X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Mar 2017 22:43:34 -0000 Content-Type: text/plain; charset=UTF-8 On 24 March 2017 at 22:38, Laszlo Ersek wrote: > In this patch, the ACPI protocol / driver chain is enabled dynamically, > when appropriate. This is being done in one larger patch, because > ArmVirt.dsc.inc, where AcpiTableDxe is built, is used by all the platform > DSCs. > > No change in behavior should be observable after this patch on any > ArmVirtPkg platform. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel > --- > > Notes: > v3: > - don't enable dynamism for 32-bit (ARM) [Ard] > > ArmVirtPkg/ArmVirt.dsc.inc | 9 ++++++++- > ArmVirtPkg/ArmVirtQemu.dsc | 1 + > ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 + > ArmVirtPkg/ArmVirtXen.dsc | 1 + > ArmVirtPkg/ArmVirtXen.fdf | 1 + > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 1 + > 6 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index f61fd0680612..90ab97c240a1 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -443,5 +443,12 @@ [Components.AARCH64] > # > # ACPI Support > # > - MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf > + MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf { > + > + NULL|ArmPkg/Library/PlatformHasAcpiLib/PlatformHasAcpiLib.inf > + } > + > + # > + # EBC support > + # > MdeModulePkg/Universal/EbcDxe/EbcDxe.inf > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > index 4b556f309a6c..c2427a6fcea2 100644 > --- a/ArmVirtPkg/ArmVirtQemu.dsc > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > @@ -382,6 +382,7 @@ [Components.AARCH64] > # > # ACPI Support > # > + ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf > MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf > OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf { > > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc > index 6b6555c889a3..c7317a056c0e 100644 > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc > @@ -371,6 +371,7 @@ [Components.AARCH64] > # > # ACPI Support > # > + ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf > MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf > OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf { > > diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc > index 3422d1e5d996..679ca67ffa0f 100644 > --- a/ArmVirtPkg/ArmVirtXen.dsc > +++ b/ArmVirtPkg/ArmVirtXen.dsc > @@ -222,5 +222,6 @@ [Components.common] > # ACPI support > # > !if $(ARCH) == AARCH64 > + ArmVirtPkg/XenPlatformHasAcpiDtDxe/XenPlatformHasAcpiDtDxe.inf > ArmVirtPkg/XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf > !endif > diff --git a/ArmVirtPkg/ArmVirtXen.fdf b/ArmVirtPkg/ArmVirtXen.fdf > index c997251b12b8..aaae9755cd53 100644 > --- a/ArmVirtPkg/ArmVirtXen.fdf > +++ b/ArmVirtPkg/ArmVirtXen.fdf > @@ -184,6 +184,7 @@ [FV.FvMain] > # ACPI support > # > !if $(ARCH) == AARCH64 > + INF ArmVirtPkg/XenPlatformHasAcpiDtDxe/XenPlatformHasAcpiDtDxe.inf > INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf > INF ArmVirtPkg/XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf > > diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > index cc5d12aaefea..b4381132c864 100644 > --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > @@ -144,6 +144,7 @@ [FV.FvMain] > # > # ACPI Support > # > + INF ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf > INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf > INF MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf > INF OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf > -- > 2.9.3 > >