Re: [PATCH edk2-platforms v2 10/18] ARM/VExpressPkg: HdLcdArmVExpressLib: Remove status check EFI_TIMEOUT

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 22 December 2017 at 19:08,  <evan.lloyd@arm.com> wrote:
> From: Girish Pathak <girish.pathak at arm.com>
>
> None of the ArmPlatformSys*  functions returns EFI_TIMEOUT. Hence checking
> this in the do {} while loop in LcdPlatformSetMode is wrong. Therefore
> remove this comparision and as a result remove the do {} while loop.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Girish Pathak <girish.pathak@arm.com>
> Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c | 22 ++++++++------------
>  1 file changed, 9 insertions(+), 13 deletions(-)
>
> diff --git a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c
> index f8d19df79260cdfbe1876d6ccc10d49abd0637cf..533d7fa4777e8f22429e2ae63a828dcb5401b5c0 100644
> --- a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c
> +++ b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c
> @@ -230,25 +230,21 @@ LcdPlatformSetMode (
>    }
>
>    // Set the video mode oscillator
> -  do {
> -    Status = ArmPlatformSysConfigSetDevice (
> -               SYS_CFG_OSC_SITE1,
> -               FixedPcdGet32 (PcdHdLcdVideoModeOscId),
> -               mResolutions[ModeNumber].OscFreq
> -               );
> -  } while (Status == EFI_TIMEOUT);
> +  Status = ArmPlatformSysConfigSetDevice (
> +             SYS_CFG_OSC_SITE1,
> +             FixedPcdGet32 (PcdHdLcdVideoModeOscId),
> +             mResolutions[ModeNumber].OscFreq
> +             );
>    if (EFI_ERROR (Status)) {
>      ASSERT_EFI_ERROR (Status);
>      return Status;
>    }
>
>    // Set the DVI into the new mode
> -  do {
> -    Status = ArmPlatformSysConfigSet (
> -               SYS_CFG_DVIMODE,
> -               mResolutions[ModeNumber].Mode
> -               );
> -  } while (Status == EFI_TIMEOUT);
> +  Status = ArmPlatformSysConfigSet (
> +             SYS_CFG_DVIMODE,
> +             mResolutions[ModeNumber].Mode
> +             );
>    if (EFI_ERROR (Status)) {
>      ASSERT_EFI_ERROR (Status);
>      return Status;
> --
> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel