From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::241; helo=mail-io0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 903252035B2C5 for ; Sat, 23 Dec 2017 06:11:54 -0800 (PST) Received: by mail-io0-x241.google.com with SMTP id i143so7126014ioa.3 for ; Sat, 23 Dec 2017 06:16:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=o9IC5axfGIFZXZSnJ1EnAtJdSTB0EWYQVEjTjshms4s=; b=hGOORdZlC+eItVwHG+WkQP4DTv1Je4OdIA25tCcQJ3yQZh6Su6EZKxYmCR9NiBRqc1 pMWzYcygqVeQlDI20ybj7pQ9dG8QYa4ze3VBw95q1B6EXMAlCPml21aNZ2q23OUTUs1r LYsYXl3i/K+2VtObX9xDqwl0JaEFFPzmvUniM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=o9IC5axfGIFZXZSnJ1EnAtJdSTB0EWYQVEjTjshms4s=; b=QLpj1+69Kko2IQGZg5frpJUx736vFdwWZe5j2MrrYeNhx/UW5Vt9MzpNz79TaRZOUS 7Qf1U9IdIvIVGXyyPtllfk5p6DSafC/khUdzMXusNG0kzZrBsSmjUGZsPci64893o7kD Jk79Kr2S4JADFx0JxQqRTu+K2NqtMW8JTfWO6ybKqjFLhHlVAaOVK8ckgTFdUlOY9Dmc gydJyr9GU+VnVpnAmHUca8VntFTrLZzz5gmc4PSLQziJV25JIYX+zfhyKktyjuQx6OcT X0vb18JezpIO1TyLdBejmamYpUQQUWmY2JG08Sf+HK9HujOeHVb7tNdHEBm2a8t9BcQe 3RBQ== X-Gm-Message-State: AKGB3mIABBu7JWd5BaA9Npb+RX2ZwhSLrJX+80sVTY6TzPBcJHxeMZd9 cmaqMTfJXKOqwl4T4NZpmaKeR9SnrIEO4pRSrsecXGBt+Zk= X-Google-Smtp-Source: ACJfBoveoD3XFnFZW4RxpJlBhfmTmve0RA7XwXl8QLddlca39wM4ZX3/5aVF26qQUqhQeZSoF7sQ4Ze0C4xvyvlW3tE= X-Received: by 10.107.27.84 with SMTP id b81mr21763626iob.43.1514038603619; Sat, 23 Dec 2017 06:16:43 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.52.14 with HTTP; Sat, 23 Dec 2017 06:16:43 -0800 (PST) In-Reply-To: <20171222190821.12440-11-evan.lloyd@arm.com> References: <20171222190821.12440-1-evan.lloyd@arm.com> <20171222190821.12440-11-evan.lloyd@arm.com> From: Ard Biesheuvel Date: Sat, 23 Dec 2017 14:16:43 +0000 Message-ID: To: Evan Lloyd Cc: "edk2-devel@lists.01.org" , <"Matteo.Carlini@arm.com"@arm.com>, <"leif.lindholm@linaro.org"@arm.com>, <"nd@arm.com"@arm.com>, Arvind Chauhan , Thomas Panakamattam Abraham , <"ard.biesheuvel@linaro.org"@arm.com> Subject: Re: [PATCH edk2-platforms v2 10/18] ARM/VExpressPkg: HdLcdArmVExpressLib: Remove status check EFI_TIMEOUT X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Dec 2017 14:11:55 -0000 Content-Type: text/plain; charset="UTF-8" On 22 December 2017 at 19:08, wrote: > From: Girish Pathak > > None of the ArmPlatformSys* functions returns EFI_TIMEOUT. Hence checking > this in the do {} while loop in LcdPlatformSetMode is wrong. Therefore > remove this comparision and as a result remove the do {} while loop. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak > Signed-off-by: Evan Lloyd Reviewed-by: Ard Biesheuvel > --- > Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c | 22 ++++++++------------ > 1 file changed, 9 insertions(+), 13 deletions(-) > > diff --git a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > index f8d19df79260cdfbe1876d6ccc10d49abd0637cf..533d7fa4777e8f22429e2ae63a828dcb5401b5c0 100644 > --- a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > +++ b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > @@ -230,25 +230,21 @@ LcdPlatformSetMode ( > } > > // Set the video mode oscillator > - do { > - Status = ArmPlatformSysConfigSetDevice ( > - SYS_CFG_OSC_SITE1, > - FixedPcdGet32 (PcdHdLcdVideoModeOscId), > - mResolutions[ModeNumber].OscFreq > - ); > - } while (Status == EFI_TIMEOUT); > + Status = ArmPlatformSysConfigSetDevice ( > + SYS_CFG_OSC_SITE1, > + FixedPcdGet32 (PcdHdLcdVideoModeOscId), > + mResolutions[ModeNumber].OscFreq > + ); > if (EFI_ERROR (Status)) { > ASSERT_EFI_ERROR (Status); > return Status; > } > > // Set the DVI into the new mode > - do { > - Status = ArmPlatformSysConfigSet ( > - SYS_CFG_DVIMODE, > - mResolutions[ModeNumber].Mode > - ); > - } while (Status == EFI_TIMEOUT); > + Status = ArmPlatformSysConfigSet ( > + SYS_CFG_DVIMODE, > + mResolutions[ModeNumber].Mode > + ); > if (EFI_ERROR (Status)) { > ASSERT_EFI_ERROR (Status); > return Status; > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel