From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5C48222161144 for ; Wed, 14 Feb 2018 05:07:16 -0800 (PST) Received: by mail-it0-x244.google.com with SMTP id v186so9718821itc.5 for ; Wed, 14 Feb 2018 05:13:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=BrVPLJGwCpKuRzq6lIdlvHL/KtJjION0Hhi7xnL2VtA=; b=CRv38rbma33YzPqXYWjlDrMwipcT2QuB2g6WztlI2uGF1H2pmjtj2djb3VqNaGkjLl 21xNjAEA0F0lXeQeGcgFQOaqoHzP7McpUwOU6rRcIa7XtAE11/6QqtsKfmbFBVEFJ8kI rmCoW1jzTmsMNlvhqKzny9W7LLmZKSmXGg2rk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=BrVPLJGwCpKuRzq6lIdlvHL/KtJjION0Hhi7xnL2VtA=; b=dinl1hxPJnaA8CAFOS0HWtgb0Z1EKWYv4vTghiFZH+GXisyCGIlY6A5mQ5vuqSCtVl +sCdeLGDQFbpy/LXwCNZgeUxrumeDO+h8Eb6WUMf/P7RRvxoyeH+jUb1ZrKCPWXP0MIo XL3MTZqIBbzHrYmS1oKJlA8slXstHp6s1Kt8PlMhPx8YxBLF+7q5pl56rCqXqB27ZAke 8dmPU+p1/3LcAZsHZ6J5FFjfBGr83SbpirFMCH+J6gcahQsT49xrfLUDMmMGRRzEoW57 YphxWd98nh+rhF2w4+a3NH9GfhaFIO9wYgo570fmc9NABpaJpZeTaGAxL2H6RtANl2Sg S20g== X-Gm-Message-State: APf1xPBzNiI/B/FlpnpEGaW5Fm4BmYFuVOP9mUiqmQC8R1YHY5bHR90d 0EX80P35WXN/d/lUf1XVlRdRQ6ys6pgvrhLHFIoRBw== X-Google-Smtp-Source: AH8x2254RRdvNPNAijuLLgnYfPnbESjUkdwXCofA9P593K/feQbRCrBovmZwSKH0pf7XMaZ2c3jV1yShFRLUrVzKDrM= X-Received: by 10.36.172.17 with SMTP id s17mr5720796ite.143.1518613987084; Wed, 14 Feb 2018 05:13:07 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.112.13 with HTTP; Wed, 14 Feb 2018 05:13:06 -0800 (PST) In-Reply-To: <20180214130857.5020-2-pete@akeo.ie> References: <20180214130857.5020-1-pete@akeo.ie> <20180214130857.5020-2-pete@akeo.ie> From: Ard Biesheuvel Date: Wed, 14 Feb 2018 13:13:06 +0000 Message-ID: To: Pete Batard Cc: "edk2-devel@lists.01.org" , "Gao, Liming" Subject: Re: [PATCH 1/4] MdePkg: Disable some Level 4 warnings for VS2017/ARM64 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Feb 2018 13:07:16 -0000 Content-Type: text/plain; charset="UTF-8" On 14 February 2018 at 13:08, Pete Batard wrote: > We disable the exact same warnings as IA32 and X64. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Pete Batard > --- > MdePkg/Include/AArch64/ProcessorBind.h | 53 +++++++++++++++++++- > 1 file changed, 51 insertions(+), 2 deletions(-) > > diff --git a/MdePkg/Include/AArch64/ProcessorBind.h b/MdePkg/Include/AArch64/ProcessorBind.h > index bc473562f9e5..4f341ebeb03f 100644 > --- a/MdePkg/Include/AArch64/ProcessorBind.h > +++ b/MdePkg/Include/AArch64/ProcessorBind.h > @@ -1,7 +1,7 @@ > /** @file > Processor or Compiler specific defines and types for AArch64. > > - Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
> + Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
> Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
> Portions copyright (c) 2011 - 2013, ARM Ltd. All rights reserved.
> > @@ -30,7 +30,56 @@ > #pragma pack() > #endif > > -#if _MSC_EXTENSIONS > +#if defined(_MSC_EXTENSIONS) > + > +// > +// Disable some level 4 compilation warnings (same as IA32 and X64) > +// > + > +// > +// Disabling bitfield type checking warnings. > +// > +#pragma warning ( disable : 4214 ) > + > +// > +// Disabling the unreferenced formal parameter warnings. > +// > +#pragma warning ( disable : 4100 ) > + > +// > +// Disable slightly different base types warning as CHAR8 * can not be set > +// to a constant string. > +// > +#pragma warning ( disable : 4057 ) > + > +// > +// ASSERT(FALSE) or while (TRUE) are legal constructs so suppress this warning > +// > +#pragma warning ( disable : 4127 ) > + > +// > +// This warning is caused by functions defined but not used. For precompiled header only. > +// > +#pragma warning ( disable : 4505 ) > + > +// > +// This warning is caused by empty (after preprocessing) source file. For precompiled header only. > +// > +#pragma warning ( disable : 4206 ) > + > +// > +// Disable 'potentially uninitialized local variable X used' warnings > +// > +#pragma warning ( disable : 4701 ) > + > +// > +// Disable 'potentially uninitialized local pointer variable X used' warnings > +// > +#pragma warning ( disable : 4703 ) > + > +#endif > + > +#if defined(_MSC_EXTENSIONS) Can you drop the redundant #endif + #if please? Also, I take it _MSC_EXTENSIONS will never be #defined to 0 ? > // > // use Microsoft* C compiler dependent integer width types > // > -- > 2.9.3.windows.2 >