From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d42; helo=mail-io1-xd42.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0D2DA211B5A23 for ; Mon, 14 Jan 2019 07:22:56 -0800 (PST) Received: by mail-io1-xd42.google.com with SMTP id g8so17892103iok.4 for ; Mon, 14 Jan 2019 07:22:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ArvO+HYZznWSqwag49n1IuqV9ehWiz9IzENx23A74ww=; b=fHK3S4ZbU2Grms6pb+6GFiUY+LWcKnQWWZMZ3o5WpO4dGKyPg8fK/195wvqPF83IlA u4gylvHZKZXoQDrzCciOz50NExVYNvdjxCKaHncqi9vS9ouKCa18rxq/lfmVr6N/AGqV +3cTXQ/DJvRFwwPGJiU7JmUuIYPpXnWEoj4gE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ArvO+HYZznWSqwag49n1IuqV9ehWiz9IzENx23A74ww=; b=CJ1EQcHQlxBI4GJ6boA154fJ7/54dGAmWwDqvi0PhpSTvHBGuqzlW7YI6qxa7H34hV EckXNfXmxTQ+tNUWP4CICjnS6HRVZnOv5BR+kKsbn8eyXza95XvaoLtMthK7HYmnhCka b9xZzqc5P2xKpYqaG5pdkVl2QmE82Xz6MQ7f2kPu0jkuUun+9w2d/EPI7s/MkkOZtLZ4 7/AXYp5SuRthhZqFyP5VZ54ryITZoXvOuyUvxLsF/JzUAL+mj7ayn5DsXnN0Tu7mntNe neHScDIM59jmoPpGZqmi/SAPdchFvm9foGtxSvfz9lONYnnBRdA8O5/cs8Nu8//Exkzo 93rA== X-Gm-Message-State: AJcUukdbOLI44JegCPIDK/RcJEfDJxPSTJjEjAOna/5/WFV8x1uUPALl Vv4ey3JYa5wdU8tTiHYbWkTmvWw5xFEdtcUYqJTxyQ== X-Google-Smtp-Source: ALg8bN4R6hLcA039M3uh/l5qoGyMDuxPUb6X+J91TtpMwO57THtJBQKvDwE+/c05ySsDu8ehLVWnbGvvDlAH1Bo1RvY= X-Received: by 2002:a5d:8410:: with SMTP id i16mr16616933ion.173.1547479376204; Mon, 14 Jan 2019 07:22:56 -0800 (PST) MIME-Version: 1.0 References: <20181221150848.4783-1-ard.biesheuvel@linaro.org> <20190114112424.weqnta4n4jijrszz@bivouac.eciton.net> In-Reply-To: <20190114112424.weqnta4n4jijrszz@bivouac.eciton.net> From: Ard Biesheuvel Date: Mon, 14 Jan 2019 16:22:44 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH] ArmPkg/ArmGicV3Dxe: use correct value for ARM_GICD_IROUTER X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 15:22:57 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, 14 Jan 2019 at 12:24, Leif Lindholm wrote: > > On Fri, Dec 21, 2018 at 04:08:48PM +0100, Ard Biesheuvel wrote: > > Use the correct value for ARM_GICD_IROUTER as per the GIC spec, > > and fix the code that relies on the value being skewed by 32 x 8 > > bytes. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > --- > > ArmPkg/Include/Library/ArmGicLib.h | 2 +- > > ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/ArmPkg/Include/Library/ArmGicLib.h b/ArmPkg/Include/Library/ArmGicLib.h > > index 5775905ca91b..b52b77628ae1 100644 > > --- a/ArmPkg/Include/Library/ArmGicLib.h > > +++ b/ArmPkg/Include/Library/ArmGicLib.h > > @@ -43,7 +43,7 @@ > > #define ARM_GIC_ICDSGIR 0xF00 // Software Generated Interrupt Register > > > > // GICv3 specific registers > > -#define ARM_GICD_IROUTER 0x6100 // Interrupt Routing Registers > > +#define ARM_GICD_IROUTER 0x6000 // Interrupt Routing Registers > > Actually, whilst I agree the above would be more consistent, both > revisions C and D of ARM IHI 0069 list the address offset of > ARM_GICD_IROUTER as 0x6100 (and the preceding register space as > "Reserved"). > OK, in that case, please disregard this patch.