From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66])
 by mx.groups.io with SMTP id smtpd.web12.9523.1583480580225676479
 for <devel@edk2.groups.io>;
 Thu, 05 Mar 2020 23:43:00 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=ISE2a+yW;
 spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: ard.biesheuvel@linaro.org)
Received: by mail-wm1-f66.google.com with SMTP id e26so1227611wme.5
        for <devel@edk2.groups.io>; Thu, 05 Mar 2020 23:42:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=GEP40jkCIo7WoFNwM/KRU0nOtgTjXgETScbl8jBp2Ug=;
        b=ISE2a+yW3kvvm0yao3RBv2D+LGfRH6OYgCxlnPnzciJd6C3b+5RM3QVJnaZGNn0+h4
         WdwmKS3tE75eeHUxgXReHHeZ4/xpcjq5zKJtu+Hm3BEE2PiOUaG2z5RdXIuoidYppgcZ
         r6rlLGUl2zVA4cWqO0XA9V1PVytjbZWLxnG7+UQAdTVsYW1/k0M0fxdunHBmNdxgZRnK
         2Od/N3O4P3yDGapTybF1Uq0LDwUvRjArk/ZJe2PrF7vMikWBuDTmTuECzjHeoi2xYxa+
         zzrLR78T/whAU+ret4DiDfsD0JokbbFxX2yrKe/npPpDdXLWYvmjWnPZrSUUPFLJHOah
         ndoA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=GEP40jkCIo7WoFNwM/KRU0nOtgTjXgETScbl8jBp2Ug=;
        b=d4BaraRN8bQQLS6hY8amFLbZY/ZSXsS0+Sk6VoMVbWYJf7RciwP/y+2j7QAH8y0QFP
         LPqZMQpugFUXDNBkYZZlr7l6TShZNRzg3zNWE97K7L38TzloVVdKD7nOIbMGl3r0O0OD
         uGDllSqoWzETV+ZiQR/ZGeUObMXj/38kcQxH7zxjFMXiotpNNaLJo291Vji1bG3apExY
         Jzek8baPrmXFtWUvDp05zonXCZe2zjk7PSZQAPyjITqmI2R3fdKzKtN3lLWGzdYYaMbE
         2SsSxqTSj8PfAf+AjlgfriIYqHOPVrAuNRKmFx80z/VXyeCmWz+KEO1Dw9XazOrykR1E
         NcJg==
X-Gm-Message-State: ANhLgQ2lqqnqODjuRn3Levvh6ZaEdU0VevcSV7w9GlrJyB3gUmBhyr17
	uz8h+QkzqcWyJIbHf2iT8Nixo4a2VAzUdrEMPU9pi9VcvUk=
X-Google-Smtp-Source: ADFU+vtcPcFs5K2KV36G7t4qoAslrYR6V3Sr3Eh+hRd8GKVdngK/XSng6vccMj6AKmS35NIXf7oZI1D3T+81mrkR/pA=
X-Received: by 2002:a1c:2d88:: with SMTP id t130mr2668168wmt.68.1583480578565;
 Thu, 05 Mar 2020 23:42:58 -0800 (PST)
MIME-Version: 1.0
References: <20200305134607.20125-1-ard.biesheuvel@linaro.org> <98e6a0e0f82048a2b20b263c4f752fcc@intel.com>
In-Reply-To: <98e6a0e0f82048a2b20b263c4f752fcc@intel.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Fri, 6 Mar 2020 08:42:48 +0100
Message-ID: <CAKv+Gu_LPXogSK-WenOq-7Hi-nHSTyGHRHtt5jqqd9PEtvc5vA@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH v3 00/14] Ovmf: use LoadImage/StartImage for loading command line images
To: "Feng, Bob C" <bob.c.feng@intel.com>, "lersek@redhat.com" <lersek@redhat.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>
Content-Type: text/plain; charset="UTF-8"

On Fri, 6 Mar 2020 at 03:01, Feng, Bob C <bob.c.feng@intel.com> wrote:
>
> Hi Ard,
>
> I found this patch set cause Ovmf platform build failure on windows with VS2017.
>
> The error message is as following:
>
> Generating code
> d:\edk2\OvmfPkg\QemuKernelLoaderFsDxe\QemuKernelLoaderFsDxe.c(130): error C2220: warning treated as error - no 'object' file generated
> d:\edk2\OvmfPkg\QemuKernelLoaderFsDxe\QemuKernelLoaderFsDxe.c(130): warning C4132: 'mEfiFileProtocolTemplate': const object should be initialized
> TcpTimer.c
> Finished generating code
> NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\Hostx86\x86\cl.exe"' : return code '0x2'
> Stop.
>
>
> build.py...
>  : error 7000: Failed to execute command
>         C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\Hostx86\x86\nmake.exe /nologo tbuild [d:\edk2\Build\OvmfIa32\DEBUG_VS2017\IA32\OvmfPkg\QemuKernelLoaderFsDxe\QemuKernelLoaderFsDxe]
>
>
> build.py...
>  : error F002: Failed to build module
>         d:\edk2\OvmfPkg\QemuKernelLoaderFsDxe\QemuKernelLoaderFsDxe.inf [IA32, VS2017, DEBUG]
>
>
> Please help to provide patch to fix it.
>

Interesting. That code was moved from an ARM only source file to one
that is shared between all architectures.

GCC and Clang have no problem with that, and I think a tentative
definitive of a const object is permitted by the spec.

Anyway, I sent a patch to fix it. Please confirm whether it works for you.