From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Chris Co <Christopher.Co@microsoft.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [PATCH edk2-platforms 3/3] Platform/Microsoft: Add Lauterbach debug library
Date: Tue, 31 Jul 2018 22:59:22 +0200 [thread overview]
Message-ID: <CAKv+Gu_Lte_qF54M6+iivZ_W5nWAXR+38i8FH5Gwd_D0LLEbJQ@mail.gmail.com> (raw)
In-Reply-To: <20180731205637.wxvzwq2xnbiaieju@bivouac.eciton.net>
On 31 July 2018 at 22:56, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Tue, Jul 17, 2018 at 02:05:45AM +0000, Chris Co wrote:
>> This debug library provides support for importing symbols to
>> debug using Lauterbach.
>>
>> Derived from: ArmPkg\Library\DebugPeCoffExtraActionLib
>
> I'm not seeing any difference between this one and the original other
> than the addition of the Microsoft copyright statement and updating of
> the debug printouts to modern style.
>
> I would be happy to take this as a patch to the original, but I don't
> see what benefit this copy brings. What prevents you from using the
> original?
>
The 'data.load.elf' statement in
PeCoffLoaderRelocateImageExtraAction() is particular to Lauterbach
next prev parent reply other threads:[~2018-07-31 20:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 2:05 [PATCH edk2-platforms 0/3] Add Platform-Generic Packages to support Windows IoT Core Chris Co
2018-07-17 2:05 ` [PATCH edk2-platforms 1/3] Platform/Microsoft: Add SdMmc Dxe Driver Chris Co
2018-07-31 20:33 ` Leif Lindholm
2018-08-02 0:05 ` Chris Co
2018-08-02 11:38 ` Leif Lindholm
2018-07-17 2:05 ` [PATCH edk2-platforms 2/3] Platform/Microsoft: Add MsPkg Chris Co
2018-07-31 20:38 ` Leif Lindholm
2018-07-17 2:05 ` [PATCH edk2-platforms 3/3] Platform/Microsoft: Add Lauterbach debug library Chris Co
2018-07-31 20:56 ` Leif Lindholm
2018-07-31 20:59 ` Ard Biesheuvel [this message]
2018-08-01 9:39 ` Leif Lindholm
2018-08-02 1:27 ` Chris Co
2018-08-02 11:22 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu_Lte_qF54M6+iivZ_W5nWAXR+38i8FH5Gwd_D0LLEbJQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox