From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1DB9D210C42BA for ; Tue, 31 Jul 2018 13:59:24 -0700 (PDT) Received: by mail-io0-x242.google.com with SMTP id k16-v6so14242895iom.12 for ; Tue, 31 Jul 2018 13:59:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=MVsoGSyr1L2T4zUIIgEmNN9ySVQaqdaVd1aCYeXFUWU=; b=UiLl9zL4tkYq9sgZmdgwb5V+5qh7ZtM8xrqq+MTbDiyJ3mnJkCokuQm/OLSw9VoXHl WaeSstxuiNSYprOdstbB8VM0fPHdyTe5BMp1XppqkgpO/b5hY3d/fhwHgxZ7X9xUHlHn uDvFaddjG2BbDnIMaGQTCn2h4ScICkYHoNiTQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MVsoGSyr1L2T4zUIIgEmNN9ySVQaqdaVd1aCYeXFUWU=; b=Hp3dQKS+afvZveP+NSX2/YqjeAGQJ1S6ue58QM1qLe9C5n/fAX+5IINHHM1Qq+8z4L cmwt/CQX6yu+Jk0F10oT03sTmS+qVnkqzI4jxM8xbbxv5QXP4YIcspLMizrFQLhN/Pde bP8FFdgPz0lx3avq2nzUWy9gTvpC2R63l4mL2n51dTuMalqBduU9lBE+Vu97ejc4txoa VKID8ALrJHClRCzEI+vcZ0M/yi4Q1fARbfpkmqnYFl2vOjRK6klsAGOVC+qGvolvy18k gTZOp3UuJ6KG7ohukkNwshSDRsf5FaxPGjV3HZ6H9DWlbsthkb88L15ChIrgnPqvfGJV rauw== X-Gm-Message-State: AOUpUlGjZV4cuf6XcJp7cUcO8CYqNDO/yx/NGO4CY8JMqhkLmp+UculA G/fWiBngxTWtyrtx8cBnUKVC+p1kWVMlBLDUQuEUSA== X-Google-Smtp-Source: AAOMgpczyuzc0ILtxrTaQ59pdVq1HLcxQaV102sdNZPJJCPh4xLI0djjP+JftaMVkv3+DjNwb3kvPa6lcT6vY5tJ1I0= X-Received: by 2002:a6b:be83:: with SMTP id o125-v6mr1103321iof.173.1533070763124; Tue, 31 Jul 2018 13:59:23 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:ac05:0:0:0:0:0 with HTTP; Tue, 31 Jul 2018 13:59:22 -0700 (PDT) In-Reply-To: <20180731205637.wxvzwq2xnbiaieju@bivouac.eciton.net> References: <20180717020529.19496-1-christopher.co@microsoft.com> <20180717020529.19496-4-christopher.co@microsoft.com> <20180731205637.wxvzwq2xnbiaieju@bivouac.eciton.net> From: Ard Biesheuvel Date: Tue, 31 Jul 2018 22:59:22 +0200 Message-ID: To: Leif Lindholm Cc: Chris Co , "edk2-devel@lists.01.org" , Michael D Kinney Subject: Re: [PATCH edk2-platforms 3/3] Platform/Microsoft: Add Lauterbach debug library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jul 2018 20:59:24 -0000 Content-Type: text/plain; charset="UTF-8" On 31 July 2018 at 22:56, Leif Lindholm wrote: > On Tue, Jul 17, 2018 at 02:05:45AM +0000, Chris Co wrote: >> This debug library provides support for importing symbols to >> debug using Lauterbach. >> >> Derived from: ArmPkg\Library\DebugPeCoffExtraActionLib > > I'm not seeing any difference between this one and the original other > than the addition of the Microsoft copyright statement and updating of > the debug printouts to modern style. > > I would be happy to take this as a patch to the original, but I don't > see what benefit this copy brings. What prevents you from using the > original? > The 'data.load.elf' statement in PeCoffLoaderRelocateImageExtraAction() is particular to Lauterbach