From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::232; helo=mail-it0-x232.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x232.google.com (mail-it0-x232.google.com [IPv6:2607:f8b0:4001:c0b::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 303DD20954CB3 for ; Thu, 22 Feb 2018 07:07:11 -0800 (PST) Received: by mail-it0-x232.google.com with SMTP id a75so6592637itd.0 for ; Thu, 22 Feb 2018 07:13:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2HMsEQ6k4wwBevYLn97gVOApyq9anLWA8t3wRyq3vNo=; b=indr6shn+6nBIvdM9nCs6GNVR2vF53lFRZsLij9tLpBLD0hgIVpfX3ey+dInMcv352 7WKB+82r0ky5rIYb81bdNd+cPcojM5uFF6FovDPwejxvI2fRRMT8mfAaQW8hWk2yR/2J gXB9JB/1Z5SjT/l+uA6Mdxn+LyzVDjnywh2eo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2HMsEQ6k4wwBevYLn97gVOApyq9anLWA8t3wRyq3vNo=; b=WMZdJgU2V0RThY8foxWDcQK0oH3Yz1pIZAf/znPO6NUDnRgBZtfwfkOJLjsTONv1JE 66s8bcLhhMXAgNK4OMjulajN78VVc9SL6DRWr6C9yBtcQcsWuJ4BgyhPz5fBp7FbX48X GJhEWt82Ja6b5HVL1/a7xPjsJ15Q1QDFASOk5ubRodZN761dfnQvO+yZ5wz+JT/Z+jLn eEOoq2fD8AU8Uc/mTD77Fu2Qx129WADgBsYo/QLD5z0m8wMhSKZAqVkqhxFyN4z7suPm B4WHX/J61nzcn9qZLa2KVJwWhlFH/urLTyrdPKmh59nKX9uTCTmYunH2afSdztd/ycKe Hmxw== X-Gm-Message-State: APf1xPAvIeni9jyv53tY13jdsUtyZXPOf7K/hrno3nrw9v509CyuyVcy 1T5whmb/Xqh5Ojst4y43kjM059R1B6gkfsbFkNntT4MI X-Google-Smtp-Source: AH8x226HKV/QRrFhgFb1udpWIMPIMbX5EgmGpC4X5PyPIJMfNLpT2HNU233MFOdqGMg5/1eSm1YOemqWa0/zHZZwczQ= X-Received: by 10.36.13.5 with SMTP id 5mr8379505itx.68.1519312391653; Thu, 22 Feb 2018 07:13:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.138.209 with HTTP; Thu, 22 Feb 2018 07:13:09 -0800 (PST) In-Reply-To: <20180222134427.22s3lgzyg4iwxoir@bivouac.eciton.net> References: <20180220174944.525-1-ard.biesheuvel@linaro.org> <20180220174944.525-3-ard.biesheuvel@linaro.org> <20180222131553.dixmsbldbufxdgat@bivouac.eciton.net> <20180222134427.22s3lgzyg4iwxoir@bivouac.eciton.net> From: Ard Biesheuvel Date: Thu, 22 Feb 2018 15:13:09 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH edk2-platforms v2 2/7] Platform/NinetySixBoards: introduce package and mezzanine protocol X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2018 15:07:12 -0000 Content-Type: text/plain; charset="UTF-8" On 22 February 2018 at 13:44, Leif Lindholm wrote: > On Thu, Feb 22, 2018 at 01:21:37PM +0000, Ard Biesheuvel wrote: >> On 22 February 2018 at 13:15, Leif Lindholm wrote: >> > On Tue, Feb 20, 2018 at 05:49:39PM +0000, Ard Biesheuvel wrote: >> >> Introduce the mezzanine protocol and the 96boards package defining >> >> the PCDs and GUIDs that may be used by implementations of the >> >> protocol. >> > >> > This looks really good. Comments below are all style related. >> > >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> >> Signed-off-by: Ard Biesheuvel >> >> --- >> >> Platform/NinetySixBoards/Include/Protocol/Mezzanine.h | 71 ++++++++++++++++++++ >> >> Platform/NinetySixBoards/NinetySixBoards.dec | 67 ++++++++++++++++++ >> > >> > Why NinetySixBoards? Is 96Boards ENOTENOUGHCAMEL? >> > >> >> That is what I started out with, but having CPP macros and lots of VFR >> identifiers and other bits and pieces using leading digits was making >> me nervous about whether it is supported in all configurations, so I >> bit the bullet and renamed everything. > > I understand the paranoia, but we do have > PcAtChipsetPkg/8259InterruptControllerDxe > and > PcAtChipsetPkg/8254TimerDxe > so I would expect this to actually be reasonably well supported. > > We may not have to worry about 3com and 3ware anymore, but if someone > wants to write drivers for ancient cards, I'd still prefer to be able > to give them predictable paths. > Fair enough, I'll change it back.