Re: [RFT PATCH] EmbeddedPkg/AndroidFastbootApp: remove dependency on deprecated BdsLib

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 18 April 2017 at 20:21, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Tue, Apr 18, 2017 at 07:08:57PM +0100, Ard Biesheuvel wrote:
>> On 10 April 2017 at 17:55, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>> > One of the last remaining modules with a dependency on the deprecated
>> > BdsLib implementation from ArmPkg is the Android fastboot application.
>> >
>> > Its only dependency on BdsLib is BdsStartEfiApplication(), which is
>> > used in the most peculiar way: the fastboot app loads the kernel image
>> > into memory, and creates a MemoryMapped() device path for it. It then
>> > proceeds and calls BdsStartEfiApplication(), which explicitly loads the
>> > contents of the devicepath into memory, creating a second in-memory copy
>> > of the kernel image, after which it invokes gBS->LoadImage() with a
>> > buffer address and size (while it is perfectly capable of loading from
>> > a devicepath directly)
>> >
>> > Since we know the device path is fully qualified and connected, and does
>> > not require any of the additional processing that BdsStartEfiApplication()
>> > does when dereferencing a device path, we should be able to pass this
>> > devicepath into LoadImage() directly.
>> >
>> > So create a simplified local clone of BdsStartEfiApplication(), and drop
>> > the dependency on BdsLib.
>> >
>> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>
>> Should we just merge this and see what happens?
>
> With no other comments so far - sure:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

OK, pushed.

Thanks,
Ard.