From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x233.google.com (mail-it0-x233.google.com [IPv6:2607:f8b0:4001:c0b::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2A25B21A6F106 for ; Wed, 19 Apr 2017 00:18:55 -0700 (PDT) Received: by mail-it0-x233.google.com with SMTP id a140so7785644ita.0 for ; Wed, 19 Apr 2017 00:18:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=/KAJuOaJ63SQw0yeLwFHp4/+y4d7N6ZjMwOLpCfOroc=; b=WLScJXJZxkV+Y59g2MRblMdB1wISYSWHfBjKDoYGmy5leE+oeyhblOcb0j9dXXNXoE Ka+K7cXvmu+M/s92fARGFSLw4TAiugDR6jU2V8ZHeGIbYGU3GLxFhGkk6MyKBdIcqqYd a4CPV8ZRPh6f3465nmg1egQ5DVL0hpHE+4HIY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=/KAJuOaJ63SQw0yeLwFHp4/+y4d7N6ZjMwOLpCfOroc=; b=V5IGr/1DP6rqVRrcDjx0xagYk6dMvCITiPIt1OVVVfWGByfCqDWlzgGTvdS2uhdmrU ZIliQWSiOOslnVP8VxJS5gETbX4l7nXohdusHPJrNBgKN2WVPWW/mK9YTRpuhJc1YMrF uMaLF5Vbnb9A4mpEE8oMU38+S1RymkNjOgUVCOJxYHfVsus2i3dLP0kQhidv0QxKG+fR f2aXOY1EB0vKDi0wfi1Z29aPHi7WrcywV951i3kwEVasv6qBx+Uv5P4X42qG9SnM2LZT GeBgc85ngfyRZjKL4zQQkgNfFIOwyzsf9WGCL9+OFDmbJZakjIoN/XQgAJh7S6xWzf/g EsPw== X-Gm-Message-State: AN3rC/7jk3tQdTEKD8isr8VGNQEQ/UKqdKJ/aJzBYTSvzwET7ZbAtFvK D5PNiMnv2d9DCMLC0HNL3hCxRCb4xIMkHvk= X-Received: by 10.36.2.205 with SMTP id 196mr1592297itu.63.1492586334475; Wed, 19 Apr 2017 00:18:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.201.76 with HTTP; Wed, 19 Apr 2017 00:18:54 -0700 (PDT) In-Reply-To: <20170418192124.GR1657@bivouac.eciton.net> References: <20170410165534.22292-1-ard.biesheuvel@linaro.org> <20170418192124.GR1657@bivouac.eciton.net> From: Ard Biesheuvel Date: Wed, 19 Apr 2017 08:18:54 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Ryan Harkin , Haojian Zhuang Subject: Re: [RFT PATCH] EmbeddedPkg/AndroidFastbootApp: remove dependency on deprecated BdsLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2017 07:18:55 -0000 Content-Type: text/plain; charset=UTF-8 On 18 April 2017 at 20:21, Leif Lindholm wrote: > On Tue, Apr 18, 2017 at 07:08:57PM +0100, Ard Biesheuvel wrote: >> On 10 April 2017 at 17:55, Ard Biesheuvel wrote: >> > One of the last remaining modules with a dependency on the deprecated >> > BdsLib implementation from ArmPkg is the Android fastboot application. >> > >> > Its only dependency on BdsLib is BdsStartEfiApplication(), which is >> > used in the most peculiar way: the fastboot app loads the kernel image >> > into memory, and creates a MemoryMapped() device path for it. It then >> > proceeds and calls BdsStartEfiApplication(), which explicitly loads the >> > contents of the devicepath into memory, creating a second in-memory copy >> > of the kernel image, after which it invokes gBS->LoadImage() with a >> > buffer address and size (while it is perfectly capable of loading from >> > a devicepath directly) >> > >> > Since we know the device path is fully qualified and connected, and does >> > not require any of the additional processing that BdsStartEfiApplication() >> > does when dereferencing a device path, we should be able to pass this >> > devicepath into LoadImage() directly. >> > >> > So create a simplified local clone of BdsStartEfiApplication(), and drop >> > the dependency on BdsLib. >> > >> > Signed-off-by: Ard Biesheuvel >> >> Should we just merge this and see what happens? > > With no other comments so far - sure: > Reviewed-by: Leif Lindholm > OK, pushed. Thanks, Ard.