public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>,
	Jordan Justen <jordan.l.justen@intel.com>
Subject: Re: [PATCH 0/5] OvmfPkg, ArmVirtPkg: QemuFwCfgLib: partial rewrite of fw_cfg files
Date: Fri, 27 Jan 2017 18:25:10 +0000	[thread overview]
Message-ID: <CAKv+Gu_MqMkCPdUbASr+poCTMQ1D=heAdrnZtiQ+wrdNDtpoeg@mail.gmail.com> (raw)
In-Reply-To: <20170127112942.19212-1-lersek@redhat.com>

On 27 January 2017 at 11:29, Laszlo Ersek <lersek@redhat.com> wrote:
> This feature will allow OvmfPkg/AcpiPlatformDxe to implement the
> QEMU_LOADER_WRITE_POINTER command, which will instruct the firmware to
> write the address of a previously allocated/downloaded fw_cfg blob into
> another (writeable) fw_cfg file at a specific offset, in order to inform
> QEMU about the allocation address. The command will be based on the
> QemuFwCfgSkipBytes() and QemuFwCfgWriteBytes() APIs.
>
> Ref:    https://bugzilla.tianocore.org/show_bug.cgi?id=359
> Repo:   https://github.com/lersek/edk2.git
> Branch: fwcfg_skip
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
>

Looks fine to me, although you're the expert here

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>


  parent reply	other threads:[~2017-01-27 18:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-27 11:29 [PATCH 0/5] OvmfPkg, ArmVirtPkg: QemuFwCfgLib: partial rewrite of fw_cfg files Laszlo Ersek
2017-01-27 11:29 ` [PATCH 1/5] OvmfPkg/QemuFwCfgLib: generalize InternalQemuFwCfgDmaBytes() to SKIP op Laszlo Ersek
2017-01-27 11:29 ` [PATCH 2/5] OvmfPkg/QemuFwCfgLib: add QemuFwCfgSkipBytes() Laszlo Ersek
2017-01-27 11:29 ` [PATCH 3/5] ArmVirtPkg/QemuFwCfgLib: extract generic DmaTransferBytes() function Laszlo Ersek
2017-01-27 11:29 ` [PATCH 4/5] ArmVirtPkg/QemuFwCfgLib: use DMA for QemuFwCfgWriteBytes() if available Laszlo Ersek
2017-01-27 11:29 ` [PATCH 5/5] ArmVirtPkg/QemuFwCfgLib: implement QemuFwCfgSkipBytes() API Laszlo Ersek
2017-01-27 18:25 ` Ard Biesheuvel [this message]
2017-01-30 23:07 ` [PATCH 0/5] OvmfPkg, ArmVirtPkg: QemuFwCfgLib: partial rewrite of fw_cfg files Jordan Justen
2017-01-30 23:18   ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu_MqMkCPdUbASr+poCTMQ1D=heAdrnZtiQ+wrdNDtpoeg@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox