From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22f.google.com (mail-it0-x22f.google.com [IPv6:2607:f8b0:4001:c0b::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7F2AA81FD2 for ; Fri, 27 Jan 2017 10:25:11 -0800 (PST) Received: by mail-it0-x22f.google.com with SMTP id r185so62055663ita.0 for ; Fri, 27 Jan 2017 10:25:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=RWleWmykqmP9yieQgLjSVU60yARh1juzsp3DNN3k+1E=; b=WSgZUryUoY0UD0aFD4rJOA2vlCS5IR8bXgxOmffdTf+NnwT8k7dqvcwBXBDj7uQGV+ 2heKAbNZp8DRwmPdFvCQc9I8UvFuF7ke4sFmJ8wYekEXjScZ151XqzTGgwg8vpp931X9 k8FcUqIJs1RujRGoAuP2dF/6c7l49VoHG+hwk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=RWleWmykqmP9yieQgLjSVU60yARh1juzsp3DNN3k+1E=; b=P87M5O9LSz3Pmd7HoQ7p2OSkwXfguC2x7iXI24Hj3x5VNOnXHZHuFGFcN56AknTwpg sy2hdYTjLSID/mmQerzWvNWWcK5YoP0Px0sfB0GBqc+UAyNxz6Oon5cr2xOxqXFny15+ mazdleOO6QCP/g79OaP7GoFk2pdI7Zt8PLJdRONFbmEx0gCWAf2BUDKauxUEqZRAAkCQ vkppixWDeQIe2EzKZrdRwDYUu4X0OTCsCENnxh4iWoz29pqgNhTuPe3kcXRsFm6009P+ 34cIZxCkWmvZSgbvNaP6k4qE8pyHMemfsPgDK1dv2lDXbZu4BuGTS+EjQgR8EPyziQY7 uf5g== X-Gm-Message-State: AIkVDXJeqgk0g2/lLsqd3Nev0V9Dq4nVnOq8Sd4N5QiValhFFX19aNTEfzUxZ29L43rHpZUEBwDl4haqEaPgN+cn X-Received: by 10.36.74.67 with SMTP id k64mr4190247itb.37.1485541510845; Fri, 27 Jan 2017 10:25:10 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.144.139 with HTTP; Fri, 27 Jan 2017 10:25:10 -0800 (PST) In-Reply-To: <20170127112942.19212-1-lersek@redhat.com> References: <20170127112942.19212-1-lersek@redhat.com> From: Ard Biesheuvel Date: Fri, 27 Jan 2017 18:25:10 +0000 Message-ID: To: Laszlo Ersek Cc: edk2-devel-01 , Jordan Justen Subject: Re: [PATCH 0/5] OvmfPkg, ArmVirtPkg: QemuFwCfgLib: partial rewrite of fw_cfg files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jan 2017 18:25:11 -0000 Content-Type: text/plain; charset=UTF-8 On 27 January 2017 at 11:29, Laszlo Ersek wrote: > This feature will allow OvmfPkg/AcpiPlatformDxe to implement the > QEMU_LOADER_WRITE_POINTER command, which will instruct the firmware to > write the address of a previously allocated/downloaded fw_cfg blob into > another (writeable) fw_cfg file at a specific offset, in order to inform > QEMU about the allocation address. The command will be based on the > QemuFwCfgSkipBytes() and QemuFwCfgWriteBytes() APIs. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=359 > Repo: https://github.com/lersek/edk2.git > Branch: fwcfg_skip > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Looks fine to me, although you're the expert here Reviewed-by: Ard Biesheuvel