From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::141; helo=mail-it1-x141.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x141.google.com (mail-it1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B9975211AEA44 for ; Fri, 18 Jan 2019 07:31:44 -0800 (PST) Received: by mail-it1-x141.google.com with SMTP id b5so6294335iti.2 for ; Fri, 18 Jan 2019 07:31:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9bE2pp+uWepX/oZJq+4TtzZd8OyxRajl/2viBjcR4SU=; b=Hqu9TX5Gvr0VgZV1S7MCwX1WMenyW5oYUwGEHFt/Zzl4IY9bk00E4YiDiTaaYseZo7 IExfONMwwgAwIRxzMKH4TIin/u/I/oufPrBI8L6qivR0YluDJwk3Tr1rwPtnrKjTmmr2 wsChUYDoMK/PbMDQuQ0w6OC1UKLyyUnxSaSmQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9bE2pp+uWepX/oZJq+4TtzZd8OyxRajl/2viBjcR4SU=; b=p5PKrj0xrsEHh2wmu0Yiu/IJKX81W2Ttql7BMeHucsX7b0AWa+JmboKALwPxz509Fq 6PGt50l3bnFnrmw3ZmwrA0dKOV/ZZoNlanyUaUjyryz9X7mzFU1/dqjICoYkobJZmaE3 9/i+CDdpy/v7zJPCD592XSeUFlrUbGS+bt7L7pjRT3rde1P5m5KBlxL8F0OQ76psYapJ sA91bkGW4CxuNEALbPVsxFkl/7M4HBsV3CsFySVWEVaJrNvu2AGnVJgPAOM6nlxxOh0i BCwTZa9esEjxCGaSk+gi3dOKngN8Gp7khgT+TISJOX7lhRsa6INvePAFeFBEh2OuA7wR 4xKg== X-Gm-Message-State: AJcUukdydkJUz7DmR+y5JE0xPSfZhUJdZUM85X4PluXWiw1Oq4HI6YiW fspy8oPr7oDSadHmLIcqu2/aoxNUDYwIT/0mO8yn6A== X-Google-Smtp-Source: ALg8bN44SrxWMiD/bKMyWpmtToRnNjhr1A6iCxFMYZdsy5hUdNE1yO6DwWFH03cHIQqJ/HnWlh5Bpk46yf4vTI12vw0= X-Received: by 2002:a24:edc4:: with SMTP id r187mr12444747ith.158.1547825503808; Fri, 18 Jan 2019 07:31:43 -0800 (PST) MIME-Version: 1.0 References: <20190116202236.6977-1-ard.biesheuvel@linaro.org> <20190116202236.6977-6-ard.biesheuvel@linaro.org> <74D8A39837DF1E4DA445A8C0B3885C503F4B194A@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503F4B194A@shsmsx102.ccr.corp.intel.com> From: Ard Biesheuvel Date: Fri, 18 Jan 2019 16:31:32 +0100 Message-ID: To: "Yao, Jiewen" Cc: "edk2-devel@lists.01.org" , Achin Gupta , Supreeth Venkatesh , Leif Lindholm , Jagadeesh Ujja , Thomas Panakamattam Abraham , Sami Mujawar Subject: Re: [PATCH v2 05/11] StandaloneMmPkg/StandaloneMmCoreEntryPoint: add missing SerialPortLib ref X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jan 2019 15:31:45 -0000 Content-Type: text/plain; charset="UTF-8" On Fri, 18 Jan 2019 at 16:27, Yao, Jiewen wrote: > > Usually, we do not encourage to use SerialPortLib directly in a hardware independent environment. > I do not suggest we bring an architecture dependency on the existence of SerialPort in a common code. > > However, if ARCH64 has some specific code that must use SerialPortLib explicitly, I am OK. > Can we move SerialPortLib under [LibraryClasses.AARCH64] ? > I am happy to remove the SerialPortInitialize call, and instead rely on DebugLib to pull in SerialPortLIb if it wants to (and rely on the constructor to be invoked implicitly) > > > > > -----Original Message----- > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > Sent: Wednesday, January 16, 2019 12:23 PM > > To: edk2-devel@lists.01.org > > Cc: Ard Biesheuvel ; Achin Gupta > > ; Yao, Jiewen ; Supreeth > > Venkatesh ; Leif Lindholm > > ; Jagadeesh Ujja ; > > Thomas Panakamattam Abraham ; Sami > > Mujawar > > Subject: [PATCH v2 05/11] StandaloneMmPkg/StandaloneMmCoreEntryPoint: > > add missing SerialPortLib ref > > > > StandaloneMmCoreEntryPoint calls SerialPortInitialize() explicitly, > > so add SerialPortLib to its list of LibraryClasses. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > Reviewed-by: Supreeth Venkatesh > > --- > > > > StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCo > > reEntryPoint.inf | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git > > a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMm > > CoreEntryPoint.inf > > b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMm > > CoreEntryPoint.inf > > index 3222cd359f3e..769eaeeefbea 100644 > > --- > > a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMm > > CoreEntryPoint.inf > > +++ > > b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMm > > CoreEntryPoint.inf > > @@ -43,6 +43,7 @@ [Packages.AARCH64] > > [LibraryClasses] > > BaseLib > > DebugLib > > + SerialPortLib > > > > [LibraryClasses.AARCH64] > > StandaloneMmMmuLib > > -- > > 2.17.1 >