From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web12.7643.1574953481601838378 for ; Thu, 28 Nov 2019 07:04:42 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=nsI+6Va9; spf=pass (domain: linaro.org, ip: 209.85.128.65, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wm1-f65.google.com with SMTP id u18so11295168wmc.3 for ; Thu, 28 Nov 2019 07:04:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KKf7eEGa0jyLJXG8VFvefY/7BZe00vc5fF3w3LRf1aE=; b=nsI+6Va9TO95pLL5hxn+xvkp4vC7/OO7omY5LqQjwqgA8XQUt97qa8cqHu2qB9R2RI QBO3aTga8BuayZZKjoEQl2RO/c08gf4YR8V6Sk7epNtSiMkh29V4OnTZVWbZc2RctTuQ umXQscaCZaSFkco/5kxOATtjoaHcnefjLMfg2/H8dByw/YmcUNORnMfXx9Hra/q/gg/F h5AYCf34H32rUYPQNJ7IgM0LuwsE0YCxKCIhVFx/dxrvLKE52Ru1xFiGpWX12ycrHA7f Hu+i+ZJyIFUmFGTxpPavI6IimCxfpAhoU7Xh9LjNgwxp7u3eCBfjG/TPDEcqMbDh5f5b tfhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KKf7eEGa0jyLJXG8VFvefY/7BZe00vc5fF3w3LRf1aE=; b=m/DSaOpq3vnO3vn1nponla9sY0sA70lUZjG6UM61kv1InqTJ6ZbESGdBc0lbP9+mbu UBwpJDOwYdBpt1JcCCu5Yyjv0l/64cCnSTysJ1W4U+w/aWe4w4NqFyF+i85zltFAEEzQ zStQdyO/tqNA5EGLz6dSyTnNu1w+tcRKMo4xMYWo4/73vsY6pcmh90fzHY/VASW8Bjs7 EgRhD9AnOQ+cp24fFz3/5eqSZyYRybMidEgQhnBVCLgkBY7zCAwjtn1bNHj8sSDEjobK obm9d0NdnXbGaOF8Ceg9FoRpiNxPLDvHF9ONULseZrMwKo+pACW3CrPO1aoPaVdCMQsm ymQg== X-Gm-Message-State: APjAAAV6Hlg2sJlcm69Yx3TehZaRm0i612W184PzV+6HpJYs0Z3Ml1nZ LKVB6lA+CNa1dl/smlzA8amNzujkkuHF6IIvNaUm1pNx X-Google-Smtp-Source: APXvYqxpsgc3KlPsdmUJWR5EQuuJBAGoeKWpVUvvpcCP0N+yTA6dmO9efHermaBYxvu7ktgaxT7+weeR79uTQ/Aa+JE= X-Received: by 2002:a1c:49c3:: with SMTP id w186mr10072643wma.53.1574953480009; Thu, 28 Nov 2019 07:04:40 -0800 (PST) MIME-Version: 1.0 References: <20191128144840.25654-1-ard.biesheuvel@linaro.org> <20191128144840.25654-2-ard.biesheuvel@linaro.org> <20191128150157.GU7359@bivouac.eciton.net> In-Reply-To: <20191128150157.GU7359@bivouac.eciton.net> From: "Ard Biesheuvel" Date: Thu, 28 Nov 2019 16:04:29 +0100 Message-ID: Subject: Re: [PATCH edk2-platforms 2/2] Platform/DeveloperBox: disable variable runtime cache To: Leif Lindholm Cc: edk2-devel-groups-io Content-Type: text/plain; charset="UTF-8" On Thu, 28 Nov 2019 at 16:02, Leif Lindholm wrote: > > On Thu, Nov 28, 2019 at 15:48:40 +0100, Ard Biesheuvel wrote: > > The variable runtime cache for SMM enabled implementations of the > > variable runtime DXE driver was introduced after the standalone > > MM based implementation was merged for the DeveloperBox platform. > > > > This means the combined binary image of ARM Trusted Firmware and > > the standalone MM runtime we carry in edk2-non-osi predates this > > feature, so we need to disable it when building the non-secure side > > when incorporating the prebuilt binary. > > Is this something that needs to be explicitly disabled in current > upstream TF? (And if so, could we add a comment to edk2-non-osi > README?) Or does this only affect the requests made from Non-secure > side? > No, it has to be disabled on both sides. But this .dsc.inc gets included by both sides when you build them from scratch. > > Whether it makes sense to enable the runtime cache for this platform > > is a different question, so let's keep it enabled entirely until > > enabled -> disabled? > Yep > > > someone identifies a need for it. > > > > Signed-off-by: Ard Biesheuvel > > --- > > Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > > index a10e48ca07ea..084b4c994b97 100644 > > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > > @@ -130,6 +130,8 @@ [PcdsFeatureFlag] > > # needed for NFIT tables installed by RamDiskDxe > > gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE > > > > + gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariableRuntimeCache|FALSE > > + > > [PcdsFixedAtBuild.common] > > !ifdef $(FIRMWARE_VENDOR) > > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|L"$(FIRMWARE_VENDOR)" > > -- > > 2.20.1 > >