Re: [PATCH edk2-platforms] Silicon/SynQuacer: add stage 2 override translation tables for PCIe

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 27 February 2018 at 18:10, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Tue, Feb 27, 2018 at 05:45:09PM +0000, Ard Biesheuvel wrote:
>> >> > +[Sources]
>> >> > +  Stage2Tables.S
>> >> > +
>> >> > +[Packages]
>> >> > +  MdePkg/MdePkg.dec
>> >> > +  Silicon/Socionext/SynQuacer/SynQuacer.dec
>> >> > +
>> >> > +[BuildOptions]
>> >> > +  *_*_*_OBJCOPY_PATH  == objcopy
>> >> > +  *_*_*_OBJCOPY_FLAGS == -I elf64-little -O binary -j .rodata
>> >>
>> >> I can improve this and fix Clang at the same time by adding
>> >>
>> >>   *_*_*_ASM_FLAGS == -nostdlib
>> >> -Wl,-e,0x81f8000,--section-start=.rodata=0x81f8000
>> >>   *_CLANG35_*_ASM_FLAGS = -no-integrated-as
>> >>   *_CLANG38_*_ASM_FLAGS = -no-integrated-as
>> >>
>> >> (and remove the linker arguments from the Makefile)
>> >
>> > I can confirm this resolves the CLANG issue.
>> >
>> > Could we do this with a CLANG_ALL_ASM_FLAGS, rather than listing each
>> > new toolchain profile as they get added?
>>
>> No, not really. CLANG3x is not a separate toolchain family, so we can
>> apply things to GCC+CLANG combined, or to certain versions
>> individually.
>
> Ah, I had managed to miss that bit up until now. Thanks!
>
> In that case, with these latest changes:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Thanks

Pushed as f90743b8813518fd7111c272ea4a3483a94ed462