From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::243; helo=mail-it0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 205F620955F05 for ; Wed, 28 Feb 2018 01:11:53 -0800 (PST) Received: by mail-it0-x243.google.com with SMTP id c11so2657175ith.4 for ; Wed, 28 Feb 2018 01:18:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=6SK4ORTDb9hPR9L6C8vEPEiwHuKDnEAj26XWg++XN44=; b=gscZ3PxLK5Lb+nNrz2vPePMe0jrn1o6Siuffn6//uwSAxMl3AaH9eN2mkqvi4e6ZQN l5PN/UODCFIBzUIYZtSnEvG54v13NJ64qw6pTSm2K6uf0AB3VFoCKStaIs8F0i3kaKGK Y3ZYLUCaAlyd+cymZMgsJkJiplRVuGoX1fVPI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6SK4ORTDb9hPR9L6C8vEPEiwHuKDnEAj26XWg++XN44=; b=DTnQHERTfOcHBb7AWCvvLXRTCvYo90RXeaDonwaSI4OC2F7BV/SwIo+KjAjWBeGIYG egJHZVAoDFGq2QZCDK1XMQ/xq/I6YZC9n1pfKlHSxT7Suj7eDmN6ZxHi6H1YvMAUe21F yluB5Q+PHMxbhMS+EwNPYWmUDR2dxSHQniFLOjo94GeQHtEldPXED6sIpbxUPdRp7N9g GuahcfQLVA+U4y3Rf5ygpGViZ6wVH32omTNVEKTVLWq06ChjyPJDM/cz5rV4FdzZ2F1D rpNnY2xITm8HWV/t4zejhgea9DmJC0I+6ImYgwxG2yEQ9eQnRN1jXu3gPoAEcrArPvqJ cFqg== X-Gm-Message-State: APf1xPA46b2GtMb/8aEBX3IoAF/D2a72wT9usLzsnLpQIVCaJg4lATr7 Z+705WvXOGAVUw+ePuJ4pxq8cBgLsFCe7FedN3umuA== X-Google-Smtp-Source: AH8x224/zyVU6v84wAJrdKpZLkvCLxORox88HKu6THRXjsoIJAopL1V+pmP2a9/lXWwqG3nWOq8RVCbS78xMI923O7w= X-Received: by 10.36.91.138 with SMTP id g132mr20155115itb.50.1519809480506; Wed, 28 Feb 2018 01:18:00 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.138.209 with HTTP; Wed, 28 Feb 2018 01:18:00 -0800 (PST) In-Reply-To: <20180227181023.laplmremvchew535@bivouac.eciton.net> References: <20180227134747.13238-1-ard.biesheuvel@linaro.org> <20180227173640.vavijseacrm5wnau@bivouac.eciton.net> <20180227181023.laplmremvchew535@bivouac.eciton.net> From: Ard Biesheuvel Date: Wed, 28 Feb 2018 09:18:00 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH edk2-platforms] Silicon/SynQuacer: add stage 2 override translation tables for PCIe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Feb 2018 09:11:54 -0000 Content-Type: text/plain; charset="UTF-8" On 27 February 2018 at 18:10, Leif Lindholm wrote: > On Tue, Feb 27, 2018 at 05:45:09PM +0000, Ard Biesheuvel wrote: >> >> > +[Sources] >> >> > + Stage2Tables.S >> >> > + >> >> > +[Packages] >> >> > + MdePkg/MdePkg.dec >> >> > + Silicon/Socionext/SynQuacer/SynQuacer.dec >> >> > + >> >> > +[BuildOptions] >> >> > + *_*_*_OBJCOPY_PATH == objcopy >> >> > + *_*_*_OBJCOPY_FLAGS == -I elf64-little -O binary -j .rodata >> >> >> >> I can improve this and fix Clang at the same time by adding >> >> >> >> *_*_*_ASM_FLAGS == -nostdlib >> >> -Wl,-e,0x81f8000,--section-start=.rodata=0x81f8000 >> >> *_CLANG35_*_ASM_FLAGS = -no-integrated-as >> >> *_CLANG38_*_ASM_FLAGS = -no-integrated-as >> >> >> >> (and remove the linker arguments from the Makefile) >> > >> > I can confirm this resolves the CLANG issue. >> > >> > Could we do this with a CLANG_ALL_ASM_FLAGS, rather than listing each >> > new toolchain profile as they get added? >> >> No, not really. CLANG3x is not a separate toolchain family, so we can >> apply things to GCC+CLANG combined, or to certain versions >> individually. > > Ah, I had managed to miss that bit up until now. Thanks! > > In that case, with these latest changes: > Reviewed-by: Leif Lindholm > Thanks Pushed as f90743b8813518fd7111c272ea4a3483a94ed462