From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Liming Gao <liming.gao@intel.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [edk2-platform patch 1/7] BeagleBoardPkg: Update BeagleBoardPkg.dsc to remove unnecessary Network libs
Date: Mon, 10 Jun 2019 10:03:19 +0200 [thread overview]
Message-ID: <CAKv+Gu_O5mPJ8t=bjdatqdbYj02q78acoDZxAN74WxvXk7CUZw@mail.gmail.com> (raw)
In-Reply-To: <20190528095853.16476-2-liming.gao@intel.com>
On Tue, 28 May 2019 at 12:00, Liming Gao <liming.gao@intel.com> wrote:
>
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
Beagle is completely broken at the moment, so I will propose some
patches to fix it.
> ---
> Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> index 2d5d6f9977..7c7762e3ec 100644
> --- a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> +++ b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> @@ -116,7 +116,7 @@
> DebugAgentLib|MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.inf
> DmaLib|EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.inf
>
> - NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf
> + !include NetworkPkg/NetworkLibs.dsc.inc
The Shell is the only user of NetLib on this platforms, so I prefer to
add a reference to NetworkPkg's DxeNetlib locally, to the
<LibraryClasses> section of the Shell .inf.
I will follow up myself - no need to resend.
> FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
>
> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> --
> 2.13.0.windows.1
>
next prev parent reply other threads:[~2019-06-10 8:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 9:58 [edk2-platform patch 0/7] Clean up Platform DSC/FDF to refer to NetworkPkg Liming Gao
2019-05-28 9:58 ` [edk2-platform patch 1/7] BeagleBoardPkg: Update BeagleBoardPkg.dsc to remove unnecessary Network libs Liming Gao
2019-06-10 8:03 ` Ard Biesheuvel [this message]
2019-05-28 9:58 ` [edk2-platform patch 2/7] RDKQemu: Update RDKQemu.dsc " Liming Gao
2019-06-10 9:06 ` [edk2-devel] " Ard Biesheuvel
2019-05-28 9:58 ` [edk2-platform patch 3/7] Hisilicon: Update D06.dsc " Liming Gao
2019-06-10 10:49 ` Ard Biesheuvel
2019-05-28 9:58 ` [edk2-platform patch 4/7] QuarkPlatform: Update Quark dsc " Liming Gao
2019-05-28 9:58 ` [edk2-platform patch 5/7] Vlv2TbltDevicePkg: Update Platform " Liming Gao
2019-05-28 10:04 ` [edk2-devel] " Sun, Zailiang
2019-05-28 9:58 ` [edk2-platform patch 6/7] RaspberryPi: Update RPi3 DSC/FDF to refer to Network package segment files Liming Gao
2019-05-28 9:58 ` [edk2-platform patch 7/7] SoftIron: Update Overdrive1000Board.dsc to refer to new Network module path Liming Gao
2019-06-10 10:41 ` Ard Biesheuvel
2019-05-28 10:05 ` [edk2-devel] [edk2-platform patch 0/7] Clean up Platform DSC/FDF to refer to NetworkPkg Ard Biesheuvel
2019-05-28 11:03 ` Liming Gao
2019-05-28 11:11 ` Ard Biesheuvel
2019-05-28 11:44 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu_O5mPJ8t=bjdatqdbYj02q78acoDZxAN74WxvXk7CUZw@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox