From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=MZvnPSrI; spf=pass (domain: linaro.org, ip: 209.85.166.194, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-it1-f194.google.com (mail-it1-f194.google.com [209.85.166.194]) by groups.io with SMTP; Mon, 10 Jun 2019 01:03:32 -0700 Received: by mail-it1-f194.google.com with SMTP id j204so11774478ite.4 for ; Mon, 10 Jun 2019 01:03:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8JcP3rMDxxhjht6BG+x52zKOwXyBEFMOpaynel+IzuM=; b=MZvnPSrIAR5qhuo3yF6N81mudpYbc6sHNlP/5gqErDKikRBzIZ25hMuwEBx57gSOge XTi1cd6j0pmpNr480MAJBQUFlOWPmKEQ+Ww5lhJHSCsEgx6ttaYDpB59dx39t+AISOJ3 EDCkUcwwEKe+x/rSJZ+Rb1w0m9MFaQn5Pgk1+iqRoahru8PfNF+f6uHaT53WmirYOBRg yDRToch8qKVxGTTjJgu59Cjzyi3HsRUmyAYxiD5xYZClitk3Nrj3f64sZdADNkkbDRt8 3daP9B+iv7Qf8NWB/XlO2MWIbW5zvaGqZsrDz1znmN8sxul+g90pgI33xBfMMcGLOv3z jrUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8JcP3rMDxxhjht6BG+x52zKOwXyBEFMOpaynel+IzuM=; b=hFjiSWnRrthReQmqT4Ufo3B8pjmn1RXq4ukVKGcm6T4Pudrc4qO58bqCXH+eUjfScj 3sBV1qzARqEnT+2Qtr49iAa1t5fyAe7IEChpG2KlULjO+pvgGa7NljQutxAKSYkwbklM +RCtLpoE1FUmerP+fzcaoith62qF2A7CBPC+sRrEuYA+5zQifvQcSEomhlMKCNatNvN9 ewJUMFs3LM3Cw5v92Js+Mu5sys4B4IHoVusBqDZZxgaT8OCt0orZHE1hZw3rZe+tJHyb qPvvsRvg5RUMbe9LYTXNtcmEQU5dJWk4d52rXTVDAqyDHlEv+9j0WOofMVJRVN5kQuLb hvFQ== X-Gm-Message-State: APjAAAV6rr/NsgHwQbxXRbjL84n5F62usi8RpFlZWWUfN2Dfv0WlokXZ cKOc9Hy+9b3I2zWrVWt2r+56WRLaaKJSJ050gijVOQ== X-Google-Smtp-Source: APXvYqxlm0KrJbp+9Wwplm+kw5r2mUPltZ0T0dkSjlDrMLPMhTQOITQJoXY79dYvGEsrZxlprTzbHWn8MrYCoSdZjCc= X-Received: by 2002:a24:740f:: with SMTP id o15mr14207206itc.76.1560153811305; Mon, 10 Jun 2019 01:03:31 -0700 (PDT) MIME-Version: 1.0 References: <20190528095853.16476-1-liming.gao@intel.com> <20190528095853.16476-2-liming.gao@intel.com> In-Reply-To: <20190528095853.16476-2-liming.gao@intel.com> From: "Ard Biesheuvel" Date: Mon, 10 Jun 2019 10:03:19 +0200 Message-ID: Subject: Re: [edk2-platform patch 1/7] BeagleBoardPkg: Update BeagleBoardPkg.dsc to remove unnecessary Network libs To: Liming Gao Cc: edk2-devel-groups-io , Leif Lindholm Content-Type: text/plain; charset="UTF-8" On Tue, 28 May 2019 at 12:00, Liming Gao wrote: > > Signed-off-by: Liming Gao > Cc: Ard Biesheuvel > Cc: Leif Lindholm Beagle is completely broken at the moment, so I will propose some patches to fix it. > --- > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > index 2d5d6f9977..7c7762e3ec 100644 > --- a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > +++ b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > @@ -116,7 +116,7 @@ > DebugAgentLib|MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.inf > DmaLib|EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.inf > > - NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf > + !include NetworkPkg/NetworkLibs.dsc.inc The Shell is the only user of NetLib on this platforms, so I prefer to add a reference to NetworkPkg's DxeNetlib locally, to the section of the Shell .inf. I will follow up myself - no need to resend. > FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf > > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > -- > 2.13.0.windows.1 >