From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x236.google.com (mail-it0-x236.google.com [IPv6:2607:f8b0:4001:c0b::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E23551A1F52 for ; Thu, 8 Sep 2016 01:19:21 -0700 (PDT) Received: by mail-it0-x236.google.com with SMTP id i184so243248223itf.1 for ; Thu, 08 Sep 2016 01:19:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=32WjyZuNUs43pBfSn+W7LygwGMKwF0aKLb1wMFPy0vI=; b=a7J8gqcKCqVfkfp3v/rXAcsk56sHfa7ng7nduYV9wpye3qDlr3Tg6NEKviNsL48wfH 9Y4rhfaH2QLsbtyWBR7aY9wcGMegNJzRrJ7DOPX1dGuA8uL+rIfKZTdHVzMQfhZPySX/ EgHS61ggOYZq+a5hy/X2oKUQKIQqx6JGO0OLA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=32WjyZuNUs43pBfSn+W7LygwGMKwF0aKLb1wMFPy0vI=; b=MMBs8X8Inr8ndMH4zHkLdvBTi6P2qtY050iwcjlCtY0sbLR1QOFdpFsdob9M4lAH+p 0NWaEGChhqReT0RBEAzRVG0KeDrDjUIPksxXF0RZfbe/pct3hB6kwvqoMhA2K29wE8WD Dqu7S3Q0gQGTNlv6S/fQPFpPEaufvRrqoXAjYoThymbJfbvzh4e2lS1Txsvl/+sj080m vs4eZlaSi8PcYmsHALZ2DWva+AkX0txeU/5cogkewl8/uACtvKLBWH42maFtGwDY2LLr iayGpM0Eml8tjCP21Ccmz4H3rLLFKEYsekFsAhchzTJQnQuz2bnPzswRbMYaWhiPCbdB 3FfA== X-Gm-Message-State: AE9vXwPGCuKt5upqSPxm0lIuQRzYgBahVvFMhYSJf7br1TkpivpXIGZIIgDfYjFSaZDKveP55F9Hv+9+LsXxtLIb X-Received: by 10.36.214.193 with SMTP id o184mr14227715itg.5.1473322761188; Thu, 08 Sep 2016 01:19:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Thu, 8 Sep 2016 01:19:20 -0700 (PDT) In-Reply-To: <1473073566-1504-4-git-send-email-ard.biesheuvel@linaro.org> References: <1473073566-1504-1-git-send-email-ard.biesheuvel@linaro.org> <1473073566-1504-4-git-send-email-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Thu, 8 Sep 2016 09:19:20 +0100 Message-ID: To: edk2-devel-01 , Leif Lindholm , Laszlo Ersek Cc: Ard Biesheuvel Subject: Re: [PATCH 3/5] ArmVirtPkg: remove all ArmLib resolutions with ArmBaseLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2016 08:19:22 -0000 Content-Type: text/plain; charset=UTF-8 On 5 September 2016 at 12:06, Ard Biesheuvel wrote: > The various ArmLib flavors are identical in practice, and a new > ArmBaseLib has been introduced that can replace all of them. So replace > all occurrences with ArmBaseLib. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > ArmVirtPkg/ArmVirtQemu.dsc | 9 +-------- > ArmVirtPkg/ArmVirtQemuKernel.dsc | 6 +----- > ArmVirtPkg/ArmVirtXen.dsc | 12 +----------- > 3 files changed, 3 insertions(+), 24 deletions(-) > > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > index c503ef243f9a..a3beb4654072 100644 > --- a/ArmVirtPkg/ArmVirtQemu.dsc > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > @@ -39,14 +39,13 @@ [Defines] > !include ArmVirtPkg/ArmVirt.dsc.inc > > [LibraryClasses.AARCH64] > - ArmLib|ArmPkg/Library/ArmLib/AArch64/AArch64Lib.inf > ArmCpuLib|ArmPkg/Drivers/ArmCpuLib/ArmCortexAEMv8Lib/ArmCortexAEMv8Lib.inf > > [LibraryClasses.ARM] > - ArmLib|ArmPkg/Library/ArmLib/ArmV7/ArmV7Lib.inf > ArmCpuLib|ArmPkg/Drivers/ArmCpuLib/ArmCortexA15Lib/ArmCortexA15Lib.inf > > [LibraryClasses.common] > + ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf > ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > > # Virtio Support > @@ -75,12 +74,6 @@ [LibraryClasses.common] > [LibraryClasses.common.UEFI_DRIVER] > UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf > > -[LibraryClasses.AARCH64.SEC] > - ArmLib|ArmPkg/Library/ArmLib/AArch64/AArch64LibSec.inf > - > -[LibraryClasses.ARM.SEC] > - ArmLib|ArmPkg/Library/ArmLib/ArmV7/ArmV7LibSec.inf > - > [BuildOptions] > RVCT:*_*_ARM_PLATFORM_FLAGS == --cpu Cortex-A15 -I$(WORKSPACE)/ArmVirtPkg/Include > GCC:*_*_ARM_PLATFORM_FLAGS == -mcpu=cortex-a15 -I$(WORKSPACE)/ArmVirtPkg/Include > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc > index 383d9b7d2c0b..e0dcf4300338 100644 > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc > @@ -38,17 +38,13 @@ [Defines] > !include ArmVirtPkg/ArmVirt.dsc.inc > > [LibraryClasses.AARCH64] > - ArmLib|ArmPkg/Library/ArmLib/AArch64/AArch64Lib.inf > ArmCpuLib|ArmPkg/Drivers/ArmCpuLib/ArmCortexAEMv8Lib/ArmCortexAEMv8Lib.inf > > [LibraryClasses.ARM] > - ArmLib|ArmPkg/Library/ArmLib/ArmV7/ArmV7Lib.inf > ArmCpuLib|ArmPkg/Drivers/ArmCpuLib/ArmCortexA15Lib/ArmCortexA15Lib.inf > > -[LibraryClasses.ARM.SEC] > - ArmLib|ArmPkg/Library/ArmLib/ArmV7/ArmV7LibSec.inf > - > [LibraryClasses.common] > + ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf > ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > > # Virtio Support > diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc > index 191b615785d3..3422d1e5d996 100644 > --- a/ArmVirtPkg/ArmVirtXen.dsc > +++ b/ArmVirtPkg/ArmVirtXen.dsc > @@ -37,17 +37,13 @@ [LibraryClasses] > XenHypercallLib|OvmfPkg/Library/XenHypercallLib/XenHypercallLib.inf > > [LibraryClasses.AARCH64] > - ArmLib|ArmPkg/Library/ArmLib/AArch64/AArch64Lib.inf > ArmCpuLib|ArmPkg/Drivers/ArmCpuLib/ArmCortexAEMv8Lib/ArmCortexAEMv8Lib.inf > > [LibraryClasses.ARM] > - ArmLib|ArmPkg/Library/ArmLib/ArmV7/ArmV7Lib.inf > ArmCpuLib|ArmPkg/Drivers/ArmCpuLib/ArmCortexA15Lib/ArmCortexA15Lib.inf > > -[LibraryClasses.ARM.SEC] > - ArmLib|ArmPkg/Library/ArmLib/ArmV7/ArmV7LibSec.inf > - > [LibraryClasses.common] > + ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf > ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > > # Virtio Support > @@ -69,12 +65,6 @@ [LibraryClasses.common] > [LibraryClasses.common.UEFI_DRIVER] > UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf > > -[LibraryClasses.AARCH64.SEC] > - ArmLib|ArmPkg/Library/ArmLib/AArch64/AArch64LibPrePi.inf > - > -[LibraryClasses.ARM.SEC] > - ArmLib|ArmPkg/Library/ArmLib/ArmV7/ArmV7LibPrePi.inf > - > [BuildOptions] > RVCT:*_*_ARM_PLATFORM_FLAGS == --cpu Cortex-A15 -I$(WORKSPACE)/ArmVirtPkg/Include > GCC:*_*_ARM_PLATFORM_FLAGS == -mcpu=cortex-a15 -I$(WORKSPACE)/ArmVirtPkg/Include > -- > 2.7.4 > Laszlo, Any objections? Thanks, Ard.