From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::233; helo=mail-io0-x233.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x233.google.com (mail-io0-x233.google.com [IPv6:2607:f8b0:4001:c06::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 66F0A203525EC for ; Thu, 26 Oct 2017 08:37:23 -0700 (PDT) Received: by mail-io0-x233.google.com with SMTP id 134so6323824ioo.0 for ; Thu, 26 Oct 2017 08:41:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0u5cae6MZli6aS1tedivEY4tZ3PkE/ofKq48R5jfV3Y=; b=alLE6x89eZM5HPUQiaFTYiKYUN0wN6QR1gYElpR3mNkVpDVHhnRic8WoVxytZNPO+Q ba+GJ0P+FYVBT+B4LXU/UIhJDU1Fd7OU2L28LFFKqUP7vCe21cvNe6oYcXENJKa2Pmbm KlSis0/j64U31zw0J3AVNytk50ven0tJ+qUoU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0u5cae6MZli6aS1tedivEY4tZ3PkE/ofKq48R5jfV3Y=; b=bbWXe4/H8OXz2t/tSuYyDZI3hQttjrPnj5wSgLbUE0EaJpBA+qQ4eL9tPj8KlzKadD z1zbL6oPWaCGp1vin01oxdoWAqed739OWzWhDS9EjBKcLUrQ/4MahOakpsKgJNdMmfRi TqQKENLGN8j0in4Y0qO+ux604UMJ8JbvYu8it0JLpFGx1R0OjrgyYW+C2kL5q2hL37ge ArL2FnvrPewRnZ3a6ja8Uc4OoSzLChDUGi9770ledF3K6iXysN9+u3MA/YqvkwcSXHO5 7JnB0TP0jORT3FgH/Erm5wC7fdKfUzl5L+8asoeDjYZitQG7SWCgQkkPy7Xi+lOLOx74 +dtw== X-Gm-Message-State: AMCzsaUi6PLcXPl5g4PcBK07cbXf4zFtl/RvgU3aD0svrxv6WRgs9uAF vyn+S/FiVX9+W1o6n2re1rST4/xlwNHcMDcsAxXt0Q== X-Google-Smtp-Source: ABhQp+Rii4Fp3OwykQk+f+L9QNE/n4fdiEyKyJMvVnxo5jWJLcpLuSBFUaNW6LyHaZ4tvk3Q3FZ7E+jGngBrmiUBPkU= X-Received: by 10.107.142.208 with SMTP id q199mr31956970iod.186.1509032468946; Thu, 26 Oct 2017 08:41:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.51.131 with HTTP; Thu, 26 Oct 2017 08:41:07 -0700 (PDT) In-Reply-To: <20171026153832.cb742vrzkj7eeq2s@bivouac.eciton.net> References: <20171025175947.22798-1-ard.biesheuvel@linaro.org> <20171025175947.22798-9-ard.biesheuvel@linaro.org> <20171026153832.cb742vrzkj7eeq2s@bivouac.eciton.net> From: Ard Biesheuvel Date: Thu, 26 Oct 2017 16:41:07 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Daniel Thompson , Masami Hiramatsu Subject: Re: [PATCH edk2-platforms v2 08/23] Platform/SynQuacerEvalBoard: add PCI support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2017 15:37:23 -0000 Content-Type: text/plain; charset="UTF-8" On 26 October 2017 at 16:38, Leif Lindholm wrote: > On Wed, Oct 25, 2017 at 06:59:32PM +0100, Ard Biesheuvel wrote: >> Wire up the various drivers and libraries for the SynQuacerEvalBoard >> platform. Also enable the usual PCI suspects: XHCI, SATA and NVME, >> and the various bus, partition and file system drivers that we need >> to make use of PCIe devices. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel > > Comments unaddressed from v1: > - If you're folding ChaosKey driver in here (as you are) it deserves a > mention in the commit message. Ack > - Is there a good reason for leaving out Uhci/Ehci? > No not really, other than the fact that nobody is every likely to use it (although I suppose you could put a UHCI PCI card into a PCIe to PCI bridge) I will add them.