From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 560BE222CB329 for ; Fri, 22 Dec 2017 07:29:10 -0800 (PST) Received: by mail-io0-x242.google.com with SMTP id i143so4837160ioa.3 for ; Fri, 22 Dec 2017 07:34:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=mTUTrm8kn4991yXnUyerMk2yF6WLTbWc1RmDQIb4Bk0=; b=N4BPxcBgEqeIKyKcF8ECeLy8BXktvf3AABNzMXY/gBO3HMQCksk/bbHCxhvyxnRjeC fWzuuinqjLtdZCRSC+jtHOjer7U3xqHVVffbtLFsf+Hi5fa1cFUdqwxpzojrW9w/ZECx AJOpw4Zxe3ZXN78SCvnAbNTxTl3HEBDeBpdXg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=mTUTrm8kn4991yXnUyerMk2yF6WLTbWc1RmDQIb4Bk0=; b=mUo3dHMPwA169nchXPs6RtnAvcZrEQgqDOLPL3Z4JOKLxt5/17HtkiI8/7U4FP+VOM Ri+zASJtLrIVnreTz3PHYyWbnMoOOiXqE8xXMo/FrQyeZhtHVcF8oiOYKUwQLdVVfBou 5jmUvggXS4QX1nsGdKWXpApEUp9fSmHDXK7GnIWytRzt07emrDg1VAaGdjG/onU3QHc4 dxlENMK6DWWoYgVyd9VCfTob3TweWzenSBrcZLveonYKDjk6J2MyXIbloV1+VOtnMOWU 0w5FXYJ92ggNlXu7Qcz8GlrX/4qwB8joWEFoI9JZ4FlsH/KxPjxuLaAvtrlwo3GNsIRr aY9g== X-Gm-Message-State: AKGB3mIRTC5ooB+aXo61gjcGQOmAJd4xGStKQTiyRyJGH324XoldIly6 M9a+4mZjVW7gEF1RfIGWiNYc/CqcP1rxKWmj16PNPg== X-Google-Smtp-Source: ACJfBotDusJST28cwYFEaWDk+5Bx8zOsvuEp6Dug9AniFJE3yfAAo6h9haxSTIGOhxMLgJuCmgb4AQ4m8/aFQTUDr9Q= X-Received: by 10.107.27.84 with SMTP id b81mr18023524iob.43.1513956839707; Fri, 22 Dec 2017 07:33:59 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.52.14 with HTTP; Fri, 22 Dec 2017 07:33:59 -0800 (PST) In-Reply-To: <1513882109-14295-1-git-send-email-vabhav.sharma@nxp.com> References: <1513882109-14295-1-git-send-email-vabhav.sharma@nxp.com> From: Ard Biesheuvel Date: Fri, 22 Dec 2017 15:33:59 +0000 Message-ID: To: Vabhav Cc: Leif Lindholm , "Kinney, Michael D" , "edk2-devel@lists.01.org" , Udit Kumar , Varun Sethi Subject: Re: [PATCH edk2-platforms 0/3] Platform/NXP-Added NXP PCI Host Bridge Driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Dec 2017 15:29:10 -0000 Content-Type: text/plain; charset="UTF-8" On 21 December 2017 at 18:48, Vabhav wrote: > Following patches will add support of NXP PCI Host Bridge Driver in edk2-platforms directory 'edk2-platforms/Platform/NXP' > Why do you need a new PciHostBridgeDxe driver? Can't you use the one in MdeModulePkg instead? > Updated Directory structure for added folders in 'edk2-platforms/Platform/NXP' will be: > > Platform/NXP/Drivers/PciHostBridgeDxe/ > |-- PciHostBridgeDxe.c > |-- PciHostBridgeDxe.inf > `-- PciRootBridgeIo.c > > Platform/NXP/Library/PciHostBridgeLib/ > |-- PciCntrl.c > |-- PciHostBridgeLib.inf > `-- PciRbLib.c > Please put these in Silicon/NXP, not Platform/NXP > In Platform/NXP/Library > PciHostBridgeLib librady is added > > In Platform/NXP/Drivers: > PciHostBridgeDxe driver is added > > Please review and look forward for your support in upstreaming the patches in edk2-platforms. > > Vabhav (3): > Platform/NXP : Add PCI Host Bridge Libary > Platform/NXP : Add PCI Host Bridge Driver > Compilation:Modify dsc,fdf files > > .../Drivers/PciHostBridgeDxe/PciHostBridgeDxe.c | 967 ++++++++++++++++ > .../Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf | 61 + > .../NXP/Drivers/PciHostBridgeDxe/PciRootBridgeIo.c | 1193 ++++++++++++++++++++ > Platform/NXP/Include/PciCntrlLib.h | 323 ++++++ > Platform/NXP/Include/PciHostBridge.h | 466 ++++++++ > Platform/NXP/Include/PciLib.h | 414 +++++++ > Platform/NXP/Include/PciRootBridge.h | 674 +++++++++++ > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 31 + > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 6 + > Platform/NXP/Library/PciHostBridgeLib/PciCntrl.c | 628 +++++++++++ > .../Library/PciHostBridgeLib/PciHostBridgeLib.inf | 49 + > Platform/NXP/Library/PciHostBridgeLib/PciRbLib.c | 331 ++++++ > Silicon/NXP/Chassis/Chassis.c | 11 + > Silicon/NXP/Chassis/Chassis2/SerDes.h | 11 + > Silicon/NXP/LS1043A/LS1043A.dsc | 1 + > 15 files changed, 5166 insertions(+) > create mode 100644 Platform/NXP/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.c > create mode 100644 Platform/NXP/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf > create mode 100644 Platform/NXP/Drivers/PciHostBridgeDxe/PciRootBridgeIo.c > create mode 100644 Platform/NXP/Include/PciCntrlLib.h > create mode 100644 Platform/NXP/Include/PciHostBridge.h > create mode 100644 Platform/NXP/Include/PciLib.h > create mode 100644 Platform/NXP/Include/PciRootBridge.h > create mode 100644 Platform/NXP/Library/PciHostBridgeLib/PciCntrl.c > create mode 100644 Platform/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.inf > create mode 100644 Platform/NXP/Library/PciHostBridgeLib/PciRbLib.c > > -- > 1.9.1 >