Re: [PATCH v3 2/7] ArmPkg/ArmSoftFloatLib: switch to new version of softfloat library

["Ard Biesheuvel" <ard.biesheuvel@linaro.org>]

On Fri, 31 May 2019 at 15:49, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Fri, May 31, 2019 at 03:39:33PM +0200, Ard Biesheuvel wrote:
> > On Fri, 31 May 2019 at 15:26, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > >
> > > On Fri, May 31, 2019 at 03:22:25PM +0200, Ard Biesheuvel wrote:
> > > > > > +  GCC:*_*_*_CC_FLAGS = -fno-lto -ffreestanding -Wno-unused-label
> > > > >
> > > > > Hmm. You add -ffreestanding here, but you also add it to the CLANG
> > > > > profiles in 4/7. Could we do one of:
> > > > > - dropping this one, adding -ffreestanding to GCC profiles too in 4/7
> > > > > - keeping this one, dropping the -ffreestanding from 4/7?
> > > > >
> > > >
> > > > In my opinion, we should be using -ffreestanding for all GCC family
> > > > toolchains for all architectures.
> > >
> > > I agree. Could you update 4/7 to do that, and add RVCT droppage to
> > > commit message for this one?
> >
> > Jian was looking into making OpenSSL 1.1.1b compile with CLANG for x86
> > as well, so I'd rather not interfere with that.
>
> Raise a BZ and drop the -ffreestanding from one of these patches?
>

As it turns out, Jian's v5 takes care of this already (and the
-ffreestanding is not actually required when building against OpenSSL
1.1.1b rather than the current version)

So I will update the commit log of this patch to mention RVCT and drop
4/7, and merge the series by the end of today.