From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=kmkog2lC;
 spf=pass (domain: linaro.org, ip: 209.85.166.195, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-it1-f195.google.com (mail-it1-f195.google.com [209.85.166.195])
 by groups.io with SMTP; Fri, 31 May 2019 07:32:51 -0700
Received: by mail-it1-f195.google.com with SMTP id s16so15573940ita.2
        for <devel@edk2.groups.io>; Fri, 31 May 2019 07:32:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=RvsybVaUyNxas+gzJ5JpV/QwOG6kNZ6oQnrOZ94/rtg=;
        b=kmkog2lCVzeGvL68D59JnRns4vov/Fv9bhm8X2/ZhITYagTY6rakXuZMHtLokdGEyA
         WDqLqbiJg6bIxEKDOZVFzWbrZQreEE5TzrouTIJVE5hc+H2YHkkLQqYvcWiXPAnqSoi+
         5QIs1zgsTYoYBaKly5c+Evmf8rK8hocRtOFcDxh0x3R6umhVK9uDlvDIT+tAAxxAit8+
         6UZc3DpwRQ9RGXBHxiTdg2BLQT7GDub/aU4M95qoND4AcsJTp+YWYyroz92us/VRcAv5
         uGh7VR+hVm24T4xCVbySlaFwruKxaLSpv3bY3JF0EVIJQTeiqdv+0cxJRwEKoVKEthhd
         Jk9g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=RvsybVaUyNxas+gzJ5JpV/QwOG6kNZ6oQnrOZ94/rtg=;
        b=HHAL9jCptpHIq5BLdtEJ4sZqs7OE9OkPygoUozBEYZ40+YQ2KSK1h2HjvIXrNofG7N
         2EO5+pZ1Fd7CbtR5CfOoLfQSJpKkEdmD53Me5iCP2U0MOm3wE4gVo67gGYot9xzhPDWl
         K2AjjKArN6zhLCJ5FxFTYDgl9kxuprqHt+iYAUvwMJX0dL/RFNIuXREFaaf7700kwepE
         TRDh91ktFSoBZz8Xuu+TOw47YN/Ae4hWJyC+3xn6TLwl4D+Qy1qcFcXPkU1J+kPUhEH1
         gO+K6r3Br/p8FOEr+A2V1KB0VZD2jqDvt7Q66za7wlvlZpfVKI6TrNJxUA1AtWS5RFhl
         GLSg==
X-Gm-Message-State: APjAAAXjo8hi1wrW+8MeyqlTLLLVNTLyUL9q1DGrxChHcUZNupD4aNtJ
	kNNuv1KErn/c8R63lM93rtr3GBag2Zk8+WmV6c+kkQ==
X-Google-Smtp-Source: APXvYqwg4UhpEwnM1bRddK1QJ8FSguPz+oqXigMXa+aIutnrZ12YvS7/GvTaO7/yi5DbiLcOBYjnxvYHF0qJWldgMbY=
X-Received: by 2002:a02:b01c:: with SMTP id p28mr7085845jah.130.1559313170954;
 Fri, 31 May 2019 07:32:50 -0700 (PDT)
MIME-Version: 1.0
References: <20190531124958.8421-1-ard.biesheuvel@linaro.org>
 <20190531124958.8421-3-ard.biesheuvel@linaro.org> <20190531132055.zsbratmpugwaqxd2@bivouac.eciton.net>
 <CAKv+Gu95S4YM_pgdQkYoLTEE2B6mBe4gytcJ5LvdFmgKk3VDpQ@mail.gmail.com>
 <20190531132607.icin5xymyu7v3jme@bivouac.eciton.net> <CAKv+Gu8qfMmfR=rR9aAshewuQu2PLN8Mki6Br48XNwJHWJVgOQ@mail.gmail.com>
 <20190531134948.ffcifmhevf7fej76@bivouac.eciton.net>
In-Reply-To: <20190531134948.ffcifmhevf7fej76@bivouac.eciton.net>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Fri, 31 May 2019 16:32:38 +0200
Message-ID: <CAKv+Gu_P0vaWrhdtmwv5dXsa5M4UMxzvojVLjtu=vssH1BqWww@mail.gmail.com>
Subject: Re: [PATCH v3 2/7] ArmPkg/ArmSoftFloatLib: switch to new version of softfloat library
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Laszlo Ersek <lersek@redhat.com>, 
	"Gao, Liming" <liming.gao@intel.com>, "Wang, Jian J" <jian.j.wang@intel.com>, 
	Michael D Kinney <michael.d.kinney@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Fri, 31 May 2019 at 15:49, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Fri, May 31, 2019 at 03:39:33PM +0200, Ard Biesheuvel wrote:
> > On Fri, 31 May 2019 at 15:26, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > >
> > > On Fri, May 31, 2019 at 03:22:25PM +0200, Ard Biesheuvel wrote:
> > > > > > +  GCC:*_*_*_CC_FLAGS = -fno-lto -ffreestanding -Wno-unused-label
> > > > >
> > > > > Hmm. You add -ffreestanding here, but you also add it to the CLANG
> > > > > profiles in 4/7. Could we do one of:
> > > > > - dropping this one, adding -ffreestanding to GCC profiles too in 4/7
> > > > > - keeping this one, dropping the -ffreestanding from 4/7?
> > > > >
> > > >
> > > > In my opinion, we should be using -ffreestanding for all GCC family
> > > > toolchains for all architectures.
> > >
> > > I agree. Could you update 4/7 to do that, and add RVCT droppage to
> > > commit message for this one?
> >
> > Jian was looking into making OpenSSL 1.1.1b compile with CLANG for x86
> > as well, so I'd rather not interfere with that.
>
> Raise a BZ and drop the -ffreestanding from one of these patches?
>

As it turns out, Jian's v5 takes care of this already (and the
-ffreestanding is not actually required when building against OpenSSL
1.1.1b rather than the current version)

So I will update the commit log of this patch to mention RVCT and drop
4/7, and merge the series by the end of today.