From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x229.google.com (mail-io0-x229.google.com [IPv6:2607:f8b0:4001:c06::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8217021E95E00 for ; Wed, 30 Aug 2017 03:49:46 -0700 (PDT) Received: by mail-io0-x229.google.com with SMTP id d78so2330336ioe.4 for ; Wed, 30 Aug 2017 03:52:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=90TXCsQ4pk+r5tS9Jh97rSb9TlYSYTitLY6UFyXtYbM=; b=O+HQuWQOLxdPuw+ed4rMGcMl0Qv/ZqW2JS4hl+jSE5W1ITwn1EOzDc8wBeB96IUNIE BSIbLLvANamy+HgNchWwvXcR06ULezZVnX1lxUR1GIdcf42XAxEGbzi2eG9hiGmolo3G EF1dObGM2jKXJRPinxiZnzQrmU+7ADm3VF6No= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=90TXCsQ4pk+r5tS9Jh97rSb9TlYSYTitLY6UFyXtYbM=; b=WZqZYTJrxq8Fd6ryJ4rePBWbInfqH5Xyw/H+GOqkiTywmKHZD0T8Lwh+SXmVXCvAV4 37L12zV9Yy5sNi0nLd5KdqwhW7PeOMXtPYhP979qPz91uiISwkeSr0M4hvBRb7X5Z+VM mNJYoC3yDACZUN1/7sahrh5L+5FVv4niZa4PknT+r3NyxOY6ADhYzxrJi3NBtTMes9UB dyBhH1eJMmCgqRNlkcnZpvec6xAK04JWkFUtYlD3BRcqgTCJR+ZeCrVH37hqjixaV59y lLQTTCxLZHoAdET+jMtRI4tsRvEHoXZ//vdPXZ1WM9q74aFupbDFNOwwQ5Zrk4bgpznk 6XKQ== X-Gm-Message-State: AHPjjUjLvvS0ntoXzH6xJNPCJCnKE4ESslMKM1eC19Q3j+anSAsECOJa UrH7TEJ3Rb69iZDcDgHeURhec5skR8jT X-Received: by 10.107.157.78 with SMTP id g75mr896681ioe.190.1504090347387; Wed, 30 Aug 2017 03:52:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Wed, 30 Aug 2017 03:52:26 -0700 (PDT) In-Reply-To: <20170830104654.345w3oo4u7fiag6d@bivouac.eciton.net> References: <20170830082108.7470-1-ard.biesheuvel@linaro.org> <20170830082108.7470-2-ard.biesheuvel@linaro.org> <20170830104654.345w3oo4u7fiag6d@bivouac.eciton.net> From: Ard Biesheuvel Date: Wed, 30 Aug 2017 11:52:26 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH 1/6] EmbeddedPkg: rename NullDmaLib to CoherentDmaLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Aug 2017 10:49:46 -0000 Content-Type: text/plain; charset="UTF-8" On 30 August 2017 at 11:46, Leif Lindholm wrote: > On Wed, Aug 30, 2017 at 09:21:03AM +0100, Ard Biesheuvel wrote: >> Rename NullDmaLib to CoherentDmaLib to better reflect its nature, and >> to better convey the fact that it actually serves a useful purpose, >> i.e., as a DmaLib library class resolution for drivers that control >> hardware that may only be cache coherent or in some cases (i.e., on >> some platforms but not on others). > > The above doesn't read very well (and I'm not 100% certain what it's > trying to say, so can't really propose an improvement). > No other issues with patch. > How about """ The name NullDmaLib suggests that this library is a placeholder that only exists to fulfil formal dependencies on the DmaLib library class without providing an actual implementation (*). This is not the case, though: NullDmaLib does implement DmaLib fully, but doing so simply requires very little effort on a cache coherent platform. So let's rename it to CoherentDmaLib instead. """ * there are such instances in MdeModulePkg that do nothing and ASSERT() in every function.