Re: [PATCH 02/26] OvmfPkg: require GCC48 or later

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On Thu, 3 Jan 2019 at 03:48, Laszlo Ersek <lersek@redhat.com> wrote:
>
> We're about to remove BaseTools support for GCC44..GCC47. Reject those gcc
> versions cleanly in "OvmfPkg/build.sh". In "OvmfPkg/README", upgrade any
> mentions of the same gcc versions to GCC48.
>
> No GCC44..GCC47 references remain under OvmfPkg after this patch.
>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien.grall@linaro.org>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1377
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>
> Notes:
>     I tested that, after this patch, "build.sh" successfully builds OvmfPkg
>     with GCC48. I did no runtime tests, nor did I test the rejection path
>     with any of gcc-4.4 through gcc-4.7.
>
>  OvmfPkg/README   |  6 +++---
>  OvmfPkg/build.sh | 16 ++--------------
>  2 files changed, 5 insertions(+), 17 deletions(-)
>
> diff --git a/OvmfPkg/README b/OvmfPkg/README
> index 7415419d2dd7..68ce0750af19 100644
> --- a/OvmfPkg/README
> +++ b/OvmfPkg/README
> @@ -115,8 +115,8 @@ $ OvmfPkg/build.sh -a X64 qemu
>  And to run a 64-bit UEFI bootable ISO image:
>  $ OvmfPkg/build.sh -a X64 qemu -cdrom /path/to/disk-image.iso
>
> -To build a 32-bit OVMF without debug messages using GCC 4.5:
> -$ OvmfPkg/build.sh -a IA32 -b RELEASE -t GCC45
> +To build a 32-bit OVMF without debug messages using GCC 4.8:
> +$ OvmfPkg/build.sh -a IA32 -b RELEASE -t GCC48
>
>  === SMM support ===
>
> @@ -406,7 +406,7 @@ volume image.
>
>  If you build with the UNIXGCC toolchain, then debugging will be disabled
>  due to larger image sizes being produced by the UNIXGCC toolchain. The
> -first choice recommendation is to use GCC44 or newer instead.
> +first choice recommendation is to use GCC48 or newer instead.
>
>  If you must use UNIXGCC, then you can override the build options for
>  particular libraries and modules in the .dsc to re-enable debugging
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 682155202564..6821742e7acd 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -83,22 +83,10 @@ case `uname` in
>    Linux*)
>      gcc_version=$(gcc -v 2>&1 | tail -1 | awk '{print $3}')
>      case $gcc_version in
> -      [1-3].*|4.[0-3].*)
> -        echo OvmfPkg requires GCC4.4 or later
> +      [1-3].*|4.[0-7].*)
> +        echo OvmfPkg requires GCC4.8 or later
>          exit 1
>          ;;
> -      4.4.*)
> -        TARGET_TOOLS=GCC44
> -        ;;
> -      4.5.*)
> -        TARGET_TOOLS=GCC45
> -        ;;
> -      4.6.*)
> -        TARGET_TOOLS=GCC46
> -        ;;
> -      4.7.*)
> -        TARGET_TOOLS=GCC47
> -        ;;
>        4.8.*)
>          TARGET_TOOLS=GCC48
>          ;;
> --
> 2.19.1.3.g30247aa5d201
>
>