From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d43; helo=mail-io1-xd43.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EBB4A211A2D85 for ; Thu, 3 Jan 2019 01:33:22 -0800 (PST) Received: by mail-io1-xd43.google.com with SMTP id b16so6914474ior.1 for ; Thu, 03 Jan 2019 01:33:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4nbacBPzahlToE1cKLtPlOYqRFWGdf0lYmCf+zBQS9Q=; b=FbBHdXX5JxCLhLvrFVy79PHFSv3G8QP6GGU5HLmzQUKPtkI+bT0VC1Pnyw5lQZl2X9 mWCFl9TOOEh0Q7lbaUsnj7Obv2Dtu3KP1S9lqcOwjK18b4ivIVcxHAjqGdSMbndlgZTP tTl6wK8iFc6YXgbX7Z4cuZXymtw44ttMX8rzI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4nbacBPzahlToE1cKLtPlOYqRFWGdf0lYmCf+zBQS9Q=; b=onZks7H6AnKrytXp+o1XUCeovOjYBQEB9VTzlJygHdICZ0BROkf+oxNUY68qF0gMPb YrVtXr5LAA3XIcPsz0Crir/+KDZvozbv3y40Q8BH95whON0Se3+zI6B088QD5yJDcEGf UP30FJXLSxhbRoc8uvaLMZjFYPfjeh4136E4oAaBCmCgRgjgV1oAQCJZMGz4UCUch4a1 gwv/Kw8NBQctYjpil5kVP3PXzy/cAoW0tdrq3QVAfvm41+2lAtJE2uxG4tDSUwyNPY2J M05OhRLEbtuCMQrPM0vPtTJLJNeKLR/arFfkotgJ5Rb3E/Yd7mWapuPIkh2BDEdwaPDX +Uuw== X-Gm-Message-State: AJcUukepaXpJS0U5TIMosa52tGrFr79uIeox7nb0WDB4O1z+mgldhOhK MPANE4bL0SkTzEFsjcXwKdR7r+mrIMdD3LP0cRweUA== X-Google-Smtp-Source: ALg8bN6vWzdE4aTip3f8Y0cRnqkhuzc0l4SHnzoabkQFsrWEdgq5lJEYb7EDP/0pvk3flxgpiF6iWuRBna6BJvJmKlg= X-Received: by 2002:a5d:8410:: with SMTP id i16mr20051777ion.173.1546508002112; Thu, 03 Jan 2019 01:33:22 -0800 (PST) MIME-Version: 1.0 References: <20190103024816.9236-1-lersek@redhat.com> <20190103024816.9236-3-lersek@redhat.com> In-Reply-To: <20190103024816.9236-3-lersek@redhat.com> From: Ard Biesheuvel Date: Thu, 3 Jan 2019 10:33:10 +0100 Message-ID: To: Laszlo Ersek Cc: edk2-devel-01 , Anthony Perard , Jordan Justen , Julien Grall Subject: Re: [PATCH 02/26] OvmfPkg: require GCC48 or later X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2019 09:33:23 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, 3 Jan 2019 at 03:48, Laszlo Ersek wrote: > > We're about to remove BaseTools support for GCC44..GCC47. Reject those gcc > versions cleanly in "OvmfPkg/build.sh". In "OvmfPkg/README", upgrade any > mentions of the same gcc versions to GCC48. > > No GCC44..GCC47 references remain under OvmfPkg after this patch. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1377 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel > --- > > Notes: > I tested that, after this patch, "build.sh" successfully builds OvmfPkg > with GCC48. I did no runtime tests, nor did I test the rejection path > with any of gcc-4.4 through gcc-4.7. > > OvmfPkg/README | 6 +++--- > OvmfPkg/build.sh | 16 ++-------------- > 2 files changed, 5 insertions(+), 17 deletions(-) > > diff --git a/OvmfPkg/README b/OvmfPkg/README > index 7415419d2dd7..68ce0750af19 100644 > --- a/OvmfPkg/README > +++ b/OvmfPkg/README > @@ -115,8 +115,8 @@ $ OvmfPkg/build.sh -a X64 qemu > And to run a 64-bit UEFI bootable ISO image: > $ OvmfPkg/build.sh -a X64 qemu -cdrom /path/to/disk-image.iso > > -To build a 32-bit OVMF without debug messages using GCC 4.5: > -$ OvmfPkg/build.sh -a IA32 -b RELEASE -t GCC45 > +To build a 32-bit OVMF without debug messages using GCC 4.8: > +$ OvmfPkg/build.sh -a IA32 -b RELEASE -t GCC48 > > === SMM support === > > @@ -406,7 +406,7 @@ volume image. > > If you build with the UNIXGCC toolchain, then debugging will be disabled > due to larger image sizes being produced by the UNIXGCC toolchain. The > -first choice recommendation is to use GCC44 or newer instead. > +first choice recommendation is to use GCC48 or newer instead. > > If you must use UNIXGCC, then you can override the build options for > particular libraries and modules in the .dsc to re-enable debugging > diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh > index 682155202564..6821742e7acd 100755 > --- a/OvmfPkg/build.sh > +++ b/OvmfPkg/build.sh > @@ -83,22 +83,10 @@ case `uname` in > Linux*) > gcc_version=$(gcc -v 2>&1 | tail -1 | awk '{print $3}') > case $gcc_version in > - [1-3].*|4.[0-3].*) > - echo OvmfPkg requires GCC4.4 or later > + [1-3].*|4.[0-7].*) > + echo OvmfPkg requires GCC4.8 or later > exit 1 > ;; > - 4.4.*) > - TARGET_TOOLS=GCC44 > - ;; > - 4.5.*) > - TARGET_TOOLS=GCC45 > - ;; > - 4.6.*) > - TARGET_TOOLS=GCC46 > - ;; > - 4.7.*) > - TARGET_TOOLS=GCC47 > - ;; > 4.8.*) > TARGET_TOOLS=GCC48 > ;; > -- > 2.19.1.3.g30247aa5d201 > >