Re: [platforms: PATCH 2/7] Drivers/Net/Pp2Dxe: Add SFI support

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 1 September 2017 at 10:49, Marcin Wojtas <mw@semihalf.com> wrote:
> 2017-09-01 11:40 GMT+02:00 Ard Biesheuvel <ard.biesheuvel@linaro.org>:
>> On 1 September 2017 at 10:39, Marcin Wojtas <mw@semihalf.com> wrote:
>>> Hi Ard,
>>>
>>> 2017-09-01 11:26 GMT+02:00 Ard Biesheuvel <ard.biesheuvel@linaro.org>:
>>>>
>>>> On 1 September 2017 at 03:37, Marcin Wojtas <mw@semihalf.com> wrote:
>>>> > Since now SerDes can be properly configured to support 10G
>>>> > link, add this feature to the Armada 7k/8k network driver
>>>> > as well. This patch extends low-level configuration routines
>>>> > with SFI additions, which required two new fields in
>>>> > PP2DXE_PORT structure (XpcsBase and MpcsBase).
>>>> >
>>>> > Contributed-under: TianoCore Contribution Agreement 1.0
>>>> > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
>>>>
>>>> If you need to resend this, please fix your indentation: either
>>>>
>>>> Status = Function(xxx, xxx,
>>>>            xxx, xxx, etc);
>>>>
>>>> (two spaces indentation relative to the function name)
>>>>
>>>> or
>>>>
>>>> Status = Function (xxx,
>>>>                    xxx,
>>>>                    xxx,
>>>>                    etc);
>>>>
>>>> Other than that
>>>>
>>>
>>> In 5.2.2.4 of https://edk2-docs.gitbooks.io/edk-ii-c-coding-standards-specification/content/5_source_files/52_spacing.html#52-spacing
>>> there's indeed 2 spaces of indentation relative to function name, but
>>> shouldn't correct multiline call look following:
>>>
>>> Status = Function (
>>>                 aaa,
>>>                 bbb
>>>                 );
>>> ?
>>>
>>
>>
>> There was a lot of discussion about this (unfortunately), but putting
>> the function name and the closing parenthesis on a separate line is
>> really not necessary.
>
> Would following be acceptable?
>
> Status = Function (
>                  aaa,
>                  bbb);
>

Please use one of the two options I suggested.