From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ard.biesheuvel@linaro.org>
Received: from mail-io0-x236.google.com (mail-io0-x236.google.com
 [IPv6:2607:f8b0:4001:c06::236])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 503A621E62BA7
 for <edk2-devel@lists.01.org>; Fri,  1 Sep 2017 02:48:29 -0700 (PDT)
Received: by mail-io0-x236.google.com with SMTP id z67so3078210iof.2
 for <edk2-devel@lists.01.org>; Fri, 01 Sep 2017 02:51:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=r4kNMla5EZHtbESYNqjW8w6r+ASt+6vLXyA2ljhE/As=;
 b=R8vj/XtLHysQpx+yMxFCUAN33DbT8EtNsA5WyDRxPDdI8PtihM2E/i3wBec07SKXUj
 +i85Mvi1cruWl3pgOO531ofmcnolvJ12JuyyHtfey2SfveERlco//IKibzJNQHePJXaT
 CyRIKe1dzDrlFDIARsU/gRWj33uswktUEYa+o=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=r4kNMla5EZHtbESYNqjW8w6r+ASt+6vLXyA2ljhE/As=;
 b=W5Q8Bg8wZIqssiz7naFzI507AClucIgOgpJoZ/8qDXQdyood6toX6fmvuUs0mVu4so
 Xhvp3kFt0BzMym7YT0NqqYVy7QKvjG91Anw1RPYZWseRFH+sRQdq/Q/rI//k6CZQC6a4
 mvAEbttSq+bTxlU7YvMqAVMqYJz0BILCKVYsaB5jIas8y8OJWi/y++E09E/M2fvyoIi+
 kDw7HF0+xa5OP98m8xP/R/aSqheVmr6QSNLKK9yuTWh41TS8XeRrzK2vqU2MhcVhAURH
 Ajx78NrrZLsp47bIIuuq9bNcGoqKju4U6hyxb17x+7jypT4B6IYMHGRT+nJXVAxQQADO
 D4fw==
X-Gm-Message-State: AHPjjUj32pvoXWU9DkCuTBqFCTP6iaJTJJdKPZmFiwRLmm8r+u/bXLi3
 oQ83OaeFg60GUv0aVTQR+OPyxlrAtvOz
X-Google-Smtp-Source: ADKCNb5dDOz0dkY76iTFiMkwTSe4NtV/Mh39+nKM8DECg4Dgr5ysxGo+zGcx4IevzM4ISCGU2UWt3WgT59NdXTdhpq0=
X-Received: by 10.36.170.9 with SMTP id b9mr43752itf.63.1504259472902; Fri, 01
 Sep 2017 02:51:12 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.107.162.1 with HTTP; Fri, 1 Sep 2017 02:51:12 -0700 (PDT)
In-Reply-To: <CAPv3WKfrsvRduvVqY8deyHMOS0Dy1qufnxyrkW_rmyNUc9OoAw@mail.gmail.com>
References: <1504233451-6455-1-git-send-email-mw@semihalf.com>
 <1504233451-6455-3-git-send-email-mw@semihalf.com>
 <CAKv+Gu91kKdxucZ7+bXKHnm5nSQcN4Dmi11xqn8hW6TJ6LCxgw@mail.gmail.com>
 <CAPv3WKdH=fETT0BZRTvrFJm3aqLFeJ7HEnf7tN8XuJMpMvKJVg@mail.gmail.com>
 <CAKv+Gu-MwfF9X8zwb1ob5CkBqpccq3-gU2p+vdXCo_ScwkgvjA@mail.gmail.com>
 <CAPv3WKfrsvRduvVqY8deyHMOS0Dy1qufnxyrkW_rmyNUc9OoAw@mail.gmail.com>
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date: Fri, 1 Sep 2017 10:51:12 +0100
Message-ID: <CAKv+Gu_QeA3=2SAhBNwd4o_u_J55UEede5QwVTkigm1o+THE-g@mail.gmail.com>
To: Marcin Wojtas <mw@semihalf.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
 Leif Lindholm <leif.lindholm@linaro.org>, 
 Nadav Haklai <nadavh@marvell.com>, Neta Zur Hershkovits <neta@marvell.com>, 
 Kostya Porotchkin <kostap@marvell.com>, Hua Jing <jinghua@marvell.com>,
 Alexander Graf <agraf@suse.de>, 
 =?UTF-8?B?SmFuIETEhWJyb8Wb?= <jsd@semihalf.com>
Subject: Re: [platforms: PATCH 2/7] Drivers/Net/Pp2Dxe: Add SFI support
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Sep 2017 09:48:29 -0000
Content-Type: text/plain; charset="UTF-8"

On 1 September 2017 at 10:49, Marcin Wojtas <mw@semihalf.com> wrote:
> 2017-09-01 11:40 GMT+02:00 Ard Biesheuvel <ard.biesheuvel@linaro.org>:
>> On 1 September 2017 at 10:39, Marcin Wojtas <mw@semihalf.com> wrote:
>>> Hi Ard,
>>>
>>> 2017-09-01 11:26 GMT+02:00 Ard Biesheuvel <ard.biesheuvel@linaro.org>:
>>>>
>>>> On 1 September 2017 at 03:37, Marcin Wojtas <mw@semihalf.com> wrote:
>>>> > Since now SerDes can be properly configured to support 10G
>>>> > link, add this feature to the Armada 7k/8k network driver
>>>> > as well. This patch extends low-level configuration routines
>>>> > with SFI additions, which required two new fields in
>>>> > PP2DXE_PORT structure (XpcsBase and MpcsBase).
>>>> >
>>>> > Contributed-under: TianoCore Contribution Agreement 1.0
>>>> > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
>>>>
>>>> If you need to resend this, please fix your indentation: either
>>>>
>>>> Status = Function(xxx, xxx,
>>>>            xxx, xxx, etc);
>>>>
>>>> (two spaces indentation relative to the function name)
>>>>
>>>> or
>>>>
>>>> Status = Function (xxx,
>>>>                    xxx,
>>>>                    xxx,
>>>>                    etc);
>>>>
>>>> Other than that
>>>>
>>>
>>> In 5.2.2.4 of https://edk2-docs.gitbooks.io/edk-ii-c-coding-standards-specification/content/5_source_files/52_spacing.html#52-spacing
>>> there's indeed 2 spaces of indentation relative to function name, but
>>> shouldn't correct multiline call look following:
>>>
>>> Status = Function (
>>>                 aaa,
>>>                 bbb
>>>                 );
>>> ?
>>>
>>
>>
>> There was a lot of discussion about this (unfortunately), but putting
>> the function name and the closing parenthesis on a separate line is
>> really not necessary.
>
> Would following be acceptable?
>
> Status = Function (
>                  aaa,
>                  bbb);
>

Please use one of the two options I suggested.