From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=If/AK19A;
 spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67])
 by groups.io with SMTP; Thu, 05 Sep 2019 10:21:25 -0700
Received: by mail-wm1-f67.google.com with SMTP id p13so4045004wmh.1
        for <devel@edk2.groups.io>; Thu, 05 Sep 2019 10:21:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=5k+YGqVsFFpclfzRrs1BJS5KcyufGlNf7FfpdObxlEo=;
        b=If/AK19A0zstiKzgzOiEC6740qaOkUrFH888uPWNGLZ591k1Ti4BRuUHi83C4P3Fxg
         NLog081QBMuG80YHfImQ2IVz93O5elj7uQ+vXQUgSG6UKOITCEO5TiWedD6vZaBqFtGk
         o4QhUrBJ/x4plRgiQ1RclZ+uxuq190q4Qd9XLu4jJ3CM1xpi0z8Ub3iYlsnCvN0OWKeK
         18pPRFw9kt5NSBEnodyVRnpNLhm5r2iwoypH4jfnFUcFb+A8+51glWF4UvkwHC+DY0KR
         sVyEWJ/d6exuCVPt5sMHxFTF+A/w5Sum1onWeVcvh6H/JpDG9xm7oEOm6/jixQh8cqn0
         1x6A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=5k+YGqVsFFpclfzRrs1BJS5KcyufGlNf7FfpdObxlEo=;
        b=pir53s00eBQMaWK75M79ATIQUDf2xAE5FBNg2NgK2D6XyxEwYbNVgRIJOAWrtx60Uw
         a7mHXBV57JtDIJ6xHKE7OkBq5cxzICwSOu2SwHA73G6vRQNoW7ptLtxPe8fxET3VSZuW
         K78DVyfeRFr2k1BWZ6KnB1piSTRoYUZkVTQ7D8iW48Hia6hgZP63G4LUS9qNeJ5VH6wu
         z56ETXaUKdxEBtodBHZcwRJyFZ4Y51ol2rDfzT0WERdsW6by2AMXsdK3AU0qdMbAlol3
         nCklnI3yj9/LhG2fbxKLlY/H7PkJKlvUOr2qRGJ+InMqkQUV3ey2T6NqF1iVeQasER48
         awOA==
X-Gm-Message-State: APjAAAUyDF73gBAMKEvVN6CXSXGC4bBalWXUwScHt+8cH/w03O1RDWjD
	09OYkBMNfk25FffDGiWHYPuqyUkIY0GvHTYpR95uuw==
X-Google-Smtp-Source: APXvYqykckb7h7H7P5AxlqRSyqiK5clzi+Y+r+oyVlngYjcpAJnbk1xpQ61Bpz564XSsPOxVcP+9x6zMgM5tF+HHB0Q=
X-Received: by 2002:a7b:cf37:: with SMTP id m23mr3954588wmg.53.1567704083861;
 Thu, 05 Sep 2019 10:21:23 -0700 (PDT)
MIME-Version: 1.0
References: <20190904163434.16836-1-ard.biesheuvel@linaro.org>
 <20190904163738.GN29255@bivouac.eciton.net> <3CE959C139B4C44DBEA1810E3AA6F9000B836669@SHSMSX101.ccr.corp.intel.com>
In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B836669@SHSMSX101.ccr.corp.intel.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Thu, 5 Sep 2019 10:21:10 -0700
Message-ID: <CAKv+Gu_QiapxtpBKgNhjbeweZPKTjKrHmzV-xchQ51Hw+TWCkA@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH] ShellPkg/ShellPkg.dsc AARCH64: enable stack protector
To: "Gao, Zhichao" <zhichao.gao@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>, 
	"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>, "Carsey, Jaben" <jaben.carsey@intel.com>, 
	"Ni, Ray" <ray.ni@intel.com>, "Gao, Liming" <liming.gao@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Wed, 4 Sep 2019 at 19:20, Gao, Zhichao <zhichao.gao@intel.com> wrote:
>
> Acked-by: Zhichao Gao <zhichao.gao@intel.com>
>

Thanks

Pushed as 04d9d89b7dd4..23908d0f5cc6

> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Leif Lindholm
> > Sent: Thursday, September 5, 2019 12:38 AM
> > To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: devel@edk2.groups.io; Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray
> > <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Gao, Liming
> > <liming.gao@intel.com>
> > Subject: Re: [edk2-devel] [PATCH] ShellPkg/ShellPkg.dsc AARCH64: enable
> > stack protector
> >
> > On Wed, Sep 04, 2019 at 09:34:34AM -0700, Ard Biesheuvel wrote:
> > > Incorporate the stack protector library into the AARCH64 build of the
> > > Shell binaries as a NULL library resolution, to avoid build errors
> > > when the compiler injects stack integrity checks.
> > >
> > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >
> > Surprised we hadn't triggered this earlier.
> > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> >
> >
> > > ---
> > >  ShellPkg/ShellPkg.dsc | 5 +----
> > >  1 file changed, 1 insertion(+), 4 deletions(-)
> > >
> > > diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc index
> > > b2065dc028d8..91493400cab7 100644
> > > --- a/ShellPkg/ShellPkg.dsc
> > > +++ b/ShellPkg/ShellPkg.dsc
> > > @@ -58,7 +58,7 @@
> > >    DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> > >
> > >
> > ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseR
> > ep
> > > ortStatusCodeLibNull.inf
> > >
> > > -[LibraryClasses.ARM]
> > > +[LibraryClasses.ARM,LibraryClasses.AARCH64]
> > >    #
> > >    # It is not possible to prevent the ARM compiler for generic intrinsic
> > functions.
> > >    # This library provides the instrinsic functions generate by a given
> > compiler.
> > > @@ -69,9 +69,6 @@
> > >    # Add support for GCC stack protector
> > >    NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
> > >
> > > -[LibraryClasses.AARCH64]
> > > -  NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
> > > -
> > >  [PcdsFixedAtBuild]
> > >    gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0xFF
> > >    gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|16000
> > > --
> > > 2.17.1
> > >
> >
> > 
>