* [PATCH] ArmVirtPkg: drop unused Pcds from ArmVirt.dsc.inc
@ 2017-08-24 16:20 Leif Lindholm
2017-08-24 16:59 ` Laszlo Ersek
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2017-08-24 16:20 UTC (permalink / raw)
To: edk2-devel; +Cc: Ard Biesheuvel, Laszlo Ersek
A block of settings has been copied around ARM platforms for years.
These are consumed only by Ebl, and since none of the ArmVirtPkg
platforms use that, drop them.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
ArmVirtPkg/ArmVirt.dsc.inc | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
index bfc40286d7..6a5544e695 100644
--- a/ArmVirtPkg/ArmVirt.dsc.inc
+++ b/ArmVirtPkg/ArmVirt.dsc.inc
@@ -259,18 +259,6 @@
[PcdsFeatureFlag.common]
gEfiMdeModulePkgTokenSpaceGuid.PcdHiiOsRuntimeSupport|FALSE
- #
- # Control what commands are supported from the UI
- # Turn these on and off to add features or save size
- #
- gEmbeddedTokenSpaceGuid.PcdEmbeddedMacBoot|TRUE
- gEmbeddedTokenSpaceGuid.PcdEmbeddedDirCmd|TRUE
- gEmbeddedTokenSpaceGuid.PcdEmbeddedHobCmd|TRUE
- gEmbeddedTokenSpaceGuid.PcdEmbeddedHwDebugCmd|TRUE
- gEmbeddedTokenSpaceGuid.PcdEmbeddedPciDebugCmd|TRUE
- gEmbeddedTokenSpaceGuid.PcdEmbeddedIoEnable|FALSE
- gEmbeddedTokenSpaceGuid.PcdEmbeddedScriptCmd|FALSE
-
gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE
# Use the Vector Table location in CpuDxe. We will not copy the Vector Table at PcdCpuVectorBaseAddress
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ArmVirtPkg: drop unused Pcds from ArmVirt.dsc.inc
2017-08-24 16:20 [PATCH] ArmVirtPkg: drop unused Pcds from ArmVirt.dsc.inc Leif Lindholm
@ 2017-08-24 16:59 ` Laszlo Ersek
2017-08-24 18:30 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Laszlo Ersek @ 2017-08-24 16:59 UTC (permalink / raw)
To: Leif Lindholm, edk2-devel; +Cc: Ard Biesheuvel
On 08/24/17 18:20, Leif Lindholm wrote:
> A block of settings has been copied around ARM platforms for years.
> These are consumed only by Ebl, and since none of the ArmVirtPkg
> platforms use that, drop them.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> ArmVirtPkg/ArmVirt.dsc.inc | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index bfc40286d7..6a5544e695 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -259,18 +259,6 @@
> [PcdsFeatureFlag.common]
> gEfiMdeModulePkgTokenSpaceGuid.PcdHiiOsRuntimeSupport|FALSE
>
> - #
> - # Control what commands are supported from the UI
> - # Turn these on and off to add features or save size
> - #
> - gEmbeddedTokenSpaceGuid.PcdEmbeddedMacBoot|TRUE
> - gEmbeddedTokenSpaceGuid.PcdEmbeddedDirCmd|TRUE
> - gEmbeddedTokenSpaceGuid.PcdEmbeddedHobCmd|TRUE
> - gEmbeddedTokenSpaceGuid.PcdEmbeddedHwDebugCmd|TRUE
> - gEmbeddedTokenSpaceGuid.PcdEmbeddedPciDebugCmd|TRUE
> - gEmbeddedTokenSpaceGuid.PcdEmbeddedIoEnable|FALSE
> - gEmbeddedTokenSpaceGuid.PcdEmbeddedScriptCmd|FALSE
> -
> gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE
>
> # Use the Vector Table location in CpuDxe. We will not copy the Vector Table at PcdCpuVectorBaseAddress
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks,
Laszlo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ArmVirtPkg: drop unused Pcds from ArmVirt.dsc.inc
2017-08-24 16:59 ` Laszlo Ersek
@ 2017-08-24 18:30 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2017-08-24 18:30 UTC (permalink / raw)
To: Laszlo Ersek; +Cc: Leif Lindholm, edk2-devel@lists.01.org
On 24 August 2017 at 17:59, Laszlo Ersek <lersek@redhat.com> wrote:
> On 08/24/17 18:20, Leif Lindholm wrote:
>> A block of settings has been copied around ARM platforms for years.
>> These are consumed only by Ebl, and since none of the ArmVirtPkg
>> platforms use that, drop them.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>> ---
>> ArmVirtPkg/ArmVirt.dsc.inc | 12 ------------
>> 1 file changed, 12 deletions(-)
>>
>> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
>> index bfc40286d7..6a5544e695 100644
>> --- a/ArmVirtPkg/ArmVirt.dsc.inc
>> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
>> @@ -259,18 +259,6 @@
>> [PcdsFeatureFlag.common]
>> gEfiMdeModulePkgTokenSpaceGuid.PcdHiiOsRuntimeSupport|FALSE
>>
>> - #
>> - # Control what commands are supported from the UI
>> - # Turn these on and off to add features or save size
>> - #
>> - gEmbeddedTokenSpaceGuid.PcdEmbeddedMacBoot|TRUE
>> - gEmbeddedTokenSpaceGuid.PcdEmbeddedDirCmd|TRUE
>> - gEmbeddedTokenSpaceGuid.PcdEmbeddedHobCmd|TRUE
>> - gEmbeddedTokenSpaceGuid.PcdEmbeddedHwDebugCmd|TRUE
>> - gEmbeddedTokenSpaceGuid.PcdEmbeddedPciDebugCmd|TRUE
>> - gEmbeddedTokenSpaceGuid.PcdEmbeddedIoEnable|FALSE
>> - gEmbeddedTokenSpaceGuid.PcdEmbeddedScriptCmd|FALSE
>> -
>> gEmbeddedTokenSpaceGuid.PcdCacheEnable|TRUE
>>
>> # Use the Vector Table location in CpuDxe. We will not copy the Vector Table at PcdCpuVectorBaseAddress
>>
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
Pushed as ae9e4650cdf8a7e6790f74e54a9276700dd9d894
Thanks,
Ard.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-24 18:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-24 16:20 [PATCH] ArmVirtPkg: drop unused Pcds from ArmVirt.dsc.inc Leif Lindholm
2017-08-24 16:59 ` Laszlo Ersek
2017-08-24 18:30 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox