public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: "Zeng, Star" <star.zeng@intel.com>
Cc: "Gao, Liming" <liming.gao@intel.com>,
	 "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch 0/3] Update LZMA SDK version to the latest 18.05
Date: Tue, 9 Oct 2018 08:06:47 +0200	[thread overview]
Message-ID: <CAKv+Gu_THaAzLY_xMxGqbut1uOG2JCqbdRnqYDhhnf=4tsgJfQ@mail.gmail.com> (raw)
In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BC0BDE8@shsmsx102.ccr.corp.intel.com>

On 8 October 2018 at 03:36, Zeng, Star <star.zeng@intel.com> wrote:
> Reviewed-by: Star Zeng <star.zeng@intel.com>
>

This change is breaking the build on GCC

Sdk/C/LzmaEnc.c: In function ‘GetOptimum’:
Sdk/C/LzmaEnc.c:1467:9: error: this ‘for’ clause does not guard...
[-Werror=misleading-indentation]
         for (len = 3; len < limit && data[len] == data2[len]; len++);


> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming Gao
> Sent: Wednesday, August 29, 2018 8:51 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch 0/3] Update LZMA SDK version to the latest 18.05
>
> Liming Gao (3):
>   IntelFrameworkModulePkg Lzma: Update LZMA SDK version to 18.05
>   MdeModulePkg Lzma: Update LZMA SDK version to 18.05
>   BaseTools Lzma: Update LZMA SDK version to 18.05
>
>  .../Source/C/LzmaCompress/LZMA-SDK-README.txt      |    4 +-
>  BaseTools/Source/C/LzmaCompress/LzmaCompress.c     |    8 +-
>  BaseTools/Source/C/LzmaCompress/Sdk/C/7zFile.c     |   28 +-
>  BaseTools/Source/C/LzmaCompress/Sdk/C/7zFile.h     |    8 +-
>  BaseTools/Source/C/LzmaCompress/Sdk/C/7zStream.c   |  111 +-
>  BaseTools/Source/C/LzmaCompress/Sdk/C/7zTypes.h    |  220 +-
>  BaseTools/Source/C/LzmaCompress/Sdk/C/7zVersion.h  |   22 +-
>  BaseTools/Source/C/LzmaCompress/Sdk/C/Alloc.c      |  399 +++-
>  BaseTools/Source/C/LzmaCompress/Sdk/C/Alloc.h      |   20 +-
>  BaseTools/Source/C/LzmaCompress/Sdk/C/Bra86.c      |    4 +-
>  BaseTools/Source/C/LzmaCompress/Sdk/C/Compiler.h   |    3 +-
>  BaseTools/Source/C/LzmaCompress/Sdk/C/CpuArch.h    |  166 +-
>  BaseTools/Source/C/LzmaCompress/Sdk/C/LzFind.c     |  163 +-
>  BaseTools/Source/C/LzmaCompress/Sdk/C/LzFind.h     |   12 +-
>  BaseTools/Source/C/LzmaCompress/Sdk/C/LzFindMt.c   |   67 +-
>  BaseTools/Source/C/LzmaCompress/Sdk/C/LzFindMt.h   |    6 +-
>  BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaDec.c    |  401 ++--
>  BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaDec.h    |   47 +-
>  BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c    | 2334 ++++++++++++--------
>  BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.h    |   48 +-
>  BaseTools/Source/C/LzmaCompress/Sdk/C/Threads.c    |   14 +-
>  BaseTools/Source/C/LzmaCompress/Sdk/C/Threads.h    |    5 +-
>  .../Source/C/LzmaCompress/Sdk/DOC/lzma-history.txt |   63 +-
>  .../Source/C/LzmaCompress/Sdk/DOC/lzma-sdk.txt     |    2 +-
>  .../LzmaCustomDecompressLib/LZMA-SDK-README.txt    |    6 +-
>  .../LzmaArchCustomDecompressLib.inf                |    6 +-
>  .../LzmaCustomDecompressLib.inf                    |    6 +-
>  .../LzmaCustomDecompressLib/LzmaDecompress.c       |    4 +-
>  .../LzmaCustomDecompressLib/Sdk/C/7zTypes.h        |  220 +-
>  .../LzmaCustomDecompressLib/Sdk/C/7zVersion.h      |   22 +-
>  .../Library/LzmaCustomDecompressLib/Sdk/C/Bra86.c  |    4 +-
>  .../LzmaCustomDecompressLib/Sdk/C/Compiler.h       |    3 +-
>  .../LzmaCustomDecompressLib/Sdk/C/CpuArch.h        |  166 +-
>  .../Library/LzmaCustomDecompressLib/Sdk/C/LzFind.c |  163 +-
>  .../Library/LzmaCustomDecompressLib/Sdk/C/LzFind.h |   12 +-
>  .../LzmaCustomDecompressLib/Sdk/C/LzmaDec.c        |  401 ++--
>  .../LzmaCustomDecompressLib/Sdk/C/LzmaDec.h        |   47 +-
>  .../Sdk/DOC/lzma-history.txt                       |   63 +-
>  .../LzmaCustomDecompressLib/Sdk/DOC/lzma-sdk.txt   |    2 +-
>  .../LzmaCustomDecompressLib/LZMA-SDK-README.txt    |    6 +-
>  .../LzmaArchCustomDecompressLib.inf                |    6 +-
>  .../LzmaCustomDecompressLib.inf                    |    6 +-
>  .../LzmaCustomDecompressLib/LzmaDecompress.c       |    4 +-
>  .../LzmaCustomDecompressLib/Sdk/C/7zTypes.h        |  220 +-
>  .../LzmaCustomDecompressLib/Sdk/C/7zVersion.h      |   22 +-
>  .../Library/LzmaCustomDecompressLib/Sdk/C/Bra86.c  |    4 +-
>  .../LzmaCustomDecompressLib/Sdk/C/Compiler.h       |    3 +-
>  .../LzmaCustomDecompressLib/Sdk/C/CpuArch.h        |  166 +-
>  .../Library/LzmaCustomDecompressLib/Sdk/C/LzFind.c |  163 +-
>  .../Library/LzmaCustomDecompressLib/Sdk/C/LzFind.h |   12 +-
>  .../LzmaCustomDecompressLib/Sdk/C/LzmaDec.c        |  401 ++--
>  .../LzmaCustomDecompressLib/Sdk/C/LzmaDec.h        |   47 +-
>  .../Sdk/DOC/lzma-history.txt                       |   63 +-
>  .../LzmaCustomDecompressLib/Sdk/DOC/lzma-sdk.txt   |    2 +-
>  54 files changed, 4230 insertions(+), 2175 deletions(-)
>
> --
> 2.10.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2018-10-09  6:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29  0:51 [Patch 0/3] Update LZMA SDK version to the latest 18.05 Liming Gao
2018-08-29  0:51 ` [Patch 1/3] IntelFrameworkModulePkg Lzma: Update LZMA SDK version to 18.05 Liming Gao
2018-08-29  0:51 ` [Patch 2/3] MdeModulePkg " Liming Gao
2018-08-29  0:51 ` [Patch 3/3] BaseTools " Liming Gao
2018-10-08  1:36 ` [Patch 0/3] Update LZMA SDK version to the latest 18.05 Zeng, Star
2018-10-09  6:06   ` Ard Biesheuvel [this message]
2018-10-09  6:23     ` Gao, Liming
2018-10-09  6:37       ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu_THaAzLY_xMxGqbut1uOG2JCqbdRnqYDhhnf=4tsgJfQ@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox