Re: [PATCH v5 edk2-platforms 18/22] Platform/RaspberryPi/RPi3 *NON-OSI*: Add ATF binaries

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On Thu, 7 Feb 2019 at 12:35, Pete Batard <pete@akeo.ie> wrote:
>
> On 2019.02.07 02:35, Kinney, Michael D wrote:
> > Hi Pete,
> >
> > When I saw it as a single patch series, I did assume all the
> > patches were for the edk2-platforms repo.  And it looked like
> > non-OSI binaries were going into the edk2-platforms repo.
> >
> > Patch #0 did not make this clear either that multiple repos
> > were targeted.
> >
> > I have not seen a patch series with content for multiple repos.
>
> Well, new ways of doing things have to be introduced sometimes and, to
> make things a lot more convenient for people who submit work (and
> others), I would pressure the edk2 mailing list to accept this kind of
> multiple edk2-platforms + edk2-non-osi patchset submission *for new
> platforms*, where content that is aimed at non-osi is simply tagged
> *NON-OSI* rather than split into 2 separate patchsets. As a global
> timesaver (since it also makes review of a newly introduced platform
> easier IMO, by not risking people to miss the separately submitted
> non-osi content), it does make a lot of sense to me to do it this way,
> rather than enforce a rigid approach.
>
> It also makes life simpler for people who simply want to test (rather
> than review), as they can just apply the full patchset onto their local
> edk2-platforms repo in one breadth, rather than have to hunt and apply
> from 2 different sets. To me, the advantages of doing things in this
> fashion largely outweigh any potential drawback.
>
> > It would be clearer if there were 2 different series.  One for
> > edk2-platforms repo and one for the edk2-non-osi repo.
>
> I'm not planning to resubmit a new patchset just to split between osi
> and non-osi at this stage.
>
> If I hear a lot of backlash, and there is need for a v6, I may split it,
> but I really think this approach of submitting brand new content to
> non-osi, by simply tagging it *NON-OSI* on the subject line, should be
> deemed as an acceptable way to introduce the non-osi content for a new
> platforms.
>

The subject is

[PATCH v5 edk2-platforms 18/22] Platform/RaspberryPi/RPi3 *NON-OSI*:
Add ATF binaries

so it does seem like you are proposing non-osi content to go into
edk2-platforms. Patches
for edk2-non-osi are usually described as

[PATCH vN edk2-non-osi #/#] ...

Your current arrangement also results in a need for me to go and edit
the commit log by hand when I apply the patch, since the part in [] is
stripped by git am, but the rest remains.

Since all changes go to the same list, I don't think it is necessary
to mandate that patches that target different repositories are split
into different series, and I take your point about being to apply
patches, and having the ability to easily figure it which parts belong
together.

So in case there turns out to be a need for a v6, please update the
subjects, but otherwise, we can work with what has been posted to the
list.

Thanks,
Ard.