From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::242; helo=mail-it0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 54C3D21B02845 for ; Fri, 20 Jul 2018 03:01:59 -0700 (PDT) Received: by mail-it0-x242.google.com with SMTP id p17-v6so13850311itc.2 for ; Fri, 20 Jul 2018 03:01:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=sH+CElo4siet+/B5hWvwptfFZ9ftEoUeqPEd1IcsUKw=; b=I+Uoiqew1vtOqaVx2C8OSPPy+v3CKRSvUaaq7xTaEqdkahJo+8q9fJaiwhIbAFNTuu iqYZw9mUTPYQj12znN2yGjT8ObxiHwF4j3a/3I1HpUcvxJvR/jleaZvB8O5lUpC4H5s4 /v96/kJM5dO/0fjI+c1tNtgetqz0xK0D0Kz+w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=sH+CElo4siet+/B5hWvwptfFZ9ftEoUeqPEd1IcsUKw=; b=Kt4ZHiObnk7UtE1oZaQ6eLJp+fw6e+tFJRQ0gri2KFCaWbwC4KSD55oegHvAPeaoJQ qz/Ld0zLYkcS29GwUIarfC2gx75GXYYyWRnkr032H6nDgxV5+VTsDkzezyfOSdzcmEWc bayftf2Z485b+55bBZvxbUdRwxklQY2q4gdS/SvxKNbkBR6xHDiL5/zZo2MaQDQCgj5P yWmF+VDOjUndtUihsirU8uPzfmZZ0Tbon9vx2Z+IqpgHGkoTCd/csgEAH25Vl9cU9gsO 7UvatUWvJDVPdyp8BxHVcnmRgtEUhYb0hIEroCchs5FtdyVA7uQd6Y3CIFOjPeeljJu4 nvZw== X-Gm-Message-State: AOUpUlF5lEEeZPJx2TuNrbkEnlP+NoIFKTHozj3xn8GYlu3C6K2xPTCB zYCARWCF9Z9as1MxJGJMqG0rCJiAitpGlBv46RwV5w== X-Google-Smtp-Source: AAOMgpeTyntvM0RmjVilxExMdLtlXvHLY4ovTbNxW/+wdh80Oz/ihughqa6mBLxQ0zlYzZely+xqecHEqUMj5s7JSH8= X-Received: by 2002:a02:bb04:: with SMTP id y4-v6mr1157146jan.5.1532080918732; Fri, 20 Jul 2018 03:01:58 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:ac05:0:0:0:0:0 with HTTP; Fri, 20 Jul 2018 03:01:58 -0700 (PDT) In-Reply-To: <1532070779-7544-1-git-send-email-sumit.garg@linaro.org> References: <1532070779-7544-1-git-send-email-sumit.garg@linaro.org> From: Ard Biesheuvel Date: Fri, 20 Jul 2018 19:01:58 +0900 Message-ID: To: Sumit Garg Cc: "edk2-devel@lists.01.org" , Patch Tracking , Leif Lindholm Subject: Re: [PATCH edk2-platforms 1/1] Silicon/SynQuacer/DeviceTree: add OP-TEE driver node X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jul 2018 10:02:00 -0000 Content-Type: text/plain; charset="UTF-8" On 20 July 2018 at 16:12, Sumit Garg wrote: > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sumit Garg > --- > Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi b/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi > index 37d642e4b237..d109a5742793 100644 > --- a/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi > +++ b/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi > @@ -574,6 +574,13 @@ > #address-cells = <1>; > #size-cells = <0>; > }; > + > + firmware { > + optee { > + compatible = "linaro,optee-tz"; > + method = "smc"; > + }; > + }; > }; > > #include "SynQuacerCaches.dtsi" Hello Sumit, Is it safe to provide this node when optee is not running? If not, this should be made dependent on that, so we should probably add status = 'disabled', and remove it in PlatformDxe if the DIP switch is not set, and/or if there are other ways we might know that optee is not running.