Re: [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 7 March 2018 at 03:03, Heyi Guo <heyi.guo@linaro.org> wrote:
> Since D0x platforms always have network enabled, we would like to
> enable tftp command by default so that we can download something in
> EFI Shell.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Heyi Guo <heyi.guo@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>

The first patch looks fine to me, but I would like to give Leif a
chance to comment on the policy side of this patch.

Please ping us by the end of next week if we haven't responded by then.

> ---
>  Platform/Hisilicon/D03/D03.dsc | 2 ++
>  Platform/Hisilicon/D05/D05.dsc | 1 +
>  2 files changed, 3 insertions(+)
>
> diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc
> index cb0669d639d1..fce1e60b1275 100644
> --- a/Platform/Hisilicon/D03/D03.dsc
> +++ b/Platform/Hisilicon/D03/D03.dsc
> @@ -29,6 +29,8 @@ [Defines]
>    SKUID_IDENTIFIER               = DEFAULT
>    FLASH_DEFINITION               = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf
>
> +  DEFINE INCLUDE_TFTP_COMMAND    = TRUE
> +
>  !include Silicon/Hisilicon/Hisilicon.dsc.inc
>
>  [LibraryClasses.common]
> diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc
> index 8373a821a496..f007f3d2d7e8 100644
> --- a/Platform/Hisilicon/D05/D05.dsc
> +++ b/Platform/Hisilicon/D05/D05.dsc
> @@ -29,6 +29,7 @@ [Defines]
>    SKUID_IDENTIFIER               = DEFAULT
>    FLASH_DEFINITION               = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf
>    DEFINE EDK2_SKIP_PEICORE=0
> +  DEFINE INCLUDE_TFTP_COMMAND    = TRUE
>    DEFINE NETWORK_IP6_ENABLE      = FALSE
>    DEFINE HTTP_BOOT_ENABLE        = FALSE
>
> --
> 2.7.4
>